Fix #113 Allow setting of a AWS profile when creating the SDK config #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently I haven't added any tests as I wanted to see if the existing tests would still pass before I commit more time to this. Can a maintainer authorize the workflow please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113
When working with many AWS accounts you need to be able to specify different profiles when connecting to given services.
Currently this plugin does not allow the setting of a profile which means you need to remember to run Terraform with
AWS_PROFILE=customprofile terraform planor theGetClusterCredentialscall will fail.If you are using the AWS provider, running Terraform with the
AWS_PROFILEoverrides any explicitly defined profile on the provider.This means when using profiles, under some conditions, you cannot use this provider and the AWS provider in the same project.
This PR adds the option to define a profile which is completely optional. If no profile is defined the provider operates in the same way as it did before.