Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with wp-super-cache #5

Open
nriley opened this issue Feb 5, 2014 · 2 comments
Open

Incompatibility with wp-super-cache #5

nriley opened this issue Feb 5, 2014 · 2 comments

Comments

@nriley
Copy link

nriley commented Feb 5, 2014

WP-Super-Cache checks for $_GET to decide whether to return the cached version of a page, but because live-comment-preview appends ?live-comment-preview.js, it doesn't match and so the cache returns my HTML home page instead of the expected JavaScript.

I was able to fix this by adding an =, e.g.:

function live_preview($before='', $after='') {
                echo '<script src="' . get_option('home') . '/?live-comment-preview.js=" type="text/javascript"></script>';
@mondalaci
Copy link

@bradt I'm also affected by this issue and would like it to be resolved. Is @nriley's solution the best one in your opinion? If so, I could open a pull request for it.

@mondalaci
Copy link

On second thought, why not simply create and reference $wordpressRoot/wp-content/live-comment-preview/live-comment-preview.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants