Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg dependency isn't automatically installed #2

Open
patkujawa-wf opened this issue Sep 22, 2014 · 6 comments
Open

ffmpeg dependency isn't automatically installed #2

patkujawa-wf opened this issue Sep 22, 2014 · 6 comments

Comments

@patkujawa-wf
Copy link

After installing, I get an error that ffmpeg isn't installed. If this is a package for a package manager, well, it should install dependencies, right? ;)

❯  bpkg install -g osx-screencast

    info: Using latest (master)
    info: install: `make install'
rm -f /usr/local/bin/osx-screencast
for c in record export dependencies; do rm -f /usr/local/bin/osx-screencast-${c}; done
cp osx-screencast.sh /usr/local/bin/osx-screencast
for c in record export dependencies; do cp ${c}.sh /usr/local/bin/osx-screencast-${c}; done

[patkujawa@LS2-00159] ~
❯ which osx-screencast
/usr/local/bin/osx-screencast

[patkujawa@LS2-00159] ~
❯ osx-screencast
error: Missing `ffmpeg' dependency

[patkujawa@LS2-00159] ~
❯ osx-screencast -h                                                                             ⏎
error: Missing `ffmpeg' dependency
@stephenmathieson
Copy link
Member

hmm thats a good point. we should install ffmpeg.

@jwerle can we add https://github.com/FFmpeg/FFmpeg as a dep? it's got a makefile with an install target

@jwerle
Copy link
Member

jwerle commented Sep 26, 2014

@stephenmathieson hmm should we be installing things that big on a users system ? We could inform the user that they are missing the dependency and suggest they go to that repository for an install. What do you think ?

@patkujawa-wf
Copy link
Author

That would be better than nothing. Best would be to notify user of the
immensity and allow them to ok the installation to make it seamless, I
think :)

On Fri, Sep 26, 2014 at 9:36 AM, Joseph Werle [email protected]
wrote:

@stephenmathieson https://github.com/stephenmathieson hmm should we be
installing things that big on a users system ? We could inform the user
that they are missing the dependency and suggest they go to that repository
for an install. What do you think ?


Reply to this email directly or view it on GitHub
#2 (comment).

Pat Kujawa

Software Engineer
Workiva formerly WebFilings
Missoula, MT

@stephenmathieson
Copy link
Member

@jwerle no, actually we shouldn't. the install target takes 50,000,000 years to complete. maybe just a warning saying $ brew install ffmpeg would be better?

@patkujawa-wf
Copy link
Author

Ok, brew install ffmpeg is quick and easy. But then I get:

❯ osx-screencast                                                                                                                                                                ⏎
error: Missing `convert' dependency

Output of ffmpeg install:

❯ brew install ffmpeg
==> Installing dependencies for ffmpeg: x264, faac, lame, xvid
==> Installing ffmpeg dependency: x264
==> Downloading https://downloads.sf.net/project/machomebrew/Bottles/x264-r2412.mavericks.bottle.1.tar.gz
######################################################################## 100.0%
==> Pouring x264-r2412.mavericks.bottle.1.tar.gz
🍺  /usr/local/Cellar/x264/r2412: 9 files, 3.4M
==> Installing ffmpeg dependency: faac
==> Downloading https://downloads.sf.net/project/machomebrew/Bottles/faac-1.28.mavericks.bottle.tar.gz
######################################################################## 100.0%
==> Pouring faac-1.28.mavericks.bottle.tar.gz
🍺  /usr/local/Cellar/faac/1.28: 13 files, 720K
==> Installing ffmpeg dependency: lame
==> Downloading https://downloads.sf.net/project/machomebrew/Bottles/lame-3.99.5.mavericks.bottle.tar.gz
######################################################################## 100.0%
==> Pouring lame-3.99.5.mavericks.bottle.tar.gz
🍺  /usr/local/Cellar/lame/3.99.5: 25 files, 2.1M
==> Installing ffmpeg dependency: xvid
==> Downloading https://downloads.sf.net/project/machomebrew/Bottles/xvid-1.3.2.mavericks.bottle.tar.gz
######################################################################## 100.0%
==> Pouring xvid-1.3.2.mavericks.bottle.tar.gz
🍺  /usr/local/Cellar/xvid/1.3.2: 9 files, 1.3M
==> Installing ffmpeg
==> Downloading https://downloads.sf.net/project/machomebrew/Bottles/ffmpeg-2.2.4.mavericks.bottle.tar.gz
######################################################################## 100.0%
==> Pouring ffmpeg-2.2.4.mavericks.bottle.tar.gz
🍺  /usr/local/Cellar/ffmpeg/2.2.4: 192 files, 36M

@jwerle
Copy link
Member

jwerle commented Sep 26, 2014

@stephenmathieson I agree. I can issue a patch.
@patkujawa-wf Ugh, i'm sorry. ImageMagick is also a dependency which provides the convert command. brew install imagemagick to mitigate your issue now

: ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants