Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] progressCallback should take img fetching into account #2700

Open
MrSimmmons opened this issue Feb 29, 2024 · 0 comments
Open

Comments

@MrSimmmons
Copy link

I just tried to implement a progress bar using the progressCallback method, and discovered it only gets called on page rendering. This feature could be better IMO because the render step is very quick taking < 1 second most of the time. However if you have a lot of images in the PDF, they can take quite a while to be fetched if being supplied as a URL.

The progressCallback never gets called during the img fetching which is often the longest part of the export and would create poor UX if a progress bar were to be implemented as it would sit on 0% for the majority of the export process.

It would be good if progressCallback were to be called during the entire export process instead of just the render step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants