Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI, bad «joined» format in Bio? #3427

Open
xmgz opened this issue Sep 5, 2024 · 2 comments
Open

UI, bad «joined» format in Bio? #3427

xmgz opened this issue Sep 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@xmgz
Copy link

xmgz commented Sep 5, 2024

Describe the bug

I think there's an issue with time period format in https://crowdin.com/editor/bookwyrm/1553/en-gl?view=comfortable#41851

Joined %(date)s

«Joined» is translated following UI language, but «%(date)s» portion follows remote user instance's default language so in some cases the format of the two strings do not match and more often than not two languages are mixed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any user profile page
  2. Look at «joined» in Bio

Expected behavior

«%(date)s» language is the same as «joined» and both are set to the UI preference

Screenshots

here you can see several profiles where the problem is shown:

all these bios share "Desde" but the second part is in spanish, english, euskaro, galician

imaxe
imaxe
imaxe
imaxe

diferent languages for date format

Instance

any (seen in versions 0.7.4, 0.7.1 at least)

Additional context

translator here, so I can make a better job :)


@xmgz xmgz added the bug Something isn't working label Sep 5, 2024
@mouse-reeve
Copy link
Member

mouse-reeve commented Sep 5, 2024

this is so strange! It looked at a glance like a caching issues, since template snippets can be cached and inserted in, and if they aren't cached with the language code included, you get weird little mixed language situations like this. But having look at the templates, it doesn't look like there's caching being used here. The text that populated date is user.created_date|naturaltime, which is calling the built-in nautraltime filter. I wonder if it's possible that Django is missing some support for Galician and it's using language fallbacks?

Unfortunately I haven't turned up any evidence that there's something wrong on our end, which would make this much easier to address

@xmgz
Copy link
Author

xmgz commented Sep 6, 2024

thank you for your time reviewing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants