diff --git a/bonita-engine-spring-boot-starter/src/test/java/org/bonitasoft/engine/spring/autoconfigure/BonitaEngineAutoConfigurationTest.java b/bonita-engine-spring-boot-starter/src/test/java/org/bonitasoft/engine/spring/autoconfigure/BonitaEngineAutoConfigurationTest.java index 2f5ba6f5c01..178e75359fa 100644 --- a/bonita-engine-spring-boot-starter/src/test/java/org/bonitasoft/engine/spring/autoconfigure/BonitaEngineAutoConfigurationTest.java +++ b/bonita-engine-spring-boot-starter/src/test/java/org/bonitasoft/engine/spring/autoconfigure/BonitaEngineAutoConfigurationTest.java @@ -57,7 +57,7 @@ public void should_configure_database_using_properties() { assertThat(businessDataDatabaseConfiguration.getXaDatasource().getMaxPoolSize()).isEqualTo(6); assertThat( businessDataDatabaseConfiguration.getDbVendor()) - .isEqualTo("mysql"); + .isEqualTo("mysql"); }); } diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/activity/ContractIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/activity/ContractIT.java index f4997d7af85..0fc90ce509c 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/activity/ContractIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/activity/ContractIT.java @@ -447,13 +447,14 @@ public void use_a_multiple_complex_input_in_user_tasks() throws Exception { waitForUserTaskAndGetIt(TASK2); assertThat((List>) getProcessAPI() .getArchivedActivityDataInstance("expenseData", userTask.getId()).getValue()).as( - "should have my expense report data").hasSize(3); + "should have my expense report data") + .hasSize(3); final Serializable reportData = getProcessAPI().getArchivedActivityDataInstance("reportData", userTask.getId()) .getValue(); assertThat(reportData).as("should have single file").isEqualTo(reportFile); assertThat((List) getProcessAPI().getArchivedActivityDataInstance("receiptsData", userTask.getId()) .getValue()).as("should have multiple file") - .containsExactly(receipt1, receipt2); + .containsExactly(receipt1, receipt2); final List receiptsAsDoc = getProcessAPI().getDocumentList(processInstance.getId(), "receiptsAsDoc", 0, 100); final Document reportAsDoc = getProcessAPI().getLastDocument(processInstance.getId(), "reportAsDoc"); diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/application/ApplicationIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/application/ApplicationIT.java index 47fb49d8392..8363c266f88 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/application/ApplicationIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/application/ApplicationIT.java @@ -168,7 +168,7 @@ public void should_access_identity_api_using_default_application_permissions() t long userId = user.getId(); assertThat( getPermissionAPI().isAuthorized(new APICallContext("GET", "identity", "user", String.valueOf(userId)))) - .isTrue(); + .isTrue(); assertThat(getPermissionAPI() .isAuthorized(new APICallContext("GET", "identity", "user", String.valueOf(userId + 1)))).isFalse(); assertThat(getPermissionAPI().isAuthorized(new APICallContext("GET", "identity", "user", null))).isFalse(); diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/business/data/BDRepositoryIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/business/data/BDRepositoryIT.java index cb3d9082097..4b5717cb0ae 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/business/data/BDRepositoryIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/business/data/BDRepositoryIT.java @@ -149,7 +149,7 @@ public void deploying_bdm_with_invalid_query_should_throw_a_BDM_deployment_excep getTenantAdministrationAPI().cleanAndUninstallBusinessDataModel(); assertThatThrownBy( () -> getTenantAdministrationAPI().updateBusinessDataModel(getZip(buildBOMWithInvalidQuery()))) - .isInstanceOf(BusinessDataRepositoryDeploymentException.class); + .isInstanceOf(BusinessDataRepositoryDeploymentException.class); } @Test @@ -2527,7 +2527,7 @@ public void should_event_sub_process_only_start_element_in_the_event_sub_process waitForUserTask("userTask"); assertThat(new String(getProcessAPI().getDocumentContent( getProcessAPI().getLastDocument(processInstance.getId(), "myDoc").getContentStorageId()))) - .isEqualTo("updatedContents"); + .isEqualTo("updatedContents"); getProcessAPI().sendSignal("theSignal"); //then @@ -2536,7 +2536,7 @@ public void should_event_sub_process_only_start_element_in_the_event_sub_process //instantiation of the event sub process work and did not reinitialized elements assertThat(new String(getProcessAPI().getDocumentContent( getProcessAPI().getLastDocument(processInstance.getId(), "myDoc").getContentStorageId()))) - .isEqualTo("updatedContents"); + .isEqualTo("updatedContents"); assertThat(getProcessAPI().getDocumentList(processInstance.getId(), "MyList", 0, 100)).hasSize(2); try { getProcessAPI().getLastDocument(eventSubProcessActivity.getParentProcessInstanceId(), "myDoc"); @@ -2545,7 +2545,7 @@ public void should_event_sub_process_only_start_element_in_the_event_sub_process } assertThat( getProcessAPI().getDocumentList(eventSubProcessActivity.getParentProcessInstanceId(), "MyList", 0, 100)) - .isEmpty(); + .isEmpty(); disableAndDeleteProcess(processDefinition); } @@ -2590,7 +2590,7 @@ public void should_be_able_to_update_business_object_in_event_sub_process() thro assertThatJson( getBusinessDataAsJson((SimpleBusinessDataReference) getProcessAPI().getProcessInstanceExecutionContext( processInstance.getId()).get("ref_myBusinessData"))) - .node("lastName").isEqualTo("\"Doe\""); + .node("lastName").isEqualTo("\"Doe\""); //when getProcessAPI().sendSignal("theSignal"); waitForUserTask("userTaskInSubProcess"); @@ -2599,7 +2599,7 @@ public void should_be_able_to_update_business_object_in_event_sub_process() thro assertThatJson( getBusinessDataAsJson((SimpleBusinessDataReference) getProcessAPI().getProcessInstanceExecutionContext( processInstance.getId()).get("ref_myBusinessData"))) - .node("lastName").isEqualTo("\"newName\""); + .node("lastName").isEqualTo("\"newName\""); disableAndDeleteProcess(processDefinition); } diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/event/EventTriggerIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/event/EventTriggerIT.java index e80bfa3c9f3..8abb5abce01 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/event/EventTriggerIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/event/EventTriggerIT.java @@ -110,7 +110,7 @@ public void updateTimerEventTriggerInstance() throws Exception { // Without optimisations, it takes around 30 seconds assertThat(Duration.between(LocalDateTime.ofInstant(date.toInstant(), ZoneId.systemDefault()), LocalDateTime.now(ZoneId.systemDefault()))) - .isLessThanOrEqualTo(Duration.ofSeconds(10)); + .isLessThanOrEqualTo(Duration.ofSeconds(10)); assertThat(getProcessAPI().searchTimerEventTriggerInstances(processInstance2.getId(), options).getResult()) .hasSize(1); diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/form/FormMappingIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/form/FormMappingIT.java index 476fe51b69a..682b6944e1a 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/form/FormMappingIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/form/FormMappingIT.java @@ -148,7 +148,8 @@ public void deployProcessesWithFormMappings() throws Exception { processConfigurationAPI .searchFormMappings(new SearchOptionsBuilder(0, 100) .sort(FormMappingSearchDescriptor.ID, Order.DESC).done()) - .getResult()).isEmpty(); + .getResult()) + .isEmpty(); } diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/identity/UserIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/identity/UserIT.java index 2f944216900..5cb20df6bda 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/identity/UserIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/identity/UserIT.java @@ -745,11 +745,11 @@ public void should_search_user_case_insensitively() throws BonitaException { assertThat(getIdentityAPI().searchUsers( new SearchOptionsBuilder(0, 10).searchTerm("jean").sort(UserSearchDescriptor.ID, Order.ASC).done()) .getResult()) - .hasSize(1).allMatch(user -> user.getUserName().equals("Jean_Michel")); + .hasSize(1).allMatch(user -> user.getUserName().equals("Jean_Michel")); assertThat(getIdentityAPI().searchUsers( new SearchOptionsBuilder(0, 10).searchTerm("Jean").sort(UserSearchDescriptor.ID, Order.ASC).done()) .getResult()) - .hasSize(1).allMatch(user -> user.getUserName().equals("Jean_Michel")); + .hasSize(1).allMatch(user -> user.getUserName().equals("Jean_Michel")); deleteUsers(users); } diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/EvaluateExpressionIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/EvaluateExpressionIT.java index 678b3b09b41..33abd919b51 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/EvaluateExpressionIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/EvaluateExpressionIT.java @@ -215,8 +215,8 @@ private ProcessDefinition createAndDeployProcessDefinitionAndInstance(final Stri final DesignProcessDefinition processDef = createProcessDefinitionBuilderWithHumanAndAutomaticSteps( "My_Process", "1.0", Collections.singletonList("step1"), Collections.singletonList(isHuman)) - .addIntegerData(dataName, dataDefaultExp) - .addDescription("Delivery all day and night long").getProcess(); + .addIntegerData(dataName, dataDefaultExp) + .addDescription("Delivery all day and night long").getProcess(); return deployAndEnableProcessWithActor(processDef, "Actor1", user); } diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/document/DocumentIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/document/DocumentIT.java index 67a6bdbdedf..52f6c5e50b6 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/document/DocumentIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/document/DocumentIT.java @@ -701,7 +701,8 @@ public void searchArchivedDocuments() throws Exception { assertThat( getProcessAPI().searchArchivedDocuments(new SearchOptionsBuilder(0, 45).searchTerm("doc1").done()) .getResult().get(0) - .getContentFileName()).isEqualTo("doc1.jpg"); + .getContentFileName()) + .isEqualTo("doc1.jpg"); } finally { disableAndDeleteProcess(processInstance.getProcessDefinitionId()); diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/instance/AbortProcessInstanceIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/instance/AbortProcessInstanceIT.java index 531e7b8534b..e9ff20da7c0 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/instance/AbortProcessInstanceIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/process/instance/AbortProcessInstanceIT.java @@ -440,7 +440,7 @@ private Expression string(String calledProcess) throws InvalidExpressionExceptio private void shouldNotHaveFailedTasks() throws SearchException { assertThat(getProcessAPI().searchArchivedFlowNodeInstances(new SearchOptionsBuilder(0, 1000).done()).getResult() .stream().map(ArchivedFlowNodeInstance::getState)) - .doesNotContain("failed"); + .doesNotContain("failed"); } private List getAllCompletedArchivedFlowNodeInstances() throws SearchException { diff --git a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/supervisor/SupervisorIT.java b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/supervisor/SupervisorIT.java index 781024c114b..1a05d99d668 100644 --- a/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/supervisor/SupervisorIT.java +++ b/bonita-integration-tests/bonita-integration-tests-client/src/test/java/org/bonitasoft/engine/supervisor/SupervisorIT.java @@ -327,9 +327,9 @@ public void deleteSupervisor_should_throw_SupervisorNotFoundException_when_super // Already deleted Supervisor assertThatThrownBy( () -> getProcessAPI().deleteSupervisor(myProcess1.getId(), null, role2.getId(), group2.getId())) - .isInstanceOf(DeletionException.class) - // Only check the name and not the cause, because in HTTP mode, the stacks are merged and the cause removed: - .hasMessageContaining("SupervisorNotFoundException"); + .isInstanceOf(DeletionException.class) + // Only check the name and not the cause, because in HTTP mode, the stacks are merged and the cause removed: + .hasMessageContaining("SupervisorNotFoundException"); } @Test diff --git a/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/application/installer/ApplicationInstallerUpdateIT.java b/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/application/installer/ApplicationInstallerUpdateIT.java index 770cba2e38e..504b43e1d2e 100644 --- a/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/application/installer/ApplicationInstallerUpdateIT.java +++ b/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/application/installer/ApplicationInstallerUpdateIT.java @@ -171,7 +171,7 @@ public void process_update_custom_application_with_same_installed_version() thro assertThat(updatedApplication.getLastUpdateDate().after(application.getLastUpdateDate())).isTrue(); assertThat( updatedProcessStarterAPI.getLastModificationDate().after(processStarterAPI.getLastModificationDate())) - .isTrue(); + .isTrue(); assertThat(updatedHealthPage.getLastModificationDate().after(healthPage.getLastModificationDate())).isTrue(); assertThat(updatedPmLayout.getLastModificationDate().after(pmLayout.getLastModificationDate())).isTrue(); @@ -224,7 +224,7 @@ public void process_update_custom_application_with_new_version() // check updated custom pages assertThat( updatedProcessStarterAPI.getLastModificationDate().after(processStarterAPI.getLastModificationDate())) - .isTrue(); + .isTrue(); assertThat(updatedProcessStarterAPI.getContentName()).isEqualTo("processStarter-1.1.zip"); assertThat(updatedHealthPage.getLastModificationDate().after(healthPage.getLastModificationDate())).isTrue(); assertThat(updatedHealthPage.getContentName()).isEqualTo("page_HealthPage.zip"); diff --git a/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/bpm/process/DeleteProcessInstancesIT.java b/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/bpm/process/DeleteProcessInstancesIT.java index ed03e448b15..0994e11451c 100644 --- a/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/bpm/process/DeleteProcessInstancesIT.java +++ b/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/bpm/process/DeleteProcessInstancesIT.java @@ -241,7 +241,7 @@ protected ProcessDefinition createSubProcessDefinition2() throws Exception { .addAutomaticTask("autoWithConnector") .addConnector("connector1", "myConnector", "1.0", ConnectorEvent.ON_ENTER) .addAutomaticTask("autoWithData").addShortTextData("activityData", s("activityDataValue")).getProcess()) - .done()); + .done()); } protected ProcessDefinition createSubProcessDefinitionWithUserTask(User user) throws Exception { diff --git a/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/business/data/BDRepositoryLocalIT.java b/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/business/data/BDRepositoryLocalIT.java index f8a696a9ea5..a27f85df23e 100644 --- a/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/business/data/BDRepositoryLocalIT.java +++ b/bonita-integration-tests/bonita-integration-tests-local/src/test/java/org/bonitasoft/engine/business/data/BDRepositoryLocalIT.java @@ -496,7 +496,7 @@ public void deploy_a_BDR_and_verify_sequence_behaviour_by_DBVendor() throws Exce case "oracle": assertThat(((List) execute_native_sql( "SELECT COUNT(*) FROM user_sequences WHERE sequence_name = 'HIBERNATE_SEQUENCE'")).get(0) - .intValue()).isEqualTo(1); + .intValue()).isEqualTo(1); break; case "mysql": assertThat(Arrays.toString((Object[]) execute_native_sql("describe EMPLOYEE").get(0))) diff --git a/bonita-integration-tests/bonita-integration-tests-web/src/test/java/org/bonitasoft/web/rest/server/api/organization/APIUserAnotherIT.java b/bonita-integration-tests/bonita-integration-tests-web/src/test/java/org/bonitasoft/web/rest/server/api/organization/APIUserAnotherIT.java index d9bd05ae80a..60ee595f9e9 100644 --- a/bonita-integration-tests/bonita-integration-tests-web/src/test/java/org/bonitasoft/web/rest/server/api/organization/APIUserAnotherIT.java +++ b/bonita-integration-tests/bonita-integration-tests-web/src/test/java/org/bonitasoft/web/rest/server/api/organization/APIUserAnotherIT.java @@ -246,11 +246,11 @@ public UserCreator buildEngineUser(final UserItem user) throws NumberFormatExcep final UserCreator userCreator = new UserCreator(user.getAttributeValue(UserItem.ATTRIBUTE_USERNAME), user.getAttributeValue(UserItem.ATTRIBUTE_PASSWORD)) - .setFirstName(user.getAttributeValue(UserItem.ATTRIBUTE_FIRSTNAME)) - .setLastName(user.getAttributeValue(UserItem.ATTRIBUTE_LASTNAME)) - .setTitle(user.getAttributeValue(UserItem.ATTRIBUTE_TITLE)) - .setIconPath(user.getAttributeValue(UserItem.ATTRIBUTE_ICON)) - .setJobTitle(user.getAttributeValue(UserItem.ATTRIBUTE_JOB_TITLE)); + .setFirstName(user.getAttributeValue(UserItem.ATTRIBUTE_FIRSTNAME)) + .setLastName(user.getAttributeValue(UserItem.ATTRIBUTE_LASTNAME)) + .setTitle(user.getAttributeValue(UserItem.ATTRIBUTE_TITLE)) + .setIconPath(user.getAttributeValue(UserItem.ATTRIBUTE_ICON)) + .setJobTitle(user.getAttributeValue(UserItem.ATTRIBUTE_JOB_TITLE)); // .setPersonalData(personalInfo.done()) // .setProfessionalData(professionalInfo.done()); diff --git a/bonita-integration-tests/bonita-query-tests/src/test/java/org/bonitasoft/engine/core/process/instance/model/FlowNodeInstanceTest.java b/bonita-integration-tests/bonita-query-tests/src/test/java/org/bonitasoft/engine/core/process/instance/model/FlowNodeInstanceTest.java index b8dd07cb63d..f9b99ddccee 100755 --- a/bonita-integration-tests/bonita-query-tests/src/test/java/org/bonitasoft/engine/core/process/instance/model/FlowNodeInstanceTest.java +++ b/bonita-integration-tests/bonita-query-tests/src/test/java/org/bonitasoft/engine/core/process/instance/model/FlowNodeInstanceTest.java @@ -158,8 +158,8 @@ public void getFlowNodeInstanceIdsToRecover_should_return_ids_of_flow_nodes_that .get(SFlowNodeInstance.class, new PersistentObjectId(id, PersistentObjectBuilder.DEFAULT_TENANT_ID)) .getName())) - .containsOnly("executingTask", "notStableTask", "terminalTask", - "abortingBoundary", "cancellingBoundary"); + .containsOnly("executingTask", "notStableTask", "terminalTask", + "abortingBoundary", "cancellingBoundary"); } @Test @@ -189,11 +189,11 @@ public void getGatewayInstanceIdsToRecover_should_return_ids_of_gateways_flagged assertThat(nodeToRestart.stream() .map(id -> (repository.getSession().get(SFlowNodeInstance.class, new PersistentObjectId(id, PersistentObjectBuilder.DEFAULT_TENANT_ID))).getName())) - .containsOnly( - "gateway_initializing_but_finished", - "gateway_completed", - "gateway_aborting", - "gateway_cancelling"); + .containsOnly( + "gateway_initializing_but_finished", + "gateway_completed", + "gateway_aborting", + "gateway_cancelling"); } @Test @@ -218,9 +218,9 @@ public void getGatewayInstanceIdsToRecover_should_return_ids_of_gateways_flagged assertThat(nodeToRestart.stream() .map(id -> (repository.getSession().get(SFlowNodeInstance.class, new PersistentObjectId(id, PersistentObjectBuilder.DEFAULT_TENANT_ID))).getName())) - .containsOnly( - "gateway_completed", - "gateway_aborting"); + .containsOnly( + "gateway_completed", + "gateway_aborting"); } @Test diff --git a/bonita-integration-tests/bonita-query-tests/src/test/java/org/bonitasoft/engine/resources/TenantResourceServiceQueriesTest.java b/bonita-integration-tests/bonita-query-tests/src/test/java/org/bonitasoft/engine/resources/TenantResourceServiceQueriesTest.java index 94705288b9c..1bdbb513244 100644 --- a/bonita-integration-tests/bonita-query-tests/src/test/java/org/bonitasoft/engine/resources/TenantResourceServiceQueriesTest.java +++ b/bonita-integration-tests/bonita-query-tests/src/test/java/org/bonitasoft/engine/resources/TenantResourceServiceQueriesTest.java @@ -56,7 +56,7 @@ public void getTenantResource_should_get_one_resource() { String.class)).isEqualTo("INSTALLED"); assertThat( jdbcTemplate.queryForObject("select type from tenant_resource where name = 'MyResource'", String.class)) - .isEqualTo("BDM"); + .isEqualTo("BDM"); //when STenantResource myResource = repository.getTenantResource(TenantResourceType.BDM, "MyResource"); diff --git a/bpm/bonita-api/bonita-server-api-http/src/test/java/org/bonitasoft/engine/api/internal/servlet/HttpAPIServletCallTest.java b/bpm/bonita-api/bonita-server-api-http/src/test/java/org/bonitasoft/engine/api/internal/servlet/HttpAPIServletCallTest.java index 21222202a27..02a01a5a452 100644 --- a/bpm/bonita-api/bonita-server-api-http/src/test/java/org/bonitasoft/engine/api/internal/servlet/HttpAPIServletCallTest.java +++ b/bpm/bonita-api/bonita-server-api-http/src/test/java/org/bonitasoft/engine/api/internal/servlet/HttpAPIServletCallTest.java @@ -72,7 +72,7 @@ public void should_manage_login_request() throws Exception { when(serverAPI.invokeMethod(new HashMap<>(), "com.bonitasoft.engine.api.LoginAPI", "login", asList(String.class.getName(), String.class.getName()) // , new Object[] { "install", "install" })) // - .thenReturn(apiSession); + .thenReturn(apiSession); //when: httpAPIServletCall.doPost(); diff --git a/bpm/bonita-client/src/test/java/org/bonitasoft/engine/bar/BusinessArchiveTest.java b/bpm/bonita-client/src/test/java/org/bonitasoft/engine/bar/BusinessArchiveTest.java index b826282e506..25f149b4df5 100644 --- a/bpm/bonita-client/src/test/java/org/bonitasoft/engine/bar/BusinessArchiveTest.java +++ b/bpm/bonita-client/src/test/java/org/bonitasoft/engine/bar/BusinessArchiveTest.java @@ -580,7 +580,7 @@ public void readProcessFromBusinessArchive() throws Exception { assertThat(result.getProcessContainer().getFlowNode("start1").getOutgoingTransitions().get(0).getCondition() .getContent()) - .as("the condition on the transition was not kept").isEqualTo("true"); + .as("the condition on the transition was not kept").isEqualTo("true"); assertEquals(process.getFlowElementContainer().getConnectors().size(), result.getFlowElementContainer().getConnectors().size()); diff --git a/bpm/bonita-common/src/main/java/org/bonitasoft/engine/api/DocumentAPI.java b/bpm/bonita-common/src/main/java/org/bonitasoft/engine/api/DocumentAPI.java index 483e0df1e0b..d7189618949 100644 --- a/bpm/bonita-common/src/main/java/org/bonitasoft/engine/api/DocumentAPI.java +++ b/bpm/bonita-common/src/main/java/org/bonitasoft/engine/api/DocumentAPI.java @@ -430,12 +430,15 @@ SearchResult searchDocumentsSupervisedBy(long userId, SearchOptions se * * 
      * {@code
-     *   public List retrieveDocuments(DocumentAPI documentAPI, ArchivedProcessInstance archivedProcessInstance) {
-     *       SearchOptions searchOptions = new SearchOptionsBuilder(0, Integer.MAX_VALUE)
-     *               .filter(ArchivedDocumentsSearchDescriptor.PROCESSINSTANCE_ID, archivedProcessInstance.getSourceObjectId())
-     *               .done();
-     *       return documentAPI.searchArchivedDocuments(searchOptions).getResult();
-     *   }
+     *
+     * public List retrieveDocuments(DocumentAPI documentAPI,
+     *         ArchivedProcessInstance archivedProcessInstance) {
+     *     SearchOptions searchOptions = new SearchOptionsBuilder(0, Integer.MAX_VALUE)
+     *             .filter(ArchivedDocumentsSearchDescriptor.PROCESSINSTANCE_ID,
+     *                     archivedProcessInstance.getSourceObjectId())
+     *             .done();
+     *     return documentAPI.searchArchivedDocuments(searchOptions).getResult();
+     * }
      * }
      *
* diff --git a/bpm/bonita-common/src/main/java/org/bonitasoft/engine/api/ProcessRuntimeAPI.java b/bpm/bonita-common/src/main/java/org/bonitasoft/engine/api/ProcessRuntimeAPI.java index dc30f8dc803..a07bb7a8344 100644 --- a/bpm/bonita-common/src/main/java/org/bonitasoft/engine/api/ProcessRuntimeAPI.java +++ b/bpm/bonita-common/src/main/java/org/bonitasoft/engine/api/ProcessRuntimeAPI.java @@ -2207,12 +2207,15 @@ long getProcessDefinitionIdFromActivityInstanceId(long activityInstanceId) * * 
      * {@code
-     *  public List retrieveComments(ProcessRuntimeAPI processRuntimeAPI, ArchivedProcessInstance archivedProcessInstance) {
-     *      SearchOptions searchOptions = new SearchOptionsBuilder(0, Integer.MAX_VALUE)
-     *          .filter(ArchivedCommentsSearchDescriptor.PROCESS_INSTANCE_ID, archivedProcessInstance.getSourceObjectId())
-     *          .done();
-     *      return processRuntimeAPI.searchArchivedComments(searchOptions).getResult();
-     *  }
+     *
+     * public List retrieveComments(ProcessRuntimeAPI processRuntimeAPI,
+     *         ArchivedProcessInstance archivedProcessInstance) {
+     *     SearchOptions searchOptions = new SearchOptionsBuilder(0, Integer.MAX_VALUE)
+     *             .filter(ArchivedCommentsSearchDescriptor.PROCESS_INSTANCE_ID,
+     *                     archivedProcessInstance.getSourceObjectId())
+     *             .done();
+     *     return processRuntimeAPI.searchArchivedComments(searchOptions).getResult();
+     * }
      * }
      *
* diff --git a/bpm/bonita-common/src/test/java/org/bonitasoft/engine/page/impl/PageImplTest.java b/bpm/bonita-common/src/test/java/org/bonitasoft/engine/page/impl/PageImplTest.java index 1abbebba218..019c7e68f0c 100644 --- a/bpm/bonita-common/src/test/java/org/bonitasoft/engine/page/impl/PageImplTest.java +++ b/bpm/bonita-common/src/test/java/org/bonitasoft/engine/page/impl/PageImplTest.java @@ -98,8 +98,8 @@ public void should_display_all_fields_in_to_string() { date.getTime(), USER_ID, modificationDate.getTime(), USER_ID, "content.zip", ContentType.FORM, PROCESS_DEFINITION_ID).toString()) - .contains(String.valueOf(PROCESS_DEFINITION_ID)).contains( - ContentType.FORM); + .contains(String.valueOf(PROCESS_DEFINITION_ID)).contains( + ContentType.FORM); } } diff --git a/bpm/bonita-core/bonita-home-server/src/test/java/org/bonitasoft/engine/home/BonitaHomeServerTest.java b/bpm/bonita-core/bonita-home-server/src/test/java/org/bonitasoft/engine/home/BonitaHomeServerTest.java index 821489846d9..2bef0cac154 100644 --- a/bpm/bonita-core/bonita-home-server/src/test/java/org/bonitasoft/engine/home/BonitaHomeServerTest.java +++ b/bpm/bonita-core/bonita-home-server/src/test/java/org/bonitasoft/engine/home/BonitaHomeServerTest.java @@ -137,11 +137,11 @@ public void tenant_properties_should_inherit_from_platform_properties() throws E doReturn(Collections.singletonList(new BonitaConfiguration("platform.properties", getPropertiesAsByteArray("prop2=prop2PlatformDB", "prop3=prop3PlatformDB", "prop4=prop4PlatformDB")))) - .when(configurationService).getPlatformEngineConf(); + .when(configurationService).getPlatformEngineConf(); doReturn(Collections.singletonList(new BonitaConfiguration("tenant.properties", getPropertiesAsByteArray("prop4=prop4TenantDB")))) - .when(configurationService).getTenantEngineConf(1); + .when(configurationService).getTenantEngineConf(1); //when Properties allProperties = bonitaHomeServer.getTenantProperties(1); //then diff --git a/bpm/bonita-core/bonita-process-definition/src/test/java/org/bonitasoft/engine/core/process/definition/ProcessDefinitionServiceImplTest.java b/bpm/bonita-core/bonita-process-definition/src/test/java/org/bonitasoft/engine/core/process/definition/ProcessDefinitionServiceImplTest.java index 7079f08b0d6..eb3e1e40c12 100644 --- a/bpm/bonita-core/bonita-process-definition/src/test/java/org/bonitasoft/engine/core/process/definition/ProcessDefinitionServiceImplTest.java +++ b/bpm/bonita-core/bonita-process-definition/src/test/java/org/bonitasoft/engine/core/process/definition/ProcessDefinitionServiceImplTest.java @@ -557,7 +557,7 @@ public void searchProcessDeploymentInfosStartedBy() throws Exception { final long startedBy = 9; when(persistenceService.searchEntity(SProcessDefinitionDeployInfo.class, "StartedBy", options, Collections.singletonMap("startedBy", (Object) startedBy))) - .thenReturn(new ArrayList()); + .thenReturn(new ArrayList()); // When final List result = processDefinitionServiceImpl @@ -683,7 +683,7 @@ public void searchProcessDeploymentInfosCanBeStartedBy() throws Exception { final long userId = 9; when(persistenceService.searchEntity(SProcessDefinitionDeployInfo.class, "UserCanStart", options, Collections.singletonMap("userId", (Object) userId))) - .thenReturn(new ArrayList()); + .thenReturn(new ArrayList()); // When final List result = processDefinitionServiceImpl @@ -750,7 +750,7 @@ public void searchProcessDeploymentInfosCanStartForUsersManagedBy() throws Excep final long userId = 9; when(persistenceService.searchEntity(SProcessDefinitionDeployInfo.class, "UsersManagedByCanStart", options, Collections.singletonMap("managerUserId", (Object) userId))) - .thenReturn(new ArrayList()); + .thenReturn(new ArrayList()); // When final List result = processDefinitionServiceImpl @@ -820,7 +820,7 @@ public void searchProcessDeploymentInfosWithParameters() throws Exception { final String querySuffix = "suffix"; when(persistenceService.searchEntity(SProcessDefinitionDeployInfo.class, querySuffix, options, Collections.singletonMap("userId", (Object) userId))) - .thenReturn(new ArrayList()); + .thenReturn(new ArrayList()); // When final List result = processDefinitionServiceImpl @@ -953,7 +953,7 @@ public void searchUncategorizedProcessDeploymentInfosSupervisedBy() throws Excep when(persistenceService.searchEntity(SProcessDefinitionDeployInfo.class, "UncategorizedAndWithSupervisor", options, Collections.singletonMap("userId", (Object) userId))) - .thenReturn(new ArrayList()); + .thenReturn(new ArrayList()); // When final List result = processDefinitionServiceImpl @@ -1023,7 +1023,7 @@ public void searchUncategorizedProcessDeploymentInfosCanBeStartedBy() throws Exc final long userId = 9; when(persistenceService.searchEntity(SProcessDefinitionDeployInfo.class, "UncategorizedUserCanStart", options, Collections.singletonMap("userId", (Object) userId))) - .thenReturn(new ArrayList()); + .thenReturn(new ArrayList()); // When final List result = processDefinitionServiceImpl @@ -1414,7 +1414,7 @@ public void searchUsersWhoCanStartProcessDeploymentInfo() throws Exception { final long processDefinitionId = 9; when(persistenceService.searchEntity(SUser.class, "WhoCanStartProcess", options, Collections.singletonMap("processId", (Object) processDefinitionId))) - .thenReturn(new ArrayList()); + .thenReturn(new ArrayList()); // When final List result = processDefinitionServiceImpl @@ -1431,7 +1431,7 @@ public void searchUsersWhoCanStartProcessDeploymentInfoThrowException() throws E final long processDefinitionId = 9; when(persistenceService.searchEntity(SUser.class, "WhoCanStartProcess", options, Collections.singletonMap("processId", (Object) processDefinitionId))) - .thenThrow(new SBonitaReadException("")); + .thenThrow(new SBonitaReadException("")); // When processDefinitionServiceImpl.searchUsersWhoCanStartProcessDeploymentInfo(processDefinitionId, options); @@ -1465,7 +1465,7 @@ public void getNumberOfUsersWhoCanStartProcessDeploymentInfoThrowException() thr final long processDefinitionId = 9; when(persistenceService.getNumberOfEntities(SUser.class, "WhoCanStartProcess", options, Collections.singletonMap("processId", (Object) processDefinitionId))) - .thenThrow(new SBonitaReadException("")); + .thenThrow(new SBonitaReadException("")); // When processDefinitionServiceImpl.getNumberOfUsersWhoCanStartProcessDeploymentInfo(processDefinitionId, options); @@ -1484,7 +1484,7 @@ public void searchProcessDeploymentInfosWithAssignedOrPendingHumanTasksFor() thr when(persistenceService.searchEntity(SProcessDefinitionDeployInfo.class, "WithAssignedOrPendingHumanTasksFor", options, Collections.singletonMap("userId", (Object) userId))) - .thenReturn(new ArrayList()); + .thenReturn(new ArrayList()); // When final List result = processDefinitionServiceImpl @@ -1558,7 +1558,7 @@ public void searchProcessDeploymentInfosWithAssignedOrPendingHumanTasksSupervise when(persistenceService.searchEntity(SProcessDefinitionDeployInfo.class, "WithAssignedOrPendingHumanTasksSupervisedBy", options, Collections.singletonMap("userId", (Object) userId))) - .thenReturn(new ArrayList()); + .thenReturn(new ArrayList()); // When final List result = processDefinitionServiceImpl diff --git a/bpm/bonita-core/bonita-process-engine/src/main/groovy/org/bonitasoft/permissions/CaseContextPermissionRule.groovy b/bpm/bonita-core/bonita-process-engine/src/main/groovy/org/bonitasoft/permissions/CaseContextPermissionRule.groovy index 36811d8c684..48338826bd8 100644 --- a/bpm/bonita-core/bonita-process-engine/src/main/groovy/org/bonitasoft/permissions/CaseContextPermissionRule.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/main/groovy/org/bonitasoft/permissions/CaseContextPermissionRule.groovy @@ -73,5 +73,4 @@ class CaseContextPermissionRule implements PermissionRule { } return Long.valueOf(compoundResourceId.get(0)) } - } diff --git a/bpm/bonita-core/bonita-process-engine/src/main/java/org/bonitasoft/engine/api/impl/resolver/FormMappingAndPageArtifactManager.java b/bpm/bonita-core/bonita-process-engine/src/main/java/org/bonitasoft/engine/api/impl/resolver/FormMappingAndPageArtifactManager.java index c18bf868d46..3eba415b274 100644 --- a/bpm/bonita-core/bonita-process-engine/src/main/java/org/bonitasoft/engine/api/impl/resolver/FormMappingAndPageArtifactManager.java +++ b/bpm/bonita-core/bonita-process-engine/src/main/java/org/bonitasoft/engine/api/impl/resolver/FormMappingAndPageArtifactManager.java @@ -123,8 +123,8 @@ private void deployPage(String resourcePath, byte[] pageContent, Long processDef final Properties pageProperties = pageService.readPageZip(pageContent); final PageCreator pageCreator = new PageCreator(pageName, contentName, ContentType.FORM, processDefinitionId) - .setDisplayName(pageProperties.getProperty(PageService.PROPERTIES_DISPLAY_NAME)) - .setDescription(pageProperties.getProperty(PageService.PROPERTIES_DESCRIPTION)); + .setDisplayName(pageProperties.getProperty(PageService.PROPERTIES_DISPLAY_NAME)) + .setDescription(pageProperties.getProperty(PageService.PROPERTIES_DESCRIPTION)); final SPage newPage = new PageModelConverter().constructSPage(pageCreator, userId); pageService.addPage(newPage, pageContent); } diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ActorMemberPermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ActorMemberPermissionRuleTest.groovy index 72da976aed1..90188f1f85e 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ActorMemberPermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ActorMemberPermissionRuleTest.groovy @@ -115,7 +115,6 @@ public class ActorMemberPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test @@ -144,6 +143,5 @@ public class ActorMemberPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isFalse() - } } diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ActorPermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ActorPermissionRuleTest.groovy index 8e39b3932b4..badcca133cc 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ActorPermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ActorPermissionRuleTest.groovy @@ -71,7 +71,6 @@ public class ActorPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test @@ -102,7 +101,6 @@ public class ActorPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CasePermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CasePermissionRuleTest.groovy index 56b2c502002..1d3cfe9497f 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CasePermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CasePermissionRuleTest.groovy @@ -289,7 +289,6 @@ public class CasePermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then Assertions.assertThat(isAuthorized).isTrue() - } @Test @@ -324,6 +323,5 @@ public class CasePermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then Assertions.assertThat(isAuthorized).isTrue() - } } diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CaseVariablePermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CaseVariablePermissionRuleTest.groovy index fd3736a644f..a8f39cb7141 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CaseVariablePermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CaseVariablePermissionRuleTest.groovy @@ -79,7 +79,6 @@ class CaseVariablePermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isFalse() - } @Test @@ -92,7 +91,6 @@ class CaseVariablePermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test @@ -105,7 +103,6 @@ class CaseVariablePermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isFalse() - } @Test @@ -118,7 +115,6 @@ class CaseVariablePermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test @@ -129,7 +125,6 @@ class CaseVariablePermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test @@ -140,6 +135,5 @@ class CaseVariablePermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isFalse() - } } diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CommentPermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CommentPermissionRuleTest.groovy index e4d0f3216ae..f271f773a7a 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CommentPermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/CommentPermissionRuleTest.groovy @@ -198,7 +198,6 @@ public class CommentPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then Assertions.assertThat(isAuthorized).isTrue() - } @Test @@ -258,6 +257,5 @@ public class CommentPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then Assertions.assertThat(isAuthorized).isTrue() - } } diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/DocumentPermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/DocumentPermissionRuleTest.groovy index ccab1fe4e8e..7bc43735ca0 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/DocumentPermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/DocumentPermissionRuleTest.groovy @@ -196,7 +196,6 @@ public class DocumentPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test @@ -236,6 +235,5 @@ public class DocumentPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } } diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessConfigurationPermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessConfigurationPermissionRuleTest.groovy index d3cd25199b4..ed676f6574d 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessConfigurationPermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessConfigurationPermissionRuleTest.groovy @@ -68,7 +68,6 @@ public class ProcessConfigurationPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test @@ -97,7 +96,6 @@ public class ProcessConfigurationPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessConnectorDependencyPermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessConnectorDependencyPermissionRuleTest.groovy index e7602358e49..23c856692d2 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessConnectorDependencyPermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessConnectorDependencyPermissionRuleTest.groovy @@ -68,7 +68,6 @@ public class ProcessConnectorDependencyPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessInstantiationPermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessInstantiationPermissionRuleTest.groovy index 68d3e1e5b24..172441a2b58 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessInstantiationPermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessInstantiationPermissionRuleTest.groovy @@ -92,7 +92,6 @@ public class ProcessInstantiationPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then Assertions.assertThat(isAuthorized).isTrue() - } @Test @@ -131,7 +130,6 @@ public class ProcessInstantiationPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then Assertions.assertThat(isAuthorized).isTrue() - } @Test diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessResolutionProblemPermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessResolutionProblemPermissionRuleTest.groovy index 536b6312a93..40cb026eb5f 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessResolutionProblemPermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessResolutionProblemPermissionRuleTest.groovy @@ -68,7 +68,6 @@ public class ProcessResolutionProblemPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test diff --git a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessSupervisorPermissionRuleTest.groovy b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessSupervisorPermissionRuleTest.groovy index f06d5e45b9d..db6b28317ac 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessSupervisorPermissionRuleTest.groovy +++ b/bpm/bonita-core/bonita-process-engine/src/test/groovy/org/bonitasoft/permissions/ProcessSupervisorPermissionRuleTest.groovy @@ -104,7 +104,6 @@ public class ProcessSupervisorPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } @Test @@ -132,7 +131,6 @@ public class ProcessSupervisorPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isFalse() - } @Test @@ -145,6 +143,5 @@ public class ProcessSupervisorPermissionRuleTest { def isAuthorized = rule.isAllowed(apiSession, apiCallContext, apiAccessor, logger) //then assertThat(isAuthorized).isTrue() - } } diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/ProcessAPIImplTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/ProcessAPIImplTest.java index 7efe06ed7df..6ca9a1a1a60 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/ProcessAPIImplTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/ProcessAPIImplTest.java @@ -579,7 +579,7 @@ public void getActivityTransientDataInstances() throws Exception { final List sDataInstances = singletonList(sDataInstance); when(transientDataService.getDataInstances(FLOW_NODE_INSTANCE_ID, DataInstanceContainer.ACTIVITY_INSTANCE.name(), startIndex, nbResults)) - .thenReturn(sDataInstances); + .thenReturn(sDataInstances); final IntegerDataInstanceImpl dataInstance = mock(IntegerDataInstanceImpl.class); doReturn(singletonList(dataInstance)).when(processAPI).convertModelToDataInstances(sDataInstances); @@ -1567,8 +1567,8 @@ public void failFirstTx() { public void should_get_external_resources_from_process() throws Exception { doReturn( new SBARResource("myResource", BARResourceType.EXTERNAL, PROCESS_DEFINITION_ID, new byte[] { 1, 2, 3 })) - .when(processResourcesService) - .get(PROCESS_DEFINITION_ID, BARResourceType.EXTERNAL, "myResource"); + .when(processResourcesService) + .get(PROCESS_DEFINITION_ID, BARResourceType.EXTERNAL, "myResource"); byte[] myResource = processAPI.getExternalProcessResource(PROCESS_DEFINITION_ID, "myResource"); @@ -1653,7 +1653,7 @@ public void should_disconnect_connector_execution_when_output_operation_throw_an // When assertThatThrownBy(() -> processAPI.executeOperations(connectorResult, new ArrayList<>(), new HashMap<>(), new SExpressionContext(), ProcessAPIImplTest.class.getClassLoader(), serviceAccessor)) - .isInstanceOf(SOperationExecutionException.class); + .isInstanceOf(SOperationExecutionException.class); // Then verify(connectorService).disconnect(connectorResult); diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/ServerAPIImplTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/ServerAPIImplTest.java index 1695d6c4aa4..49bf9f40bc2 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/ServerAPIImplTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/ServerAPIImplTest.java @@ -132,7 +132,7 @@ public void createServerAPI() throws Exception { doReturn(true).when(platformLoginService).isValid(PLATFORM_SESSION_ID); doAnswer(invocation -> (isMaintenanceEnabled ? MaintenanceDetails.State.ENABLED : MaintenanceDetails.State.DISABLED)) - .when(maintenanceDetails).getMaintenanceState(); + .when(maintenanceDetails).getMaintenanceState(); doAnswer(invocation -> maintenanceDetails).when(maintenanceAPI).getMaintenanceDetails(); accessResolver = new APIAccessResolver() { diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/application/installer/ApplicationInstallerUpdateTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/application/installer/ApplicationInstallerUpdateTest.java index 7731fafa487..6a866b66a4c 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/application/installer/ApplicationInstallerUpdateTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/application/installer/ApplicationInstallerUpdateTest.java @@ -130,7 +130,8 @@ public void should_update_application_containing_all_kind_of_custom_pages() thro assertThat( captor.getAllValues().stream().allMatch(file -> Stream.of("page", "layout", "theme", "restApiExtension") - .anyMatch(name -> file.getName().startsWith(name)))).isTrue(); + .anyMatch(name -> file.getName().startsWith(name)))) + .isTrue(); } @Test @@ -344,7 +345,7 @@ private byte[] createValidBusinessArchive() private byte[] createValidBDMZipFile() throws IOException { return zip(file("bom.xml", ("\n" + "") - .getBytes())); + .getBytes())); } } diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/connector/ResetAllFailedConnectorStrategyTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/connector/ResetAllFailedConnectorStrategyTest.java index e3d3a4a4386..fca9f1fd3d7 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/connector/ResetAllFailedConnectorStrategyTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/connector/ResetAllFailedConnectorStrategyTest.java @@ -58,11 +58,13 @@ public void resetConnectorsOf_should_put_all_failed_connectors_in_the_state_TO_R given( connectorInstanceService.getConnectorInstancesWithFailureInfo(20L, SConnectorInstance.FLOWNODE_TYPE, ConnectorState.FAILED.name(), 0, - MAX_RESULTS)).willReturn(Arrays.asList(instance1, instance2)); + MAX_RESULTS)) + .willReturn(Arrays.asList(instance1, instance2)); given( connectorInstanceService.getConnectorInstancesWithFailureInfo(20L, SConnectorInstance.FLOWNODE_TYPE, ConnectorState.FAILED.name(), MAX_RESULTS, - MAX_RESULTS)).willReturn(Arrays.asList(instance3)); + MAX_RESULTS)) + .willReturn(Arrays.asList(instance3)); //when strategy.resetConnectorsOf(20L); @@ -80,7 +82,8 @@ public void resetConnectorsOf_should_throw_ActivityExecution_Exception_when_conn given( connectorInstanceService.getConnectorInstancesWithFailureInfo(20L, SConnectorInstance.FLOWNODE_TYPE, ConnectorState.FAILED.name(), 0, - MAX_RESULTS)).willThrow(new SConnectorInstanceReadException(new Exception())); + MAX_RESULTS)) + .willThrow(new SConnectorInstanceReadException(new Exception())); //when strategy.resetConnectorsOf(20L); diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/converter/ApplicationModelConverterTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/converter/ApplicationModelConverterTest.java index cd17252d138..a1dde51274b 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/converter/ApplicationModelConverterTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/converter/ApplicationModelConverterTest.java @@ -323,7 +323,7 @@ public void toApplicationUpdateDescriptor_should_fail_to_update_icon_filename_wh assertThatThrownBy(() -> converter.toApplicationUpdateDescriptor(updater, LOGGED_USER_ID)).isInstanceOf(IllegalArgumentException.class) - .hasMessageContaining("An icon can't have mimetype"); + .hasMessageContaining("An icon can't have mimetype"); } @Test diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/resolver/DocumentInitialValueArtifactManagerTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/resolver/DocumentInitialValueArtifactManagerTest.java index 1c3aed63b18..34b2320bc13 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/resolver/DocumentInitialValueArtifactManagerTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/resolver/DocumentInitialValueArtifactManagerTest.java @@ -72,9 +72,9 @@ public void exportBusinessArchive_should_export_only_initial_documents() throws doReturn(getBarResources()).when(processResourcesService).get(PROCESS_ID, BARResourceType.DOCUMENT, 0, 10); doReturn(Collections .singletonList(new SBARResource("10.pdf", BARResourceType.DOCUMENT, PROCESS_ID, new byte[] { 10 }))) - .when( - processResourcesService) - .get(PROCESS_ID, BARResourceType.DOCUMENT, 10, 10); + .when( + processResourcesService) + .get(PROCESS_ID, BARResourceType.DOCUMENT, 10, 10); documentInitialValueDependencyManager.exportToBusinessArchive(PROCESS_ID, businessArchiveBuilder); diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/resolver/FormMappingAndPageArtifactManagerTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/resolver/FormMappingAndPageArtifactManagerTest.java index 2aa6d9fb2dc..2be23c19b9a 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/resolver/FormMappingAndPageArtifactManagerTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/api/impl/resolver/FormMappingAndPageArtifactManagerTest.java @@ -524,7 +524,7 @@ public void should_export_form_mapping_with_existing_page() throws Exception { "task1"), withFormMapping("myPage4", PROCESS_DEFINITION_ID, FormMappingType.TASK, FormMappingTarget.INTERNAL, "task2"))) - .when(formMappingService).list(PROCESS_DEFINITION_ID, 0, Integer.MAX_VALUE); + .when(formMappingService).list(PROCESS_DEFINITION_ID, 0, Integer.MAX_VALUE); //when formMappingAndPageArtifactManager.exportToBusinessArchive(PROCESS_DEFINITION_ID, businessArchiveBuilder); //then @@ -548,7 +548,7 @@ public void should_export_form_mapping_with_unexisting_page() throws Exception { .addUserTask("task1", "actor").addUserTask("task2", "actor").getProcess()); doReturn(Collections.singletonList(withFormMapping(null, PROCESS_DEFINITION_ID, FormMappingType.TASK, FormMappingTarget.INTERNAL, "task2"))) - .when(formMappingService).list(PROCESS_DEFINITION_ID, 0, Integer.MAX_VALUE); + .when(formMappingService).list(PROCESS_DEFINITION_ID, 0, Integer.MAX_VALUE); //when formMappingAndPageArtifactManager.exportToBusinessArchive(PROCESS_DEFINITION_ID, businessArchiveBuilder); //then diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/business/application/importer/ApplicationImporterTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/business/application/importer/ApplicationImporterTest.java index f04ae361732..0ece49598d2 100755 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/business/application/importer/ApplicationImporterTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/business/application/importer/ApplicationImporterTest.java @@ -106,7 +106,7 @@ public void importApplication_should_create_application_import_pages_and_menus_a given(nodeToApplicationConverter.toSApplication(applicationNode, ICON_CONTENT, ICON_MIME_TYPE, createdBy, editable)) - .willReturn(importResult); + .willReturn(importResult); long homePageId = 222L; SApplicationPage applicationPage = new SApplicationPage(app.getId(), homePageId, "home"); @@ -174,7 +174,7 @@ public void importApplication_should_not_create_application_when_no_application_ given(nodeToApplicationConverter.toSApplication(applicationNode, ICON_CONTENT, ICON_MIME_TYPE, createdBy, editable)) - .willReturn(importResult); + .willReturn(importResult); long homePageId = 222L; @@ -220,7 +220,7 @@ public void importApplication_should_not_add_error_when_error_already_exists() t applicationNode.addApplicationPage(pageNode1); given(nodeToApplicationConverter.toSApplication(applicationNode, ICON_CONTENT, ICON_MIME_TYPE, createdBy, editable)) - .willReturn(importResult); + .willReturn(importResult); given(applicationService.createApplication(app)).willReturn(app); @@ -250,7 +250,7 @@ public void importApplication_should_not_set_home_page_when_applicationNode_does applicationNode.setToken("app"); given(nodeToApplicationConverter.toSApplication(applicationNode, ICON_CONTENT, ICON_MIME_TYPE, createdBy, editable)) - .willReturn(importResult); + .willReturn(importResult); given(applicationService.createApplication(app)).willReturn(app); //when @@ -281,7 +281,7 @@ public void importApplication_should_add_error_when_home_page_is_not_found() thr given(nodeToApplicationConverter.toSApplication(applicationNode, ICON_CONTENT, ICON_MIME_TYPE, createdBy, editable)) - .willReturn(importResult); + .willReturn(importResult); given(applicationService.createApplication(app)).willReturn(app); given(applicationService.getApplicationPage("app", "home")).willThrow(new SObjectNotFoundException("")); @@ -313,7 +313,7 @@ public void importApplication_should_skip_when_strategy_return_skip() throws Exc ApplicationNode applicationNode = mock(ApplicationNode.class); given(nodeToApplicationConverter.toSApplication(applicationNode, ICON_CONTENT, ICON_MIME_TYPE, createdBy, editable)) - .willReturn(importResult); + .willReturn(importResult); given(applicationService.getApplicationByToken("application")).willReturn(appInConflict); given(strategy.whenApplicationExists(any(), any())).willReturn(ApplicationImportStrategy.ImportStrategy.SKIP); //when @@ -341,7 +341,7 @@ public void importApplication_replace_application_when_strategy_is_replace_dupli ApplicationNode applicationNode = mock(ApplicationNode.class); given(nodeToApplicationConverter.toSApplication(applicationNode, ICON_CONTENT, ICON_MIME_TYPE, createdBy, editable)) - .willReturn(importResult); + .willReturn(importResult); given(applicationService.getApplicationByToken("application")).willReturn(appInConflict); //when @@ -376,7 +376,7 @@ public void importApplication_should_throw_alreadyExistsException_when_strategy_ ApplicationNode applicationNode = mock(ApplicationNode.class); given(nodeToApplicationConverter.toSApplication(applicationNode, ICON_CONTENT, ICON_MIME_TYPE, createdBy, editable)) - .willReturn(importResult); + .willReturn(importResult); given(applicationService.getApplicationByToken("application")).willReturn(appInConflict); //when - then exception @@ -404,7 +404,7 @@ public void importApplication_should_throw_ExecutionException_when_application_s ApplicationNode applicationNode = mock(ApplicationNode.class); given(nodeToApplicationConverter.toSApplication(applicationNode, ICON_CONTENT, ICON_MIME_TYPE, createdBy, editable)) - .willReturn(importResult); + .willReturn(importResult); given(applicationService.createApplication(app1)).willThrow(new SObjectCreationException("")); diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/operation/BusinessDataLeftOperandHandlerTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/operation/BusinessDataLeftOperandHandlerTest.java index 4184f8f3509..e9e3d75cd1e 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/operation/BusinessDataLeftOperandHandlerTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/operation/BusinessDataLeftOperandHandlerTest.java @@ -161,7 +161,7 @@ public void deleteThrowsExceptionIfAnInternalExceptionOccurs() throws Exception given(refBusinessDataRetriever.getRefBusinessDataInstance( new BusinessDataContext(leftOperand.getName(), new Container(45, PROCESS_INSTANCE)))) - .willThrow(new SFlowNodeNotFoundException(45)); + .willThrow(new SFlowNodeNotFoundException(45)); //then expectedException.expect(SOperationExecutionException.class); diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/service/ModelConvertorTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/service/ModelConvertorTest.java index ccbb1cf123f..e9b713f525a 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/service/ModelConvertorTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/service/ModelConvertorTest.java @@ -699,7 +699,7 @@ void toArchivedFlownodeInstance_should_convert_reachStateDate_for_sendtask() { final SASendTaskInstance sendTaskInstance = new SASendTaskInstance(); assertThat( ModelConvertor.toArchivedFlowNodeInstance(sendTaskInstance, flowNodeStateManager).getReachedStateDate()) - .isNotNull(); + .isNotNull(); } @Test diff --git a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/tenant/restart/FlowNodesRecoverTest.java b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/tenant/restart/FlowNodesRecoverTest.java index 2b243eb97eb..5049f3a03e4 100644 --- a/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/tenant/restart/FlowNodesRecoverTest.java +++ b/bpm/bonita-core/bonita-process-engine/src/test/java/org/bonitasoft/engine/tenant/restart/FlowNodesRecoverTest.java @@ -195,7 +195,7 @@ public void should_fail_batch_if_one_register_work_fails() throws Exception { assertThatThrownBy(() -> flowNodesRecover.execute(recoveryMonitor, flowNodeIds(automaticTaskInstance1, automaticTaskInstance2))) - .isInstanceOf(SWorkRegisterException.class); + .isInstanceOf(SWorkRegisterException.class); } @Test diff --git a/bpm/bonita-core/bonita-process-instance/src/main/java/org/bonitasoft/engine/core/connector/impl/ConnectorServiceImpl.java b/bpm/bonita-core/bonita-process-instance/src/main/java/org/bonitasoft/engine/core/connector/impl/ConnectorServiceImpl.java index 7e87b81a4ee..0ba90d4f55d 100644 --- a/bpm/bonita-core/bonita-process-instance/src/main/java/org/bonitasoft/engine/core/connector/impl/ConnectorServiceImpl.java +++ b/bpm/bonita-core/bonita-process-instance/src/main/java/org/bonitasoft/engine/core/connector/impl/ConnectorServiceImpl.java @@ -262,7 +262,7 @@ public ConnectorResult executeMultipleEvaluation(final long processDefinitionId, throws SConnectorException { final String implementationClassName = getConnectorImplementationDescriptor(processDefinitionId, connectorDefinitionId, connectorDefinitionVersion) - .getImplementationClassName(); + .getImplementationClassName(); final Map inputParameters; try { inputParameters = evaluateInputParameters(connectorDefinitionId, connectorInputParameters, diff --git a/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/connector/impl/ConnectorInstanceServiceImplTest.java b/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/connector/impl/ConnectorInstanceServiceImplTest.java index 2beef47148c..ab45ba20bca 100755 --- a/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/connector/impl/ConnectorInstanceServiceImplTest.java +++ b/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/connector/impl/ConnectorInstanceServiceImplTest.java @@ -204,7 +204,7 @@ public void getConnectorInstanceWithFailureInfo_should_return_the_result_of_sele parameters, SConnectorInstanceWithFailureInfo.class, new QueryOptions(0, 100, SConnectorInstanceWithFailureInfo.class, "id", OrderByType.ASC)))) - .willReturn(connectors); + .willReturn(connectors); //when List retrievedConnectors = connectorInstanceServiceImpl diff --git a/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/connector/impl/ConnectorServiceImplTest.java b/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/connector/impl/ConnectorServiceImplTest.java index 03c0f495544..e5b639e1790 100644 --- a/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/connector/impl/ConnectorServiceImplTest.java +++ b/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/connector/impl/ConnectorServiceImplTest.java @@ -306,8 +306,8 @@ private void checkGetConnectorImplementationUsesCache(final int givenCacheSizeTo .singletonList(new SBARResource("HoogardenBeerConnector.impl", BARResourceType.CONNECTOR, processDefinition.getId(), connectorImplFile))) - .when(processResourcesService) - .get(eq(processDefinition.getId()), eq(BARResourceType.CONNECTOR), eq(0), anyInt()); + .when(processResourcesService) + .get(eq(processDefinition.getId()), eq(BARResourceType.CONNECTOR), eq(0), anyInt()); //setConnectorImplementation store to cache connectorService.setConnectorImplementation(processDefinition, connectorDefId, connectorDefVersion, zip1); @@ -422,8 +422,8 @@ public void should_setConnectorImplementation_replace_jar_even_if_jar_was_not_in doReturn(Collections.singletonList( new SBARResource("myConnector1.impl", BARResourceType.CONNECTOR, processDefinition.getId(), createConnectorImplFile("connectorId", "connectorVersion")))) - .when(processResourcesService) - .get(eq(processDefinition.getId()), eq(BARResourceType.CONNECTOR), anyInt(), anyInt()); + .when(processResourcesService) + .get(eq(processDefinition.getId()), eq(BARResourceType.CONNECTOR), anyInt(), anyInt()); doReturn(new SDependency("jar2.jar", "jar2.jar", new byte[] { 2 })).when(dependencyService) .getDependencyOfArtifact(processDefinition.getId(), ScopeType.PROCESS, "jar2.jar"); systemOutRule.clearLog(); @@ -502,8 +502,8 @@ private void havingConnector(SProcessDefinitionImpl processDefinition, String im doReturn(Collections.singletonList( new SBARResource(implName, BARResourceType.CONNECTOR, processDefinition.getId(), createConnectorImplFile(connectorId, connectorVersion, jars)))) - .when(processResourcesService) - .get(eq(processDefinition.getId()), eq(BARResourceType.CONNECTOR), anyInt(), anyInt()); + .when(processResourcesService) + .get(eq(processDefinition.getId()), eq(BARResourceType.CONNECTOR), anyInt(), anyInt()); for (BarResource jar : jars) { doReturn(new SDependency(jar.getName(), jar.getName(), jar.getContent())).when(dependencyService) .getDependencyOfArtifact(processDefinition.getId(), ScopeType.PROCESS, jar.getName()); @@ -530,8 +530,8 @@ private void havingConnectorWithWrongJarName(SProcessDefinitionImpl processDefin doReturn(Collections.singletonList( new SBARResource(implName, BARResourceType.CONNECTOR, processDefinition.getId(), createConnectorImplFile(connectorId, connectorVersion, jars)))) - .when(processResourcesService) - .get(eq(processDefinition.getId()), eq(BARResourceType.CONNECTOR), anyInt(), anyInt()); + .when(processResourcesService) + .get(eq(processDefinition.getId()), eq(BARResourceType.CONNECTOR), anyInt(), anyInt()); for (BarResource jar : jars) { doReturn(null).when(dependencyService).getDependencyOfArtifact(processDefinition.getId(), ScopeType.PROCESS, jar.getName()); @@ -649,7 +649,7 @@ public void should_disconnect_connector_when_executeOutputOperation_throw_a_SOpe assertThatThrownBy( () -> connectorService.executeOutputOperation(new ArrayList<>(), new SExpressionContext(1L, "", 1L), connectorResult)) - .isInstanceOf(SConnectorException.class); + .isInstanceOf(SConnectorException.class); // Then verify(connectorExecutor).disconnect(any(SConnectorAdapter.class)); diff --git a/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/process/instance/impl/ActivityInstanceServiceImplTest.java b/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/process/instance/impl/ActivityInstanceServiceImplTest.java index 44be868b68d..e0e40829f42 100644 --- a/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/process/instance/impl/ActivityInstanceServiceImplTest.java +++ b/bpm/bonita-core/bonita-process-instance/src/test/java/org/bonitasoft/engine/core/process/instance/impl/ActivityInstanceServiceImplTest.java @@ -404,7 +404,7 @@ public void should_search_pending_tasks_assigned_to_a_user() throws Exception { List expectedResult = new ArrayList<>(); when(persistenceService.searchEntity(SHumanTaskInstance.class, "PendingAssignedTo", options, Collections.singletonMap("userId", 61L))) - .thenReturn(expectedResult); + .thenReturn(expectedResult); // When final List result = activityInstanceServiceImpl.searchPendingTasksAssignedTo(61L, options); @@ -419,7 +419,7 @@ public void should_search_pending_tasks_assigned_to_a_user_throw_exception_on_pe final QueryOptions options = new QueryOptions(0, 10); when(persistenceService.searchEntity(SHumanTaskInstance.class, "PendingAssignedTo", options, Collections.singletonMap("userId", 99L))) - .thenThrow(new SBonitaReadException("Fake for test")); + .thenThrow(new SBonitaReadException("Fake for test")); // When Throwable thrown = catchThrowable(() -> { @@ -438,7 +438,7 @@ public void should_count_number_of_pending_tasks_assigned_to_user() throws Excep final QueryOptions options = new QueryOptions(0, 10); when(persistenceService.getNumberOfEntities(SHumanTaskInstance.class, "PendingAssignedTo", options, Collections.singletonMap("userId", 365L))) - .thenReturn(14L); + .thenReturn(14L); // When final long count = activityInstanceServiceImpl.getNumberOfPendingTasksAssignedTo(365L, options); @@ -454,7 +454,7 @@ public void should_count_number_of_pending_tasks_assigned_to_user_throw_exceptio final QueryOptions options = new QueryOptions(0, 10); when(persistenceService.getNumberOfEntities(SHumanTaskInstance.class, "PendingAssignedTo", options, Collections.singletonMap("userId", 3365L))) - .thenThrow(new SBonitaReadException("Fake for test")); + .thenThrow(new SBonitaReadException("Fake for test")); // When Throwable thrown = catchThrowable(() -> { diff --git a/bpm/bonita-core/bonita-user-filter/src/test/java/org/bonitasoft/engine/core/filter/impl/UserFilterServiceImplTest.java b/bpm/bonita-core/bonita-user-filter/src/test/java/org/bonitasoft/engine/core/filter/impl/UserFilterServiceImplTest.java index f339bf87e18..06afa8c766a 100644 --- a/bpm/bonita-core/bonita-user-filter/src/test/java/org/bonitasoft/engine/core/filter/impl/UserFilterServiceImplTest.java +++ b/bpm/bonita-core/bonita-user-filter/src/test/java/org/bonitasoft/engine/core/filter/impl/UserFilterServiceImplTest.java @@ -136,8 +136,8 @@ public void should_parse_user_filter_implementation_file_and_cache_it_when_loadi "\n").getBytes(); doReturn(Collections.singletonList(new SBARResource("my-user-filter.impl", BARResourceType.USER_FILTER, PROCESS_DEFINITION_ID, userFilterImplContent))) - .when(resourceService) - .get(eq(PROCESS_DEFINITION_ID), eq(BARResourceType.USER_FILTER), anyInt(), anyInt()); + .when(resourceService) + .get(eq(PROCESS_DEFINITION_ID), eq(BARResourceType.USER_FILTER), anyInt(), anyInt()); //when userFilterService.loadUserFilters(PROCESS_DEFINITION_ID); diff --git a/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/model/application/AbstractApplicationDefinition.java b/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/model/application/AbstractApplicationDefinition.java index 66d9e9ef894..0c3888a368e 100644 --- a/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/model/application/AbstractApplicationDefinition.java +++ b/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/model/application/AbstractApplicationDefinition.java @@ -100,7 +100,7 @@ public Supplier findItemCreator(Map attributes) { public Supplier findItemCreator(TreeIndexed tree) { // We need the "link" attribute to discriminate between legacy application and application link. boolean isLink; - if (tree != null && tree.get(AbstractApplicationItem.ATTRIBUTE_LINK)instanceof TreeLeaf v) { + if (tree != null && tree.get(AbstractApplicationItem.ATTRIBUTE_LINK) instanceof TreeLeaf v) { isLink = Optional.ofNullable(v.getValue()).map(Object::toString).map(Boolean::parseBoolean) .orElse(Boolean.FALSE); } else { diff --git a/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/model/bpm/flownode/TaskDefinition.java b/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/model/bpm/flownode/TaskDefinition.java index 91e7ceb7680..c6fc8c7d584 100644 --- a/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/model/bpm/flownode/TaskDefinition.java +++ b/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/model/bpm/flownode/TaskDefinition.java @@ -50,7 +50,7 @@ protected void defineAttributes() { // add extra state ((EnumValidator) getAttribute(FlowNodeItem.ATTRIBUTE_STATE) .getValidator(EnumValidator.class.getName())) - .addValue(TaskItem.VALUE_STATE_REPLAY); + .addValue(TaskItem.VALUE_STATE_REPLAY); } @Override diff --git a/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/server/datastore/bpm/flownode/AbstractActivityDatastore.java b/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/server/datastore/bpm/flownode/AbstractActivityDatastore.java index dd2599743af..6a4f3e1329d 100644 --- a/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/server/datastore/bpm/flownode/AbstractActivityDatastore.java +++ b/bpm/bonita-web-server/src/main/java/org/bonitasoft/web/rest/server/datastore/bpm/flownode/AbstractActivityDatastore.java @@ -110,7 +110,8 @@ protected SearchOptionsBuilder makeSearchOptionBuilder(final int page, final int return new SearchOptionsCreator(page, resultsByPage, search, new Sorts(orders, new ActivityAttributeConverter()), new Filters(filters, - new ActivityFilterCreator())).getBuilder(); + new ActivityFilterCreator())) + .getBuilder(); } @Override diff --git a/bpm/bonita-web-server/src/test/java/org/bonitasoft/console/common/server/auth/AuthenticationManagerPropertiesTest.java b/bpm/bonita-web-server/src/test/java/org/bonitasoft/console/common/server/auth/AuthenticationManagerPropertiesTest.java index 38857846b39..4580b016d94 100644 --- a/bpm/bonita-web-server/src/test/java/org/bonitasoft/console/common/server/auth/AuthenticationManagerPropertiesTest.java +++ b/bpm/bonita-web-server/src/test/java/org/bonitasoft/console/common/server/auth/AuthenticationManagerPropertiesTest.java @@ -39,7 +39,7 @@ public void setUp() throws IOException { "OAuth.consumerKey = ove2vcdjptar\n" + "OAuth.consumerSecret = vdaBrCmHvkgJoYz1\n" + "OAuth.callbackURL = http://127.0.0.1:8888/loginservice").getBytes())).when(loginManagerProperties) - .getTenantPropertiesOfScope(); + .getTenantPropertiesOfScope(); } @After diff --git a/bpm/bonita-web-server/src/test/java/org/bonitasoft/web/rest/server/api/bpm/process/ProcessDefinitionDesignResourceTest.java b/bpm/bonita-web-server/src/test/java/org/bonitasoft/web/rest/server/api/bpm/process/ProcessDefinitionDesignResourceTest.java index ccf57a9b5d5..4e3bdadf1ac 100644 --- a/bpm/bonita-web-server/src/test/java/org/bonitasoft/web/rest/server/api/bpm/process/ProcessDefinitionDesignResourceTest.java +++ b/bpm/bonita-web-server/src/test/java/org/bonitasoft/web/rest/server/api/bpm/process/ProcessDefinitionDesignResourceTest.java @@ -80,8 +80,8 @@ public void testReplaceLongIdToString() throws Exception { .isEqualToIgnoringCase("{ \"id\": \"123\"}"); assertThat( processDefinitionDesignResource.replaceLongIdToString("{ \"id\":123, \"test\": [ otherid: \"zerze\"]}")) - .isEqualToIgnoringCase( - "{ \"id\":\"123\", \"test\": [ otherid: \"zerze\"]}"); + .isEqualToIgnoringCase( + "{ \"id\":\"123\", \"test\": [ otherid: \"zerze\"]}"); assertThat(processDefinitionDesignResource.replaceLongIdToString("{ \"iaed\": 123}")) .isEqualToIgnoringCase("{ \"iaed\": 123}"); assertThat(processDefinitionDesignResource.replaceLongIdToString("{ \"name\": \"\\\"id\\\": 123\"}")) diff --git a/bpm/bonita-web-server/src/test/java/org/bonitasoft/web/rest/server/api/bpm/process/ProcessInstantiationResourceTest.java b/bpm/bonita-web-server/src/test/java/org/bonitasoft/web/rest/server/api/bpm/process/ProcessInstantiationResourceTest.java index c5ea4ddcb75..5c8cbf0b975 100644 --- a/bpm/bonita-web-server/src/test/java/org/bonitasoft/web/rest/server/api/bpm/process/ProcessInstantiationResourceTest.java +++ b/bpm/bonita-web-server/src/test/java/org/bonitasoft/web/rest/server/api/bpm/process/ProcessInstantiationResourceTest.java @@ -160,7 +160,7 @@ public void should_respond_400_Bad_request_when_contract_is_not_validated_when_i throws Exception { doThrow(new ContractViolationException("aMessage", "aMessage", asList("first explanation", "second explanation"), null)) - .when(processAPI).startProcessWithInputs(anyLong(), anyMapOf(String.class, Serializable.class)); + .when(processAPI).startProcessWithInputs(anyLong(), anyMapOf(String.class, Serializable.class)); when(processAPI.getProcessContract(PROCESS_DEFINITION_ID)).thenReturn(contractDefinition); final Response response = request(URL_API_PROCESS_INSTANTIATION_TEST).post(VALID_POST_BODY); diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 024bc250022..4bfb4b52dac 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -166,6 +166,6 @@ groovy = ["groovyCore", "groovyServlet", "groovyXml", "groovyJson", "groovyJmx", "groovyDateutil", "groovyDocgenerator", "groovyJsr223", "groovySql", "groovyTemplates", "groovyYaml"] [plugins] -bonitaFormatting = { id = "com.bonitasoft.gradle.bonita-formatting", version = "0.1.63" } +bonitaFormatting = { id = "com.bonitasoft.gradle.bonita-formatting", version = "0.1.64" } dependencyUpdates = { id = "com.github.ben-manes.versions", version = "0.51.0" } # used by "List out-of-date dependencies" script taskInfo = { id = "org.barfuin.gradle.taskinfo", version = "2.2.0" } # Adds a 'tiTree' task to display Gradle task-graph diff --git a/platform/platform-setup/src/test/java/org/bonitasoft/platform/configuration/util/FolderComparator.java b/platform/platform-setup/src/test/java/org/bonitasoft/platform/configuration/util/FolderComparator.java index e737e879b1d..8b6fb5dd0f5 100644 --- a/platform/platform-setup/src/test/java/org/bonitasoft/platform/configuration/util/FolderComparator.java +++ b/platform/platform-setup/src/test/java/org/bonitasoft/platform/configuration/util/FolderComparator.java @@ -76,7 +76,7 @@ private void compareFileContent(File expectedFile, File givenFile) throws Except case XML: final List allDifferences = new DetailedDiff( XMLUnit.compareXML(new FileReader(givenFile), new FileReader(expectedFile))) - .getAllDifferences(); + .getAllDifferences(); Assertions.assertThat(allDifferences).as("should xml file be equals").isEmpty(); break; default: diff --git a/platform/platform-setup/src/test/java/org/bonitasoft/platform/setup/ConfigurationCheckerTest.java b/platform/platform-setup/src/test/java/org/bonitasoft/platform/setup/ConfigurationCheckerTest.java index e5d6a02826c..58ce7a9ef6c 100644 --- a/platform/platform-setup/src/test/java/org/bonitasoft/platform/setup/ConfigurationCheckerTest.java +++ b/platform/platform-setup/src/test/java/org/bonitasoft/platform/setup/ConfigurationCheckerTest.java @@ -70,7 +70,7 @@ public void validate_should_fail_mandatory_property_is_not_set() throws Exceptio System.setProperty(PlatformSetup.BONITA_DB_VENDOR_PROPERTY, dbVendor); final Properties propertiesWithMissingServerName = new PropertyLoader( TEST_DATASOURCE_CONFIG_DIR + "incomplete_database.properties") - .loadProperties(); + .loadProperties(); expectedException.expect(PlatformException.class); expectedException.expectMessage("Mandatory property"); diff --git a/platform/platform-setup/src/test/java/org/bonitasoft/platform/setup/command/configure/DatabaseConfigurationTest.java b/platform/platform-setup/src/test/java/org/bonitasoft/platform/setup/command/configure/DatabaseConfigurationTest.java index d4f4044783f..868924cd203 100644 --- a/platform/platform-setup/src/test/java/org/bonitasoft/platform/setup/command/configure/DatabaseConfigurationTest.java +++ b/platform/platform-setup/src/test/java/org/bonitasoft/platform/setup/command/configure/DatabaseConfigurationTest.java @@ -189,8 +189,8 @@ public void jdbc_pool_size_values_must_be_integers() throws Exception { // expect: assertThatThrownBy( () -> new DatabaseConfiguration("bdm.", properties, null)) - .isExactlyInstanceOf(PlatformException.class) - .hasMessage("Invalid integer value 'ten' for property 'bdm.connection-pool.maxIdle'"); + .isExactlyInstanceOf(PlatformException.class) + .hasMessage("Invalid integer value 'ten' for property 'bdm.connection-pool.maxIdle'"); } } diff --git a/services/bonita-business-application/src/test/java/org/bonitasoft/engine/business/application/impl/ApplicationServiceImplTest.java b/services/bonita-business-application/src/test/java/org/bonitasoft/engine/business/application/impl/ApplicationServiceImplTest.java index 207a329147c..40f32484c8e 100755 --- a/services/bonita-business-application/src/test/java/org/bonitasoft/engine/business/application/impl/ApplicationServiceImplTest.java +++ b/services/bonita-business-application/src/test/java/org/bonitasoft/engine/business/application/impl/ApplicationServiceImplTest.java @@ -407,7 +407,8 @@ public void createApplicationPage_should_throw_SObjectAlreadyExistsException_whe inputParameters.put("applicationPageToken", "mainDashBoard"); given(persistenceService.selectOne( new SelectOneDescriptor("getApplicationPageByTokenAndApplicationId", inputParameters, - SApplicationPage.class))).willReturn(applicationPage); + SApplicationPage.class))) + .willReturn(applicationPage); //when final SApplicationPage applicationPageToCreate = buildApplicationPage(7, 5, 16, "mainDashBoard"); @@ -679,7 +680,8 @@ public void getApplicationHomePage_should_return_result_of_persitence_service_se inputParameters.put("applicationId", 100); given(persistenceService .selectOne(new SelectOneDescriptor("getApplicationHomePage", inputParameters, - SApplicationPage.class))).willReturn(applicationPage); + SApplicationPage.class))) + .willReturn(applicationPage); //when final SApplicationPage homePage = applicationServiceImpl.getApplicationHomePage(100); @@ -696,7 +698,8 @@ public void getApplicationHomePage_should_throw_SObjectNotFoundException_when_pe inputParameters.put("applicationId", 100); given(persistenceService .selectOne(new SelectOneDescriptor("getApplicationHomePage", inputParameters, - SApplicationPage.class))).willReturn(null); + SApplicationPage.class))) + .willReturn(null); //when applicationServiceImpl.getApplicationHomePage(100); diff --git a/services/bonita-business-application/src/test/java/org/bonitasoft/engine/business/application/impl/IndexUpdaterTest.java b/services/bonita-business-application/src/test/java/org/bonitasoft/engine/business/application/impl/IndexUpdaterTest.java index 30c11907abb..199c153fdfd 100755 --- a/services/bonita-business-application/src/test/java/org/bonitasoft/engine/business/application/impl/IndexUpdaterTest.java +++ b/services/bonita-business-application/src/test/java/org/bonitasoft/engine/business/application/impl/IndexUpdaterTest.java @@ -78,7 +78,7 @@ public void incrementIndexes_should_increment_indexes_of_all_elements_in_the_spe .willReturn(Arrays.asList(menu3, menu4)); given(applicationService .searchApplicationMenus(new QueryOptions(MAX_RESULTS, MAX_RESULTS, orderBy, filters, null))) - .willReturn(Arrays.asList(menu5)); + .willReturn(Arrays.asList(menu5)); //when indexUpdater.incrementIndexes(1L, 3, 5); @@ -118,7 +118,7 @@ public void decrementIndexes_should_decrement_indexes_of_all_elements_in_the_spe .willReturn(Arrays.asList(menu3, menu4)); given(applicationService .searchApplicationMenus(new QueryOptions(MAX_RESULTS, MAX_RESULTS, orderBy, filters, null))) - .willReturn(Arrays.asList(menu5)); + .willReturn(Arrays.asList(menu5)); //when indexUpdater.decrementIndexes(1L, 3, 5); diff --git a/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/AbstractBDMCodeGeneratorTest.java b/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/AbstractBDMCodeGeneratorTest.java index 4ff362ee64d..b84b331c1fd 100644 --- a/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/AbstractBDMCodeGeneratorTest.java +++ b/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/AbstractBDMCodeGeneratorTest.java @@ -36,7 +36,7 @@ public void should_createMethodForNewInstance_return_jmethod_with_valid_name_and final AbstractBDMCodeGenerator abstractBDMCodeGenerator = mock(AbstractBDMCodeGenerator.class); when(abstractBDMCodeGenerator.createMethodForNewInstance(any(BusinessObject.class), any(JDefinedClass.class), any(JDefinedClass.class))) - .thenCallRealMethod(); + .thenCallRealMethod(); when(abstractBDMCodeGenerator.addMethodSignature(any(JDefinedClass.class), anyString(), any(JType.class))) .thenCallRealMethod(); when(abstractBDMCodeGenerator.getModel()).thenReturn(new JCodeModel()); diff --git a/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/filter/OnlyDAOImplementationFileFilterTest.java b/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/filter/OnlyDAOImplementationFileFilterTest.java index 751f38458a5..31ee7d405e8 100644 --- a/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/filter/OnlyDAOImplementationFileFilterTest.java +++ b/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/filter/OnlyDAOImplementationFileFilterTest.java @@ -72,7 +72,7 @@ private void checkAcceptShouldReturns(String domain, String subDomain, String ex doReturn("Employee." + extension).when(file).getName(); doReturn(domain + File.separatorChar + subDomain + File.separatorChar + "model" + File.separatorChar + "Employee." + extension).when(file) - .getAbsolutePath(); + .getAbsolutePath(); // when then assertThat(fileFilter.accept(file)) diff --git a/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/filter/WithoutDAOImplementationFileFilterTest.java b/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/filter/WithoutDAOImplementationFileFilterTest.java index c09ac832e3c..27b67a8a9f3 100644 --- a/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/filter/WithoutDAOImplementationFileFilterTest.java +++ b/services/bonita-business-data/bonita-business-data-generator/src/test/java/org/bonitasoft/engine/business/data/generator/filter/WithoutDAOImplementationFileFilterTest.java @@ -60,7 +60,7 @@ private void checkAcceptShouldReturns(String domain, String subDomain, String ex doReturn("Employee." + extension).when(file).getName(); doReturn(domain + File.separatorChar + subDomain + File.separatorChar + "model" + File.separatorChar + "Employee." + extension).when(file) - .getAbsolutePath(); + .getAbsolutePath(); // when then assertThat(fileFilter.accept(file)) diff --git a/services/bonita-business-data/bonita-business-data-impl/src/test/java/org/bonitasoft/engine/business/data/impl/BusinessDataModelRepositoryImplTest.java b/services/bonita-business-data/bonita-business-data-impl/src/test/java/org/bonitasoft/engine/business/data/impl/BusinessDataModelRepositoryImplTest.java index 91211304338..0c208678d05 100644 --- a/services/bonita-business-data/bonita-business-data-impl/src/test/java/org/bonitasoft/engine/business/data/impl/BusinessDataModelRepositoryImplTest.java +++ b/services/bonita-business-data/bonita-business-data-impl/src/test/java/org/bonitasoft/engine/business/data/impl/BusinessDataModelRepositoryImplTest.java @@ -243,7 +243,7 @@ public void update_should_convert_exceptions_to_allow_to_see_entire_root_cause() doReturn(singletonList(new CommandAcceptanceException("Error executing DDL bla bla bla...", new SQLSyntaxErrorException("ORA-02275: une telle contrainte référentielle existe déjà dans la table", new Exception("Root Oracle Cause"))))) - .when(schemaManager).update(anySet()); + .when(schemaManager).update(anySet()); // when - then: assertThatExceptionOfType(SBusinessDataRepositoryDeploymentException.class) @@ -264,7 +264,7 @@ public void update_should_convert_all_exceptions_in_the_list() { new Exception("Root Oracle Cause"))), new CommandAcceptanceException("CommandAcceptanceException bliblibli", new SQLSyntaxErrorException("Hibernate error")))) - .when(schemaManager).update(anySet()); + .when(schemaManager).update(anySet()); // when - then: assertThatExceptionOfType(SBusinessDataRepositoryDeploymentException.class) @@ -296,7 +296,7 @@ public void isDeployedComparesBdmWithSameContent() throws Exception { var generatedJarContent = "fake jar content".getBytes(); when(dependencyService.getIdOfDependencyOfArtifact(TENANT_ID, ScopeType.TENANT, BusinessDataModelRepositoryImpl.BDR_DEPENDENCY_FILENAME)) - .thenReturn(Optional.of(1L)); + .thenReturn(Optional.of(1L)); var deployedBdm = new SDependency(); deployedBdm.setValue_(generatedJarContent); when(dependencyService.getDependency(1L)).thenReturn(deployedBdm); @@ -318,7 +318,7 @@ public void isDeployedComparesBdmWithDifferentContent() throws Exception { var generatedJarContent = "fake jar content".getBytes(); when(dependencyService.getIdOfDependencyOfArtifact(TENANT_ID, ScopeType.TENANT, BusinessDataModelRepositoryImpl.BDR_DEPENDENCY_FILENAME)) - .thenReturn(Optional.of(1L)); + .thenReturn(Optional.of(1L)); var deployedBdm = new SDependency(); deployedBdm.setValue_(existingJarContent); when(dependencyService.getDependency(1L)).thenReturn(deployedBdm); @@ -338,7 +338,7 @@ public void isDeployedWithoutBdmDeployed() throws Exception { var bdmArchive = "fake archive content".getBytes(); when(dependencyService.getIdOfDependencyOfArtifact(TENANT_ID, ScopeType.TENANT, BusinessDataModelRepositoryImpl.BDR_DEPENDENCY_FILENAME)) - .thenReturn(Optional.empty()); + .thenReturn(Optional.empty()); // when: var isDeployed = businessDataModelRepository.isDeployed(bdmArchive); diff --git a/services/bonita-business-data/bonita-business-data-impl/src/test/java/org/bonitasoft/engine/business/data/impl/JPABusinessDataRepositoryImplITest.java b/services/bonita-business-data/bonita-business-data-impl/src/test/java/org/bonitasoft/engine/business/data/impl/JPABusinessDataRepositoryImplITest.java index 319b5aa5d3f..415238278ba 100644 --- a/services/bonita-business-data/bonita-business-data-impl/src/test/java/org/bonitasoft/engine/business/data/impl/JPABusinessDataRepositoryImplITest.java +++ b/services/bonita-business-data/bonita-business-data-impl/src/test/java/org/bonitasoft/engine/business/data/impl/JPABusinessDataRepositoryImplITest.java @@ -218,7 +218,7 @@ public void returnNullnWhenFindingAnUnknownEmployee() throws Exception { (Serializable) "Unknown_lastName"); assertThat( businessDataRepository.find(Employee.class, "FROM Employee e WHERE e.lastName = :lastName", parameters)) - .isNull(); + .isNull(); } @Test(expected = IllegalStateException.class) diff --git a/services/bonita-command/src/test/java/org/bonitasoft/engine/command/api/impl/CommandServiceImplTest.java b/services/bonita-command/src/test/java/org/bonitasoft/engine/command/api/impl/CommandServiceImplTest.java index 726c621bfa6..562a946d668 100644 --- a/services/bonita-command/src/test/java/org/bonitasoft/engine/command/api/impl/CommandServiceImplTest.java +++ b/services/bonita-command/src/test/java/org/bonitasoft/engine/command/api/impl/CommandServiceImplTest.java @@ -249,7 +249,7 @@ public final void getUserCommands() throws SCommandGettingException, SBonitaRead final int maxResults = 1; when(persistence .selectList(SelectDescriptorBuilder.getUserCommands(field, orderByType, startIndex, maxResults))) - .thenReturn(sCommands); + .thenReturn(sCommands); // When final List userCommands = commandServiceImpl.getUserCommands(startIndex, maxResults, @@ -268,8 +268,8 @@ public final void getUserCommandsThrowException() throws SCommandGettingExceptio final int maxResults = 1; when(persistence .selectList(SelectDescriptorBuilder.getUserCommands(field, orderByType, startIndex, maxResults))) - .thenThrow( - new SBonitaReadException("")); + .thenThrow( + new SBonitaReadException("")); // When commandServiceImpl.getUserCommands(startIndex, maxResults, SCommandCriterion.NAME_DESC); diff --git a/services/bonita-commons/src/test/java/org/bonitasoft/engine/DeepRegexFileFilterTest.java b/services/bonita-commons/src/test/java/org/bonitasoft/engine/DeepRegexFileFilterTest.java index 2753b7878b8..9db17bdd491 100644 --- a/services/bonita-commons/src/test/java/org/bonitasoft/engine/DeepRegexFileFilterTest.java +++ b/services/bonita-commons/src/test/java/org/bonitasoft/engine/DeepRegexFileFilterTest.java @@ -27,7 +27,7 @@ public void acceptShouldWorkForMatchingPattern() { final String parentPatternPathname = "/media/drive/some_folder"; assertThat(new DeepRegexFileFilter(new File(parentPatternPathname), pattern) .accept(new File("/media/drive/some_folder/folder/sub/matchingFile.txt"))) - .isTrue(); + .isTrue(); } @Test @@ -36,7 +36,7 @@ public void acceptShouldWorkForMatchingPatternOnFolderWithTrailingSlash() { final String parentPatternPathname = "/home/some_folder/"; assertThat(new DeepRegexFileFilter(new File(parentPatternPathname), pattern) .accept(new File("/home/some_folder/folder/sub/matchingFile.txt"))) - .isTrue(); + .isTrue(); } @Test @@ -45,7 +45,7 @@ public void acceptShouldRejectNonMatchingFile() { final String parentPatternPathname = "/home/some_folder/"; assertThat(new DeepRegexFileFilter(new File(parentPatternPathname), pattern) .accept(new File("/home/some_folder/folder/sub/someReport.pdf"))) - .isFalse(); + .isFalse(); } @Test @@ -54,7 +54,7 @@ public void acceptShouldMatchDeepSubFolders() { final String parentPatternPathname = "/home"; assertThat(new DeepRegexFileFilter(new File(parentPatternPathname), pattern) .accept(new File("/home/folder/sub/sub2/fileHiddenInDeepFolder.txt"))) - .isTrue(); + .isTrue(); } @Test @@ -63,7 +63,7 @@ public void acceptShouldNotMatchSlashBeginingPatterns() { final String parentPatternPathname = "/home"; assertThat(new DeepRegexFileFilter(new File(parentPatternPathname), pattern) .accept(new File("/home/folder/sub/sub2/fileHiddenInDeepFolder.txt"))) - .isFalse(); + .isFalse(); } } diff --git a/services/bonita-commons/src/test/java/org/bonitasoft/engine/commons/JavaMethodInvokerTest.java b/services/bonita-commons/src/test/java/org/bonitasoft/engine/commons/JavaMethodInvokerTest.java index 2a4ca56cb28..2f0703404ad 100644 --- a/services/bonita-commons/src/test/java/org/bonitasoft/engine/commons/JavaMethodInvokerTest.java +++ b/services/bonita-commons/src/test/java/org/bonitasoft/engine/commons/JavaMethodInvokerTest.java @@ -103,7 +103,7 @@ void invokeJavaMethod_should_throw_nosuchmethodexception() throws Exception { myData, "setDoesNotExistMethod", "java.lang.String"); }) - .isInstanceOf(NoSuchMethodException.class); + .isInstanceOf(NoSuchMethodException.class); } } diff --git a/services/bonita-connector-executor/src/test/java/org/bonitasoft/engine/connector/impl/ConnectorExecutorImplTest.java b/services/bonita-connector-executor/src/test/java/org/bonitasoft/engine/connector/impl/ConnectorExecutorImplTest.java index 289981ad6ff..4a7aaa8821d 100644 --- a/services/bonita-connector-executor/src/test/java/org/bonitasoft/engine/connector/impl/ConnectorExecutorImplTest.java +++ b/services/bonita-connector-executor/src/test/java/org/bonitasoft/engine/connector/impl/ConnectorExecutorImplTest.java @@ -272,7 +272,8 @@ public void createExecutorService_should_register_ExecutorServiceMetrics() { meterRegistry.find("executor.pool.size") .tag("name", "bonita-connector-executor") .tag("tenant", String.valueOf(TENANT_ID)) - .gauge()).isNotNull(); + .gauge()) + .isNotNull(); } // ================================================================================================================= diff --git a/services/bonita-data-instance/src/test/java/org/bonitasoft/engine/data/instance/api/impl/DataInstanceServiceImplTest.java b/services/bonita-data-instance/src/test/java/org/bonitasoft/engine/data/instance/api/impl/DataInstanceServiceImplTest.java index e1b9b673542..bc151788a06 100644 --- a/services/bonita-data-instance/src/test/java/org/bonitasoft/engine/data/instance/api/impl/DataInstanceServiceImplTest.java +++ b/services/bonita-data-instance/src/test/java/org/bonitasoft/engine/data/instance/api/impl/DataInstanceServiceImplTest.java @@ -181,7 +181,7 @@ public void should_return_the_archived_data_in_the_up_most_container() throws Ex doReturn(dataInstances).when(persistenceService).selectList(any(SelectListDescriptor.class)); doReturn(Arrays.asList(new DataContainer(68L, "SUBTASK"), new DataContainer(67L, "TASK"), new DataContainer(66L, "PROC"))).when(parentContainerResolver) - .getArchivedContainerHierarchy(new DataContainer(68L, "SUBTASK")); + .getArchivedContainerHierarchy(new DataContainer(68L, "SUBTASK")); //when SADataInstance dataInstance = dataInstanceServiceImpl.getLastSADataInstance("testData", 68L, "SUBTASK", parentContainerResolver); @@ -219,7 +219,7 @@ public void should_return_the_data_in_the_up_most_container() throws Exception { doReturn(dataInstances).when(persistenceService).selectList(any(SelectListDescriptor.class)); doReturn(Arrays.asList(new DataContainer(68L, "SUBTASK"), new DataContainer(67L, "TASK"), new DataContainer(66L, "PROC"))).when(parentContainerResolver) - .getContainerHierarchy(new DataContainer(68L, "SUBTASK")); + .getContainerHierarchy(new DataContainer(68L, "SUBTASK")); //when SDataInstance dataInstance = dataInstanceServiceImpl.getDataInstance("testData", 68L, "SUBTASK", parentContainerResolver); diff --git a/services/bonita-identity/src/test/java/org/bonitasoft/engine/identity/impl/IdentityServiceImplForGroupTest.java b/services/bonita-identity/src/test/java/org/bonitasoft/engine/identity/impl/IdentityServiceImplForGroupTest.java index a1d2066acf4..738c1006b60 100644 --- a/services/bonita-identity/src/test/java/org/bonitasoft/engine/identity/impl/IdentityServiceImplForGroupTest.java +++ b/services/bonita-identity/src/test/java/org/bonitasoft/engine/identity/impl/IdentityServiceImplForGroupTest.java @@ -128,8 +128,8 @@ public void getGroupChildrenPaginatedByIdWithOrder() throws Exception { .thenReturn(group); when(persistenceService .selectList(SelectDescriptorBuilder.getChildrenOfGroup(group, "name", OrderByType.ASC, 0, 10))) - .thenReturn( - Collections.singletonList(child)); + .thenReturn( + Collections.singletonList(child)); assertEquals(child, identityServiceImpl.getGroupChildren(123l, 0, 10, "name", OrderByType.ASC).get(0)); } @@ -141,8 +141,8 @@ public void getGroupChildrenPaginatedByIdWithOrderThrowException() throws Except .thenReturn(group); when(persistenceService .selectList(SelectDescriptorBuilder.getChildrenOfGroup(group, "name", OrderByType.ASC, 0, 10))) - .thenThrow( - new SBonitaReadException("")); + .thenThrow( + new SBonitaReadException("")); identityServiceImpl.getGroupChildren(123l, 0, 10, "name", OrderByType.ASC); } @@ -286,8 +286,8 @@ public final void getGroupsByIds() throws SBonitaReadException, SGroupNotFoundEx final SGroup group = mock(SGroup.class); when(persistenceService .selectList(SelectDescriptorBuilder.getElementsByIds(SGroup.class, "Group", Arrays.asList(123l)))) - .thenReturn( - Arrays.asList(group)); + .thenReturn( + Arrays.asList(group)); assertEquals(group, identityServiceImpl.getGroups(Arrays.asList(123l)).get(0)); } @@ -341,8 +341,8 @@ public void getGroupsPaginatedWithOrder() throws Exception { final SGroup group = mock(SGroup.class); when(persistenceService .selectList(SelectDescriptorBuilder.getElements(SGroup.class, "Group", "name", OrderByType.ASC, 0, 10))) - .thenReturn( - Arrays.asList(group)); + .thenReturn( + Arrays.asList(group)); assertEquals(group, identityServiceImpl.getGroups(0, 10, "name", OrderByType.ASC).get(0)); } diff --git a/services/bonita-identity/src/test/java/org/bonitasoft/engine/identity/impl/IdentityServiceImplForUserMembershipTest.java b/services/bonita-identity/src/test/java/org/bonitasoft/engine/identity/impl/IdentityServiceImplForUserMembershipTest.java index 55f2c8ec117..e1ec771f97c 100644 --- a/services/bonita-identity/src/test/java/org/bonitasoft/engine/identity/impl/IdentityServiceImplForUserMembershipTest.java +++ b/services/bonita-identity/src/test/java/org/bonitasoft/engine/identity/impl/IdentityServiceImplForUserMembershipTest.java @@ -338,7 +338,7 @@ public void getUserMembershipsPaginatedWithOrderThrowException() throws Exceptio persistenceService .selectList(SelectDescriptorBuilder.getElements(SUserMembership.class, "UserMembership", new QueryOptions(0, 10, Collections.singletonList(orderByOption))))) - .thenThrow(new SBonitaReadException("")); + .thenThrow(new SBonitaReadException("")); identityServiceImpl.getUserMemberships(0, 10, orderByOption); } @@ -352,7 +352,7 @@ public void getUserMembershipsOrderByRole() throws Exception { .selectList(SelectDescriptorBuilder.getUserMembershipsWithRole(new QueryOptions(0, 10, Collections .singletonList(orderByOption))))) - .thenReturn(Collections.singletonList(userMembership)); + .thenReturn(Collections.singletonList(userMembership)); final List userMemberships = identityServiceImpl.getUserMemberships(0, 10, orderByOption); @@ -368,7 +368,7 @@ public void getUserMembershipsOrderByGroup() throws Exception { .selectList(SelectDescriptorBuilder.getUserMembershipsWithGroup(new QueryOptions(0, 10, Collections .singletonList(orderByOption))))) - .thenReturn(Collections.singletonList(userMembership)); + .thenReturn(Collections.singletonList(userMembership)); final List userMemberships = identityServiceImpl.getUserMemberships(0, 10, orderByOption); diff --git a/services/bonita-persistence/src/main/java/org/bonitasoft/engine/persistence/HibernatePersistenceService.java b/services/bonita-persistence/src/main/java/org/bonitasoft/engine/persistence/HibernatePersistenceService.java index f1394ef8b85..d7ccc92a6ae 100644 --- a/services/bonita-persistence/src/main/java/org/bonitasoft/engine/persistence/HibernatePersistenceService.java +++ b/services/bonita-persistence/src/main/java/org/bonitasoft/engine/persistence/HibernatePersistenceService.java @@ -612,7 +612,7 @@ public void deleteByTenant(final Class entityClass, } QueryGeneratorForFilters.QueryGeneratedFilters whereClause = new QueryGeneratorForFilters( getClassAliasMappings(), '%'/* there is no 'like' in these delete queries */) - .generate(filters); + .generate(filters); parameters.putAll(whereClause.getParameters()); baseQuery += " WHERE ( " + whereClause.getFilters() + " )"; } diff --git a/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobDescriptorTest.java b/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobDescriptorTest.java index fcb8830e7f3..f15e05ae955 100644 --- a/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobDescriptorTest.java +++ b/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobDescriptorTest.java @@ -260,8 +260,8 @@ public void getJobDescriptor_by_id_should_return_jobDescriptor() final SJobDescriptor sJobDescriptor = mock(SJobDescriptor.class); when(readPersistenceService.selectById( SelectDescriptorBuilder.getElementById(SJobDescriptor.class, "SJobDescriptor", jobDescriptorId))) - .thenReturn( - sJobDescriptor); + .thenReturn( + sJobDescriptor); // When final SJobDescriptor jobDescriptor = jobServiceImpl.getJobDescriptor(jobDescriptorId); diff --git a/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobLogTest.java b/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobLogTest.java index 42fa7a05622..11439be3d58 100644 --- a/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobLogTest.java +++ b/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobLogTest.java @@ -224,7 +224,7 @@ public void getJobLog() throws SBonitaReadException { final SJobLog sJobLog = mock(SJobLog.class); when(readPersistenceService .selectById(SelectDescriptorBuilder.getElementById(SJobLog.class, "SJobLog", jobLogId))) - .thenReturn(sJobLog); + .thenReturn(sJobLog); // When final SJobLog result = jobServiceImpl.getJobLog(jobLogId); diff --git a/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobParameterTest.java b/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobParameterTest.java index ce2f01af153..cdab83c367d 100644 --- a/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobParameterTest.java +++ b/services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/JobServiceImplForJobParameterTest.java @@ -275,8 +275,8 @@ public void getJobParameter_by_id() throws Exception { final SJobParameter sJobParameter = mock(SJobParameter.class); when(readPersistenceService.selectById( SelectDescriptorBuilder.getElementById(SJobParameter.class, "SJobParameter", jobParameterId))) - .thenReturn( - sJobParameter); + .thenReturn( + sJobParameter); // When final SJobParameter result = jobServiceImpl.getJobParameter(jobParameterId); diff --git a/services/bonita-work/src/test/java/org/bonitasoft/engine/work/DefaultBonitaExecutorServiceFactoryTest.java b/services/bonita-work/src/test/java/org/bonitasoft/engine/work/DefaultBonitaExecutorServiceFactoryTest.java index 4239d442b80..701d289f009 100644 --- a/services/bonita-work/src/test/java/org/bonitasoft/engine/work/DefaultBonitaExecutorServiceFactoryTest.java +++ b/services/bonita-work/src/test/java/org/bonitasoft/engine/work/DefaultBonitaExecutorServiceFactoryTest.java @@ -76,7 +76,8 @@ public void createExecutorService_should_register_ExecutorServiceMetrics() { meterRegistry.find("executor.pool.size") .tag("name", "bonita-work-executor") .tag("tenant", String.valueOf(tenantId)) - .gauge()).isNotNull(); + .gauge()) + .isNotNull(); } @Test @@ -102,6 +103,7 @@ public void should_not_have_metrics_when_unbind_is_called() { meterRegistry.find("executor.pool.size") .tag("name", "bonita-work-executor") .tag("tenant", String.valueOf(tenantId)) - .gauge()).isNull(); + .gauge()) + .isNull(); } } diff --git a/services/bonita-work/src/test/java/org/bonitasoft/engine/work/DefaultExceptionRetryabilityEvaluatorTest.java b/services/bonita-work/src/test/java/org/bonitasoft/engine/work/DefaultExceptionRetryabilityEvaluatorTest.java index bbff55c51a8..830ca470030 100644 --- a/services/bonita-work/src/test/java/org/bonitasoft/engine/work/DefaultExceptionRetryabilityEvaluatorTest.java +++ b/services/bonita-work/src/test/java/org/bonitasoft/engine/work/DefaultExceptionRetryabilityEvaluatorTest.java @@ -138,7 +138,7 @@ public void should_retry_sql_connection_exceptions() { assertThat(defaultExceptionRetryabilityEvaluator .evaluateRetryability(new IllegalStateException(new SQLException("connection issue")))) - .isEqualTo(RETRYABLE); + .isEqualTo(RETRYABLE); assertThat(defaultExceptionRetryabilityEvaluator .evaluateRetryability(new CannotGetJdbcConnectionException("I/O error"))).isEqualTo(RETRYABLE); } @@ -149,7 +149,7 @@ public void should_be_UNCERTAIN_COMPLETION_OF_COMMIT_when_retryable_exception_ha assertThat(defaultExceptionRetryabilityEvaluator .evaluateRetryability(new STransactionCommitException(new SQLException("connection issue")))) - .isEqualTo(UNCERTAIN_COMPLETION_OF_COMMIT); + .isEqualTo(UNCERTAIN_COMPLETION_OF_COMMIT); } @Test @@ -158,7 +158,7 @@ public void should_not_be_UNCERTAIN_COMPLETION_OF_COMMIT_when_retryable_exceptio assertThat(defaultExceptionRetryabilityEvaluator.evaluateRetryability( new STransactionCommitException(new SRetryableException(new IOException("some file issue"))))) - .isEqualTo(RETRYABLE); + .isEqualTo(RETRYABLE); } @Test @@ -167,7 +167,7 @@ public void should_retry_retryable_xa_exceptions() { assertThat( defaultExceptionRetryabilityEvaluator.evaluateRetryability(new XAException(XAException.XA_RBTIMEOUT))) - .isEqualTo(RETRYABLE); + .isEqualTo(RETRYABLE); } @Test