Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize PR procedure. #49

Open
DavidSagan opened this issue Sep 9, 2024 · 2 comments
Open

Formalize PR procedure. #49

DavidSagan opened this issue Sep 9, 2024 · 2 comments

Comments

@DavidSagan
Copy link
Member

There needs to be some guidelines for how to handle PRs. How are reviewers assigned (the PR person assigns reviewers?) and who should be responsible for merging the PR (The PR person after the reviewers are finished?) are two.

@rot4te
Copy link
Collaborator

rot4te commented Sep 20, 2024

Following my email a few minutes ago, I think the most important part of this is editing the CI workflow.
If you've done your work in a new branch (eg after a git checkout -b new_issue), then you can push to
the branch with git push -u origin new_issue, and it will run the CI. If the CI is modified with the intended functionality of the new code in mind, a passing score could let us automatically merge.

@DavidSagan
Copy link
Member Author

Just passing CI tests is not always enough. Especially if the person submitting the PR is inexperienced. We should have a discussion about this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants