Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facilitySpecific should be renamed to allowedForFacilitySpecific #19

Closed
montanajava opened this issue Feb 1, 2024 · 1 comment · Fixed by #49
Closed

facilitySpecific should be renamed to allowedForFacilitySpecific #19

montanajava opened this issue Feb 1, 2024 · 1 comment · Fixed by #49

Comments

@montanajava
Copy link
Collaborator

montanajava commented Feb 1, 2024

The attribute name facilitySpecific does not do justice to what this attribute is intended to accomplish.

The practice in the HofRec world is that a metaIngredient (the template upon which a product is ultimately defined) has an intended use, i.e. it is defined up-front whether a farmer can deviate from the template as defined by BLW staff. To accomplish this today in Hoduflu, the attribute allows TRUE | FALSE | BOTH. BOTH means that a metaIngredient can be used for standard products and also for bespoke products defined by a farmer.

BOTH is of course nonsensical but necessary if we in turn have an attribute name that does not represent the actual domain requirements.

As such, to solve the problem, it is recommended that attribute facilitySpecific be called allowedForFacilitySpecific. Doing so allows for a sensible use of TRUE | FALSE as is recommended in #18.

@anjaaeschlimann
Copy link

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants