Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiplier from resource docs, add it instead as an extra first dimension in descriptor shape #576

Open
jwlodek opened this issue Sep 13, 2024 · 1 comment

Comments

@jwlodek
Copy link
Member

jwlodek commented Sep 13, 2024

Per discussion today, it was decided that in order to keep the dimensionality of shape in the event descriptor consistent, that the multiplier should be added there as the first dimension. So for example in the case of two detectors w/ x-y dimensions of 10x10, with one collecting a single frame per acq, and one collecting 5, we would have

shape: (1, 10, 10)

and

shape: (5, 10, 10)

respectively in the descriptor. Since this tells you the multiplier, and you can fetch this information given a resource doc by looking back at the associated descriptor, the multiplier field can be removed from the resource doc creation.

@jwlodek
Copy link
Member Author

jwlodek commented Sep 13, 2024

@coretl @genematx @danielballan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant