Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote DOCS_PASSED_IN_1_14_0_WARNING to an error #208

Open
jklynch opened this issue Apr 7, 2021 · 1 comment
Open

promote DOCS_PASSED_IN_1_14_0_WARNING to an error #208

jklynch opened this issue Apr 7, 2021 · 1 comment

Comments

@jklynch
Copy link
Contributor

jklynch commented Apr 7, 2021

I would like to move away from the current assumption in RunRouter that exceptions from callback('start', start_doc) are the result of the change in 1.14.0 to explicitly send start documents to callbacks, for example here.

What is currently a warning could become an error, as threatened in the warning message.
@danielballan
Copy link
Member

I endorse making this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielballan @jklynch