Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent terms: run_start -- there is no such document #102

Open
prjemian opened this issue Aug 1, 2019 · 3 comments
Open

Use consistent terms: run_start -- there is no such document #102

prjemian opened this issue Aug 1, 2019 · 3 comments
Assignees

Comments

@prjemian
Copy link
Contributor

prjemian commented Aug 1, 2019

During review of PR #94, I raised this point

When this was all new to me, the two terms "Event Descriptor" and "descriptor" as a document schema did not jump out as being the same thing. Run Start/start and Run Stop/stop similar but somehow easier to grasp. Gradually, this struck home.

Is this the time to make this crystal clear for the neophytes? The [bluesky project applies new definitions to otherwise familiar terms and this] is daunting to new users.

The suggestion was to make a new PR which should be created after #94 is merged.

Expected Behavior

If there is a document schema such as start, it should be referred to consistently as such, not as run_start or Run Start. There is no run_start document.

Current Behavior

The documentation is inconsistent in how it refers to the various document types (schemas).

Possible Solution

Editing and revision through PR process. All the document types should be reviewed for consistent reference. The exact name of the document type should be used, such as run 'start' (rather than 'run_start').

Steps to Reproduce (for bugs)

n/a

Context

As stated, the inconsistent references to the same document schema created confusion and delay for me when this material was all new, when trying to write my first callback routine.

Seeing the revisions of PR #94 (especially when gathering the resource and datum descriptions with the others) gave me the idea this was the time to note the inconsistent handling.

Your Environment

n/a

@prjemian prjemian self-assigned this Aug 1, 2019
@danielballan
Copy link
Member

This is valuable feedback. I am favor of making this change. In any place where we are writing code or naming files we should use 'start' and 'descriptor' consistently. I am still in favor of using the full names like Event Descriptor document and Run Start document in narrative text. Not sure where @prjemian lands on that point.

@prjemian
Copy link
Contributor Author

prjemian commented Aug 1, 2019 via email

@danielballan
Copy link
Member

Great, we're exactly on the same page then. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants