Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with '%' character in path #242

Open
dlaflamme opened this issue Mar 7, 2022 · 0 comments
Open

issues with '%' character in path #242

dlaflamme opened this issue Mar 7, 2022 · 0 comments

Comments

@dlaflamme
Copy link

I am having issues when the source or target s3 path contains a '%' character. Specifically, the error I am seeing is:

"TypeError: not enough arguments for format string"

I no longer have the full stack trace, but this is happening when message() is called with a single string argument that contains '%' (that are legitimately part of the source or target file path) and with no additional arguments.

This issue was mentioned in issue #33 from 2016. The comment before that issue was closed correctly indicated that the problem was the use of call sites that "call message(str) instead of message('%s', str)" However there appears to still be calls to message(str) in the latest code. One example is:

s4cmd/s4cmd.py

Line 1463 in 7191685

message('%s => %s' % (source, target))

Would you prefer to confirm and fix this throughout the codebase or should I open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant