Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure we are not violating DRY #7

Open
andirdju opened this issue Feb 22, 2018 · 3 comments
Open

make sure we are not violating DRY #7

andirdju opened this issue Feb 22, 2018 · 3 comments

Comments

@andirdju
Copy link
Member

hope no other library already exists for these things, like in apache commons , guava, jodatime, lombok, etc.

if there are better use them, or contribute to them instead.

@bunthatcodes
Copy link
Contributor

bunthatcodes commented Feb 26, 2018

i have not checked every method but several basic methods should already be available in other libraries, such as CollectionHelper.isEmpty, but other methods may have different implementation, such as CollectionHelper.addToList vs Apache's CollectionUtils,addAll

Creating our own libraries gives us more control to define what a particular method should do or return, imo. Should we wrap other libraries and base similar/same methods on top of those libraries? Although this will result in added dependency to those libraries for the clients that use this library.

@andirdju
Copy link
Member Author

what is the cons of having our own library?

@bunthatcodes
Copy link
Contributor

imo we have more control over the implementation and our developers would be able to get all helpers in one place and not have to deal with multiple libraries from multiple 3rd parties (figuring out which library is located in which 3rd party class)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants