{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":272700405,"defaultBranch":"master","name":"gui","ownerLogin":"bitcoin-core","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-06-16T12:20:07.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13464320?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1621257589.5340319","currentOid":""},"activityList":{"items":[{"before":"18d4c43cab4a043358de4effa80a6adfc639c620","after":"d812cf11896a2214467b6fa72d7b763bac6077c5","ref":"refs/heads/master","pushedAt":"2024-09-27T10:17:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30879: test: re-bucket long-running tests\n\nf5a2000579b140a1f51fc433706c775ca560c62c test: re-bucket long-running tests (willcl-ark)\n\nPull request description:\n\n Re-bucket:\n\n - `p2p_node_network_limited -v*transport`\n - `feature_assume_utxo`\n\n On CI runners these tests are taking longer than their current bucket suggests, often being among the last to finish.\n\n Re-bucket them to improve CI efficiency.\n\nACKs for top commit:\n maflcko:\n review ACK f5a2000579b140a1f51fc433706c775ca560c62c\n\nTree-SHA512: 3da5c888db64a311276338270ba1dcad3eb2a24e205f6bb86fc92f767ecfa63682f13fafffff569fa0cfaea607ccb538f31e3934a086d482c3fe1be5d39f8791","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30879: test: re-bucket long-running tests"}},{"before":"d7fcc91416a5a0eacf0af5236dfa56a9f1e81b0d","after":"18d4c43cab4a043358de4effa80a6adfc639c620","ref":"refs/heads/master","pushedAt":"2024-09-27T09:57:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30921: test: generalize HasReason and use it in FailFmtWithError\n\n6c3c619b35cc03e883f9d2b3326f906aedde9ba7 test: generalize HasReason and use it in FailFmtWithError (Lőrinc)\n\nPull request description:\n\n Standardized boost exception checking in recent tests introduced in https://github.com/bitcoin/bitcoin/pull/30546#discussion_r1756493521 by extending `HasReason` to accept `const char*` through `string_view` in `operator()`.\n\n Note that `HasReason` only checks partial matches - but since we're specifying the whole error string, it doesn't affect us in this case.\n\nACKs for top commit:\n maflcko:\n review ACK 6c3c619b35cc03e883f9d2b3326f906aedde9ba7\n hodlinator:\n ACK 6c3c619b35cc03e883f9d2b3326f906aedde9ba7\n\nTree-SHA512: 740fb18b8fea78e4eb9740ceb0fe75d37246c28cfa2638b9d093e9514dd6d7926cc5be9ec57f8027cca3aa9d616e8c54322d2401cfa67fd25282f7816e63532d","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30921: test: generalize HasReason and use it in…"}},{"before":"29d00a1cee17bd5fdb7fbf6402f130c6e2e5b64d","after":"d7fcc91416a5a0eacf0af5236dfa56a9f1e81b0d","ref":"refs/heads/master","pushedAt":"2024-09-27T09:47:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30974: ci: Inline PACKAGE_MANAGER_INSTALL\n\nfafd1a0f648fcd602166d01d47da417b0eb380df ci: Inline PACKAGE_MANAGER_INSTALL (MarcoFalke)\n\nPull request description:\n\n The fallback `bash -c \"$PACKAGE_MANAGER_INSTALL git\"` is only needed by the `lint` task, so simplify it and inline `PACKAGE_MANAGER_INSTALL` once. Also, fixup the docs to add some other packages which are needed by podman in user-mode.\n\nACKs for top commit:\n fanquake:\n ACK fafd1a0f648fcd602166d01d47da417b0eb380df\n\nTree-SHA512: e1665446d0fb5a2e8f2cb912117c7a42838c840199e7504a859b9155a13a2ff2e8606ac56689446f973fce02b00240041f071ebf00520778ed81eb1a01de6663","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30974: ci: Inline PACKAGE_MANAGER_INSTALL"}},{"before":"89a8e9b732fb01a47f962dbf2ecaab9fd3eb88e8","after":"29d00a1cee17bd5fdb7fbf6402f130c6e2e5b64d","ref":"refs/heads/master","pushedAt":"2024-09-27T09:45:39.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30940: depends: Fix build with `MULTIPROCESS=1` in Guix environment\n\n06b4c339e89e593d951a90cd2d1bce944acf3bf7 depends: Fix reproducibility when building with `MULTIPROCESS=1` (Hennadii Stepanov)\nd8e3afc3352a2742e9da1f777e026d1f051042ac depends: Fix build with `MULTIPROCESS=1` in Guix environment (Hennadii Stepanov)\n\nPull request description:\n\n In the Guix environment, `${BASEPREFIX}/${HOST}/native/bin` is added to the `PATH` environment variable:https://github.com/bitcoin/bitcoin/blob/33adc7521cc8bb24b941d959022b084002ba7c60/contrib/guix/libexec/build.sh#L233-L234\n\n This causes CMake to search for package configurations in the `native` subdirectory first.\n\n Explicitly specifying the top-priority search prefixes for the `Libmultiprocess` and `LibmultiprocessNative` packages resolves https://github.com/bitcoin/bitcoin/issues/30931.\n\n Can be tested on this [branch](https://github.com/hebasto/bitcoin/commits/240921-guix-mp.DEMO/) with an additional [commit](https://github.com/hebasto/bitcoin/commit/d8ec933456bc7e63306b9cb8aa51ad93e215dc51):\n ```\n $ uname -m\n x86_64\n $ env MULTIPROCESS=1 HOSTS=x86_64-linux-gnu ./contrib/guix/guix-build\n $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum\n 70d482a09099931345888a918df5ccc78a0c742b1d18bb8a5d442af9b2717867 guix-build-d8ec933456bc/output/dist-archive/bitcoin-d8ec933456bc.tar.gz\n ea9465517c0e1cc559a6a353f404b2bf47447332c918b69410dc51b6c4fbdedc guix-build-d8ec933456bc/output/x86_64-linux-gnu/SHA256SUMS.part\n f83a296139d0757abc47d053b8fddebc6d2ccc36dabea9b2d52883d23ba923bb guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu-debug.tar.gz\n 81aed48bece8d9bf5327530763c17d73dd66d5a3c666cbaf9381c03d4a660845 guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu.tar.gz\n ```\n ```\n $ uname -m\n aarch64\n $ env MULTIPROCESS=1 HOSTS=x86_64-linux-gnu ./contrib/guix/guix-build\n $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum\n 70d482a09099931345888a918df5ccc78a0c742b1d18bb8a5d442af9b2717867 guix-build-d8ec933456bc/output/dist-archive/bitcoin-d8ec933456bc.tar.gz\n ea9465517c0e1cc559a6a353f404b2bf47447332c918b69410dc51b6c4fbdedc guix-build-d8ec933456bc/output/x86_64-linux-gnu/SHA256SUMS.part\n f83a296139d0757abc47d053b8fddebc6d2ccc36dabea9b2d52883d23ba923bb guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu-debug.tar.gz\n 81aed48bece8d9bf5327530763c17d73dd66d5a3c666cbaf9381c03d4a660845 guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu.tar.gz\n ```\n\nACKs for top commit:\n ryanofsky:\n Code review ACK 06b4c339e89e593d951a90cd2d1bce944acf3bf7\n fanquake:\n ACK 06b4c339e89e593d951a90cd2d1bce944acf3bf7\n\nTree-SHA512: b219ff29723bf571784af11b8d41fdc0f3fe7e21a87493909f9fcc695e37f9dbf2f6eb0fda172a1e0060dec4d2aeaa7017b1078c0ea0040cabfbbe3e8a352c6b","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30940: depends: Fix build with MULTIPROCESS=1…"}},{"before":"36ad9516dbd6c0ff533251a4c3252cc24b192e73","after":"89a8e9b732fb01a47f962dbf2ecaab9fd3eb88e8","ref":"refs/heads/master","pushedAt":"2024-09-27T08:58:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30979: contrib: Update asmap link in seeds readme\n\nf158993fd5575d3cbf991b6df7bcd2af7cf96c9a contrib: Update asmap link in seeds readme (Fabian Jahr)\n\nPull request description:\n\n I am moving all my ASMap related repositories to an asmap org. While there is a redirect in place that works for now, GitHub doesn't guarantee that it will keep working in the long term. So we should still fix the links.\n\nACKs for top commit:\n laanwj:\n ACK f158993fd5575d3cbf991b6df7bcd2af7cf96c9a\n jarolrod:\n ACK f158993fd5575d3cbf991b6df7bcd2af7cf96c9a\n brunoerg:\n ACK f158993fd5575d3cbf991b6df7bcd2af7cf96c9a\n\nTree-SHA512: c6f831b6ed1b520a38623a7d29c01677a45bf06fea77f4da6b421dd16e630836c9abf8191330e3887232fd688edca534067142d37d7e504a1a785ae451b11721","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30979: contrib: Update asmap link in seeds readme"}},{"before":"fa7c2838a5f3693c6831b29a9c849a66506d1663","after":"36ad9516dbd6c0ff533251a4c3252cc24b192e73","ref":"refs/heads/master","pushedAt":"2024-09-26T15:51:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30981: ci: add timestamps to cirrus jobs\n\nf951f1fab258f782a88bb006b5ae4ea486705388 ci: add timestamps to cirrus jobs (willcl-ark)\n\nPull request description:\n\n Currently, debugging where time is spent in the cirrus jobs feels annoying, e.g. trying to see where time may be spent in https://github.com/bitcoin/bitcoin/issues/30969\n\n Enable timestamps in the logs for more information.\n\nACKs for top commit:\n maflcko:\n review ACK f951f1fab258f782a88bb006b5ae4ea486705388\n tdb3:\n Code Review ACK f951f1fab258f782a88bb006b5ae4ea486705388\n hebasto:\n ACK f951f1fab258f782a88bb006b5ae4ea486705388.\n\nTree-SHA512: 4ca6c3722013323e794339c39af3041a519e3ecf75216093c4ca99668c0932fe41cc547819f742a3e8a47709ec6baec976c542eb3848c0248f439841110a4e85","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30981: ci: add timestamps to cirrus jobs"}},{"before":"d5af7d28f475c0e579629a9b432c2b8a35075048","after":"fa7c2838a5f3693c6831b29a9c849a66506d1663","ref":"refs/heads/master","pushedAt":"2024-09-26T15:37:07.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30948: test: Add missing sync_mempools() to fill_mempool()\n\nfaf801515f8fcd11a3454105cab66c38f6f240fe test: Add missing sync_mempools() to fill_mempool() (MarcoFalke)\nfa48be6f0233cfbd5c1eab7b832c913912062fa5 test: Refactor fill_mempool to extract send_batch helper (MarcoFalke)\n\nPull request description:\n\n Not doing the sync will lead to (intermittent) issues, as explained in https://github.com/bitcoin/bitcoin/issues/30922#issuecomment-2364529013.\n\n Fix all issues by doing the sync by default and disable it in places that do not need the sync.\n\n Fixes #30922\n\nACKs for top commit:\n mzumsande:\n Tested ACK faf801515f8fcd11a3454105cab66c38f6f240fe\n ismaelsadeeq:\n Tested ACK faf801515f8fcd11a3454105cab66c38f6f240fe\n marcofleon:\n Tested ACK faf801515f8fcd11a3454105cab66c38f6f240fe\n\nTree-SHA512: 2de62d168cbb6857a9fb8bc12c42a9093fedf5e9beb6f83a32b3fa72a5ba3cf03631055fd25ef553399a27a6fe0d71c44cfe60660a4d31986debd13b8ab00228","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30948: test: Add missing sync_mempools() to fil…"}},{"before":"e13da501db9e123ec56adfcb6f01b811445f9ce7","after":"d5af7d28f475c0e579629a9b432c2b8a35075048","ref":"refs/heads/master","pushedAt":"2024-09-26T11:23:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30976: depends, doc: Drop package-specific note about CMake\n\n4cf84b344dea4696de540a0f053aa1ec560ac38c depends, doc: No need to specify general requirement (Hennadii Stepanov)\n\nPull request description:\n\n CMake is no longer required solely for `libmultiprocess`.\n\nACKs for top commit:\n maflcko:\n review ACK 4cf84b344dea4696de540a0f053aa1ec560ac38c\n\nTree-SHA512: 014808ef523d6f0101aaa52a1858bebc16da9eb44664beb204e271b033c4dfa48115ce85c4ce5f151e82f90f83c64aaa25af73ef5a9b9b64953d2e07ff19633f","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30976: depends, doc: Drop package-specific note…"}},{"before":"513b7136c798e43899a2a3843e35b5696be2be29","after":"e13da501db9e123ec56adfcb6f01b811445f9ce7","ref":"refs/heads/master","pushedAt":"2024-09-26T10:26:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30973: doc: fix `loadtxoutset` example\n\n286725168ae0309e427b1204a0724a4ba7cbe860 doc: fix loadtxoutset example (fanquake)\n\nPull request description:\n\n The current order is incorrect:\n ```bash\n ./build/src/bitcoin-cli loadtxoutset -rpcclienttimeout=0 utxo-840000.dat\n error code: -1\n error message:\n loadtxoutset \"path\"\n ```\n\nACKs for top commit:\n maflcko:\n review ACK 286725168ae0309e427b1204a0724a4ba7cbe860\n theStack:\n ACK 286725168ae0309e427b1204a0724a4ba7cbe860\n BrandonOdiwuor:\n ACK 286725168ae0309e427b1204a0724a4ba7cbe860\n\nTree-SHA512: cc58b94ccdbf5b3925af1e9cbebbe5f1ed9d0ad1bad4c0d1acd2482b39edebb43a811576d3fb0dca66d2a98e13a8ffd7c9754fda62121beb674dee115f984346","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30973: doc: fix loadtxoutset example"}},{"before":"65f6e7078b17e6e73d74dfeb00159878099fee1e","after":"513b7136c798e43899a2a3843e35b5696be2be29","ref":"refs/heads/master","pushedAt":"2024-09-26T08:59:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30961: ci: add `LLVM_SYMBOLIZER_PATH` to Valgrind fuzz job\n\nc1832584bfd1b352095bc41a13ff17564e456d43 ci: add LLVM_SYMBOLIZER_PATH to Valgrind fuzz job (fanquake)\n\nPull request description:\n\n Otherwise:\n ```bash\n NEW_FUNC[1/23]: ==4710==WARNING: invalid path to external symbolizer!\n ==4710==WARNING: Failed to use and restart external symbolizer!\n 0xb72010 (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a010) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)\n NEW_FUNC[2/23]: 0xb72240 (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a240) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)\n\n ```\n\nACKs for top commit:\n maflcko:\n review ACK c1832584bfd1b352095bc41a13ff17564e456d43\n\nTree-SHA512: 73d042c7432edac63704912391351770648fe9aef3c6dabe05dfc0b52a84cc1c4a3f1a5f8e36854238abe6097f9e5d571e19060ed040c59f45fe97c432330b3b","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30961: ci: add LLVM_SYMBOLIZER_PATH to Valgri…"}},{"before":"da612cea032ba241e2d82418baf171b06e5f0142","after":"65f6e7078b17e6e73d74dfeb00159878099fee1e","ref":"refs/heads/master","pushedAt":"2024-09-25T20:39:17.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30510: multiprocess: Add IPC wrapper for Mining interface\n\n1a332817665f77f55090fa166930fec0e5500727 doc: multiprocess documentation improvements (Ryan Ofsky)\nd043950ba245cdcd09dc389a71d43b0a58e41a8b multiprocess: Add serialization code for BlockValidationState (Ryan Ofsky)\n33c2eee285e35db50b33efb6e782ff002f9d18ec multiprocess: Add IPC wrapper for Mining interface (Ryan Ofsky)\n06882f84017f6b569b46a644f39b6d3c120ec6cf multiprocess: Add serialization code for vector (Russell Yanofsky)\n095286f790acda4a32f04c77aa86106007e2a0d8 multiprocess: Add serialization code for CTransaction (Russell Yanofsky)\n69dfeb18761cfd933b8a9a6e69ce9d3c516ba949 multiprocess: update common-types.h to use C++20 concepts (Ryan Ofsky)\n206c6e78eec7c71d317666a1af07acf357ba001e build: Make bitcoin_ipc_test depend on bitcoin_ipc (Ryan Ofsky)\n070e6a32d5ff4be2f4f1f6a8200fba2f61df16e3 depends: Update libmultiprocess library for cmake headers target (Ryan Ofsky)\n\nPull request description:\n\n Add Cap'n Proto wrapper for the Mining interface introduced in #30200, and its associated types.\n\n This PR combined with #30509 will allow a separate mining process, like the one being implemented in https://github.com/Sjors/bitcoin/pull/48, to connect to the node over IPC, and create, manage, and submit block templates. (#30437 shows another simpler demo of a process using the Mining interface.)\n\n ---\n\n This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/issues/28722).\n\nACKs for top commit:\n achow101:\n ACK 1a332817665f77f55090fa166930fec0e5500727\n TheCharlatan:\n ACK 1a332817665f77f55090fa166930fec0e5500727\n itornaza:\n ACK 1a332817665f77f55090fa166930fec0e5500727\n\nTree-SHA512: 0791078dd6885dbd81e3d14c75fffff3da8d1277873af379ea6f9633e910c11485bb324e4cde3d936d50d343b16a10b0e8fc1e0fc6d7bdca7f522211da50c01e","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30510: multiprocess: Add IPC wrapper for Mining…"}},{"before":"39219fe145e5e6e6f079b591e3f4b5fea8e71804","after":"da612cea032ba241e2d82418baf171b06e5f0142","ref":"refs/heads/master","pushedAt":"2024-09-25T18:33:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30962: validation: Disable CheckForkWarningConditions for background chainstate\n\nc0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee validation: Disable CheckForkWarningConditions for background chainstate (Martin Zumsande)\n\nPull request description:\n\n The comparison of `m_best_invalid` with the tip of the chainstate makes no sense for the background chainstate and can lead to incorrect log messages.\n\n Fixes #30958\n\nACKs for top commit:\n fjahr:\n utACK c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee\n achow101:\n ACK c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee\n TheCharlatan:\n ACK c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee\n tdb3:\n CR ACK c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee\n\nTree-SHA512: 316811b1ade8521681f3a105c7db59dfdb27b1e13efeba95cd6183d750db2e07f48968e8fc54fe3834d3311519cf8c6b77d7e0fd61facbf2b07598e79110ff85","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30962: validation: Disable CheckForkWarningCond…"}},{"before":"a9773b6215e1ee66203680ac7d0b2aae0d797f95","after":"39219fe145e5e6e6f079b591e3f4b5fea8e71804","ref":"refs/heads/master","pushedAt":"2024-09-25T11:22:02.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30946: doc: correct the zmq automatic build info\n\n06e7e83632985bd8b648d24f9a51591d3a3bbec3 doc: correct the zmq automatic build info (tdb3)\n\nPull request description:\n\n The current documentation states that the ZMQ feature is automatically included when building.\n Noticed this was no longer the case when building to review PR #30942.\n\nACKs for top commit:\n l0rinc:\n ACK 06e7e83632985bd8b648d24f9a51591d3a3bbec3\n hebasto:\n re-ACK 06e7e83632985bd8b648d24f9a51591d3a3bbec3.\n\nTree-SHA512: 24269c29415e54815b105e3f830f31f055e9bdcb3bf4a7cede068651875190adfc4e72ad5448b3c30a23b0db024f743d9f18576a6fda46d87deb5ea39352e626","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30946: doc: correct the zmq automatic build info"}},{"before":"393f323bd60b9d47be697820a7ddf075700a7273","after":"a9773b6215e1ee66203680ac7d0b2aae0d797f95","ref":"refs/heads/master","pushedAt":"2024-09-25T09:59:37.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30963: doc: Adjust links in OSS-Fuzz section\n\nfa6c1946d235c6ea5b9384d8488d80aa3bcd0ad7 doc: Adjust links in OSS-Fuzz section (MarcoFalke)\n\nPull request description:\n\n Adjust the links after the google issue tracker migration and replace the remaining paragraph with a link to https://bitcoincore.org/en/security-advisories/\n\nACKs for top commit:\n dergoegge:\n ACK fa6c1946d235c6ea5b9384d8488d80aa3bcd0ad7\n\nTree-SHA512: 4c3aba8bb5641756be5c66c2ee21b927a675622ddac021303f8196a1b2d8eb891406f6dedab0f04e12312339953c87302891df4ad5f5956c0b2ddd453452e1c9","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30963: doc: Adjust links in OSS-Fuzz section"}},{"before":"90a5786bba4baac1c0270e1f4bf5bb8c790e10de","after":"393f323bd60b9d47be697820a7ddf075700a7273","ref":"refs/heads/master","pushedAt":"2024-09-24T15:37:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30952: test: Use shell builtins in run_command test case\n\n7bd3ee62f6d6f59ca599e85f81776d282dee1539 test: Use shell builtins in run_command test case (Ava Chow)\n\nPull request description:\n\n Uses the [suggested command](https://github.com/bitcoin/bitcoin/issues/30938#issuecomment-2363906135)\n\n Fixes #30938\n\nACKs for top commit:\n maflcko:\n review ACK 7bd3ee62f6d6f59ca599e85f81776d282dee1539\n hebasto:\n ACK 7bd3ee62f6d6f59ca599e85f81776d282dee1539.\n\nTree-SHA512: 683b15cafaf0103eeadf872ea6ce9a7d884b2605d3dcf4e66b0173cdb149c24965e7c5fa62aaddf2ac55df3f449aeb787176992c96cfee5d0b86621259e1dfe9","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30952: test: Use shell builtins in run_command …"}},{"before":"dabc74e86c38e928b8506de20210f0bc49562d5c","after":"90a5786bba4baac1c0270e1f4bf5bb8c790e10de","ref":"refs/heads/master","pushedAt":"2024-09-23T20:03:11.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30678: wallet: Write best block to disk before backup\n\nf20fe33e94c6752e5d2ed92511c0bf51a10716ee test: Add basic balance coverage to wallet_assumeutxo.py (Fabian Jahr)\n037b101e808ccf9e717751619e04f6e87d614efd test: Add coverage for best block locator write in wallet_backup (Fabian Jahr)\n31c0df038909e40fe9618a4595254907ed1de907 wallet: migration, write best locator before unloading wallet (furszy)\n7e3dbe4180cbeb65e59b53d9fa98509e9189549d wallet: Write best block to disk before backup (Fabian Jahr)\n\nPull request description:\n\n I discovered that we don't write the best block to disk when trying to explain the behavior described here: https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1719951882\n\n In the context of that test, the behavior is confusing and I think it also shows that one of the already existing tests in `wallet_assumeutxo.py` doesn't actually test what it says. It only fails because the best block isn't written and actually, the height of the backup that is loaded is at the snapshot height during backup. So it really shouldn't fail since it's past the background sync blocks already.\n\n I'm not sure if this is super relevant in practice though so I am first looking for concept ACKs on the `BackupWallet` code change. Either way, I think this behavior should be documented better if it is left as is and the test should be changed.\n\nACKs for top commit:\n achow101:\n ACK f20fe33e94c6752e5d2ed92511c0bf51a10716ee\n furszy:\n ACK f20fe33\n\nTree-SHA512: bb384a940df5c942fffe2eb06314ade4fc5d9b924012bfef3b1c456c4182a30825d1e137d8ae561d93d3a8a2f4d1c1ffe568132d20fa7d04844f1e289ab4a28b","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30678: wallet: Write best block to disk before …"}},{"before":"33adc7521cc8bb24b941d959022b084002ba7c60","after":"dabc74e86c38e928b8506de20210f0bc49562d5c","ref":"refs/heads/master","pushedAt":"2024-09-23T19:40:50.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30409: Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block\n\n7942951e3fcc58f7db0059546d03be9ea243f1db Remove unused g_best_block (Ryan Ofsky)\ne3a560ca68d79b056a105a65ed0c174a9631aba9 rpc: use waitTipChanged for longpoll (Ryan Ofsky)\n460687a09c2af336fce853d9ffb790d01429eec6 Remove unused CRPCSignals (Sjors Provoost)\ndca923150e3ac10a57c23a7e29e76516d32ec10d Replace RPCNotifyBlockChange with waitTipChanged() (Sjors Provoost)\n2a40ee1121903847cdd3f6c5b4796e4d5471b2df rpc: check for negative timeout arg in waitfor* (Sjors Provoost)\nde7c855b3af99fe6b62279c5c2d08888a5437c4a rpc: recommend -rpcclienttimeout=0 for waitfor* (Sjors Provoost)\n77ec072925a6d558b3c6b075becbed44727c5989 rpc: fix waitfornewblock description (Sjors Provoost)\n285fe9fb51c808a9edd91b05bd3134fc18de0fb6 rpc: add test for waitforblock and waitfornewblock (Sjors Provoost)\nb94b27cf05c709674117e308e441a8d1efddcd0a Add waitTipChanged to Mining interface (Sjors Provoost)\n7eccdaf16081d6f624c4dc21df75b0474e049d2b node: Track last block that received a blockTip notification (Sjors Provoost)\nebb8215f23644f901c46fd4977b7d4b08fae5104 Rename getTipHash() to getTip() and return BlockRef (Sjors Provoost)\n89a8f74bbbb900abfb3d8e946eea18ad7b1513ad refactor: rename BlockKey to BlockRef (Sjors Provoost)\n\nPull request description:\n\n This continues the work in #30200 so that a future Stratum v2 Template Provider (see #29432) can avoid accessing node internals. It needs to know when a new block arrives in order to push new templates to connected clients.\n\n `waitTipChanged()` uses a new kernel notification `notifications().m_tip_block_mutex`, which this PR also introduces (a previous version used `g_best_block`).\n\n In order to ensure the new method works as intended, the `waitfornewblock`, `waitforblock` and `waitforblockheight` RPC methods are refactored to use it. This allows removing `RPCNotifyBlockChange`.\n\n There's a commit to add (direct) tests for the methods that are about to be refactored:\n - `waitfornewblock` was already implicitly tested by `feature_shutdown.py`.\n - `waitforblockheight` by `feature_coinstatsindex.py` and `example_test.py`\n\n This PR renames `getTipHash()` to `getTip()` and returns a `BlockRef` (renamed from `BlockKey`) so that callers can use either the height or hash.\n\n The later commits make trivial improvements to the `waitfor*` RPC calls (not needed for this PR).\n\n The `waitTipChanged()` method could probably also be used for the longpoll functionality in `getblocktemplate`, but I'm a bit reluctant to touch that.\n\n `RPCServer::OnStarted` no longer does anything and `RPCServer::OnStopped` merely prints a log statement. They were added in #5711 as a refactor. This PR drops them entirely.\n\n Finally `g_best_block` is also dropped.\n\nACKs for top commit:\n achow101:\n ACK 7942951e3fcc58f7db0059546d03be9ea243f1db\n ryanofsky:\n Code review ACK 7942951e3fcc58f7db0059546d03be9ea243f1db. Just rebased since last review\n TheCharlatan:\n Re-ACK 7942951e3fcc58f7db0059546d03be9ea243f1db\n\nTree-SHA512: a5559446b4000c95e07aad33284b7ee2e57aafd87e1ae778b3825d59689566d047a8047e47a10f76e6e341e7dc72fd265a65afbc0a9c011d17c4cafd55031837","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30409: Introduce waitTipChanged() mining interf…"}},{"before":"0894748316c5483063ceb6c3cd76d32febac35e9","after":"33adc7521cc8bb24b941d959022b084002ba7c60","ref":"refs/heads/master","pushedAt":"2024-09-20T19:17:00.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30765: refactor: Allow `CScript`'s `operator<<` to accept spans, not just vectors\n\n5e190cd11f6ed8b7ab4db0f01192de63deaf6fd7 Replace CScript _hex_v_u8 appends with _hex (Lőrinc)\ncac846c2fbf6fc69bfc288fd387aa3f68d84d584 Allow CScript's operator<< to accept spans, not just vectors (Lőrinc)\nc78d8ff4cb83506413bb73833fc5c04885d0ece8 prevector: avoid GCC bogus warnings in insert method (Lőrinc)\n\nPull request description:\n\n Split out of https://github.com/bitcoin/bitcoin/pull/30377#discussion_r1722326803.\n\n Replace `_hex_v_u8` for `CScript` appends to `_hex`, to skip vector conversion before serializing to the `prevector` in `CScript`.\n\n To enable both `unsigned char` and `std::byte` values, I've extracted the existing serialization to append the size & data in separate private methods to clarify that it does more than just a simple data insertion.\n\n There were also discussion on eliminating the operators here completely to obviate when we're serializing fixed-size collections as raw bytes, and when we're prefixing them with their size - should also be done in a separate PR.\n\nACKs for top commit:\n achow101:\n ACK 5e190cd11f6ed8b7ab4db0f01192de63deaf6fd7\n ryanofsky:\n Code review ACK 5e190cd11f6ed8b7ab4db0f01192de63deaf6fd7. Looks good!\n hodlinator:\n re-ACK 5e190cd11f6ed8b7ab4db0f01192de63deaf6fd7\n\nTree-SHA512: 27a646629e017b2a05416d5eb964dda8b25b900d466221eff7bfa1339ded443e1c5c4cf8ff20cb3bba915a2603787a9fa6f6ec12bc0b9415d9eb07b57289192b","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30765: refactor: Allow CScript's operator<<…"}},{"before":"f57a6754ed6a9b0d11e03189aa808d8376ce51b6","after":"0894748316c5483063ceb6c3cd76d32febac35e9","ref":"refs/heads/master","pushedAt":"2024-09-20T18:35:14.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30918: fuzz: Add check in `p2p_headers_presync` that chain work never exceeds minimum work\n\n284bd17309ab3b124d9dcddfec62f5506383343b add check that chainwork doesn't exceed minimum work (marcofleon)\n9aa5d1c3fcd10ecb94310ad515a8569bc2d418f8 add clarification in comment (marcofleon)\n\nPull request description:\n\n A followup to https://github.com/bitcoin/bitcoin/pull/30661\n\n The added assertion just makes sure that the fuzz test is working as intended. If we're sure that the total work of the test chain is never more than minimum chain work, then we can be sure that the later assertion failure would actually mean that a bug in the headers presync logic was found.\n\n This PR also addresses:\n https://github.com/bitcoin/bitcoin/pull/30661#discussion_r1746614616\n https://github.com/bitcoin/bitcoin/pull/30661#discussion_r1764943665\n https://github.com/bitcoin/bitcoin/pull/30661#discussion_r1764961991\n\nACKs for top commit:\n instagibbs:\n reACK 284bd17309ab3b124d9dcddfec62f5506383343b\n maflcko:\n review ACK 284bd17309ab3b124d9dcddfec62f5506383343b\n achow101:\n ACK 284bd17309ab3b124d9dcddfec62f5506383343b\n\nTree-SHA512: 76a9dffea4b6e13499c636d6ad26af06135319d25117c0eb40cf8dfcfdca6a4549c9b4d2ba835192ca355e0f8d476227aeabf8bdb68770def72a9fb521533fe5","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30918: fuzz: Add check in p2p_headers_presync…"}},{"before":"48c20dbd86c29e7102a9ece016159f126c586de6","after":"f57a6754ed6a9b0d11e03189aa808d8376ce51b6","ref":"refs/heads/master","pushedAt":"2024-09-20T17:55:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30826: fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target\n\nf482d0e366a84008129913b442f0c955de79ac93 fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target (brunoerg)\n\nPull request description:\n\n By reducing the number of iterations we improve the performance of this target and may increase coverage.\n\n Running with `-runs=100000` from qa-assets I noticed a significant performance improvement and an increase on cov:\n master:\n ```\n #100000 DONE cov: 567 ft: 4078 corp: 124/33Kb lim: 4096 exec/s: 793 rss: 499Mb\n ```\n\n PR:\n ```\n #100000 DONE cov: 568 ft: 3833 corp: 113/15188b lim: 1746 exec/s: 1250 rss: 544Mb\n ```\n\nACKs for top commit:\n achow101:\n ACK f482d0e366a84008129913b442f0c955de79ac93\n marcofleon:\n Tested ACK f482d0e366a84008129913b442f0c955de79ac93. Saw the same slight increase in coverage. Executed 100,000 runs several times and total time went from 30-35 sec to 20-25 sec.\n stratospher:\n ACK f482d0e. saw similar coverage stats\n\nTree-SHA512: 1a96dbc22a0aed396b7f8cc9b13534b7f20a461f64f167c69c650529d535e360499f1a501abc1f957f7541ee1860b36a5580aa488a1edbfa0270c9ed83ef741d","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30826: fuzz: reduce number of iterations in `cr…"}},{"before":"4148e60909e135dd4a728527ca94e9f5505c9ef8","after":"48c20dbd86c29e7102a9ece016159f126c586de6","ref":"refs/heads/master","pushedAt":"2024-09-20T17:42:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30794: interpreter: use int32_t instead of int type for risczero compile\n\nbc52cda1f3c007bdf1ed00aa3011e207c7531017 fix use int32_t instead of int type for risczero compile with (-march=rv32i, -mabi=ilp32) (Simon)\n\nPull request description:\n\n When compile bitcoin by the toolchain(`riscv32-unknown-elf-g++`) from risc0 , the compiler argument is `-march=rv32i, -mabi=ilp32`, which will get the error which due to not serialize the value of type int .\n\n ```\n blockbody-guest: cargo:warning=In file included from depend/bitcoin/src/hash.h:14,\n blockbody-guest: cargo:warning= from depend/bitcoin/src/script/interpreter.h:9,\n blockbody-guest: cargo:warning= from depend/bitcoin/src/script/interpreter.cpp:6:\n blockbody-guest: cargo:warning=depend/bitcoin/src/serialize.h: In instantiation of 'void Serialize(Stream&, const T&) [with Stream = HashWriter; T = int]':\n blockbody-guest: cargo:warning=depend/bitcoin/src/hash.h:144:20: required from 'HashWriter& HashWriter::operator<<(const T&) [with T = int]'\n blockbody-guest: cargo:warning=depend/bitcoin/src/script/interpreter.cpp:1613:12: required from 'uint256 SignatureHash(const CScript&, const T&, unsigned int, int, const CAmount&, SigVersion, const PrecomputedTransactionData*) [with T = CTransaction; CAmount = long long int]'\n blockbody-guest: cargo:warning=depend/bitcoin/src/script/interpreter.cpp:1664:36: required from 'bool GenericTransactionSignatureChecker::CheckECDSASignature(const std::vector&, const std::vector&, const CScript&, SigVersion) const [with T = CTransaction]'\n blockbody-guest: cargo:warning=depend/bitcoin/src/script/interpreter.cpp:1785:16: required from here\n blockbody-guest: cargo:warning=depend/bitcoin/src/serialize.h:776:7: error: request for member 'Serialize' in 'a', which is of non-class type 'const int'\n blockbody-guest: cargo:warning= 776 | a.Serialize(os);\n ```\n\n --------------\n\n ### Reason\n\n \"The toolchain from RISC Zero defines int and int32_t as different types, although they have the same width. This means that `src/compat/assumptions.h` compiles fine; however, the templated serialization code cannot accept values of type int. Fix the compilation on RISC Zero by serializing int32_t instead of int values.\n\n This patch will explicitly use the `int32_t` type instead of `int` to avoid errors when compiling with the risc0 toolchain. Additionally, this patch will not change any behavior on platforms where compilation was previously successful.\n\n Fixes #30747\n\nACKs for top commit:\n maflcko:\n review-only ACK bc52cda1f3c007bdf1ed00aa3011e207c7531017\n achow101:\n ACK bc52cda1f3c007bdf1ed00aa3011e207c7531017\n TheCharlatan:\n ACK bc52cda1f3c007bdf1ed00aa3011e207c7531017\n\nTree-SHA512: ef880e7dfa1335bf2704ab17c0f506f17390b8259755674dfcd57131736492b2f4cfc36babda6902202b7c55a7513991e21f6634b0cd9b2b03baf4f1c0f8d78b","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30794: interpreter: use int32_t instead of int …"}},{"before":"a8a2628b7a963d348b7b52bf1a09d1f0712de442","after":"4148e60909e135dd4a728527ca94e9f5505c9ef8","ref":"refs/heads/master","pushedAt":"2024-09-20T17:34:31.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30679: fix: handle invalid `-rpcbind` port earlier\n\ne6994efe08b282dd9e46602bcbad69567fe91dcd fix: increase rpcbind check robustness (tdb3)\nd38e3aed89eea665399eef07f5c3b64b14d4f586 fix: handle invalid rpcbind port earlier (tdb3)\n83b67f2e6d59ea5de6573314ea4fe54ae52b7c12 refactor: move host/port checking (tdb3)\n73c243965ab256ece089d14173c2d285955e83d5 test: add tests for invalid rpcbind ports (tdb3)\n\nPull request description:\n\n Previously, when an invalid port was specified in `-rpcbind`, the `SplitHostPort()` return value in `HTTPBindAddresses()` was ignored and attempt would be made to bind to the default rpcbind port (with the host/port treated as a host).\n\n This rearranges port checking code in `AppInitMain()` to handle the invalid port before reaching `HTTPBindAddresses()`. Also adds a check in `HTTPBindAddresses()` as a defensive measure for future changes.\n\n Adds then updates associated functional tests as well.\n\nACKs for top commit:\n achow101:\n ACK e6994efe08b282dd9e46602bcbad69567fe91dcd\n ryanofsky:\n Code review ACK e6994efe08b282dd9e46602bcbad69567fe91dcd\n zaidmstrr:\n Code review ACK [e6994ef](https://github.com/bitcoin/bitcoin/commit/e6994efe08b282dd9e46602bcbad69567fe91dcd)\n\nTree-SHA512: bcc3e5ceef21963821cd16ce6ecb83d5c5657755882c05872a7cfe661a1492b1d631f54de22f41fdd173512d62dd15dc37e394fe1a7abe4de484b82cd2438b92","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30679: fix: handle invalid -rpcbind port earlier"}},{"before":"0d81b3ddedc73daf934242885c60f05f812ac275","after":"a8a2628b7a963d348b7b52bf1a09d1f0712de442","ref":"refs/heads/master","pushedAt":"2024-09-20T17:26:46.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30828: interfaces: #30697 follow ups\n\n84663291275248fd52da644b0c2566bbf9cc780b chain: simplify `deleteRwSettings` code and improve it's doc (ismaelsadeeq)\nf8d91f49c7091102138fcb123850399e8fadfbc7 chain: dont check for null settings value in `overwriteRwSetting` (ismaelsadeeq)\ndf601993f2d7454f081316d6a8ddefbcefa49b3d chain: ensure `updateRwSetting` doesn't update to a null settings (ismaelsadeeq)\nc8e2eeeffb494d99d95c1c45efeda5a98dce94cd chain: uniformly use `SettingsAction` enum in settings methods (ismaelsadeeq)\n1e9e735670f029c975d3b7486a54e5bb67135df7 chain: move new settings safely in `overwriteRwSetting` (ismaelsadeeq)\n1c409004c80bc5f2314e20cc922076e22931cf73 test: remove wallet context from `write_wallet_settings_concurrently` (ismaelsadeeq)\n\nPull request description:\n\n This PR addresses the remaining review comments from #30697\n\n 1. Disallowed overwriting settings values with a `null` value.\n 2. Uniformly used the `SettingsAction` enum in all settings methods instead of a boolean parameter.\n 3. Updated `overwriteRwSetting` to receive the `common::SettingsValue` parameter by value, enabling it to be moved safely.\n 4. Removed wallet context from the `write_wallet_settings_concurrently` unit test, as it is not needed.\n\nACKs for top commit:\n achow101:\n ACK 84663291275248fd52da644b0c2566bbf9cc780b\n ryanofsky:\n Code review ACK 84663291275248fd52da644b0c2566bbf9cc780b. Looks good, thanks for taking suggestions and applying them to the right commits. Only changes since last review were documentation improvements and simplifying delete method.\n furszy:\n Code review ACK 84663291275248fd52da644b0c2566bbf9cc780b\n\nTree-SHA512: baf2f59ed5aac4a4bda0c84fb6554a466a40d1f7b52b61dc2ff293d83ae60e82b925b7003237b633fecb65eba3a4c108e69166046895d1295809fbe0de67b052","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30828: interfaces: #30697 follow ups"}},{"before":"c985a34b9c3246888a4fc05519f1f025a5c62422","after":"0d81b3ddedc73daf934242885c60f05f812ac275","ref":"refs/heads/master","pushedAt":"2024-09-20T16:55:29.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t\n\n51f7668d31e2624e41c7ce77fe33162802808f3f addrman: change nid_type from int to int64_t (Martin Zumsande)\n051ba3290e30e210bfc50dea974063053313ad3e addrman, refactor: introduce user-defined type for internal nId (Martin Zumsande)\n\nPull request description:\n\n With `nIdCount` being incremented for each addr received, an attacker could cause an overflow in the past, see https://bitcoincore.org/en/2024/07/31/disclose-addrman-int-overflow/\n Even though that attack was made infeasible indirectly by addr rate-limiting (PR #22387), to be on the safe side and prevent any regressions change the `nId`s used internally to `int64_t`.\n This is being done by first introducing a user-defined type for `nId`s in the first commit, and then updating it to `int64_t` (thanks sipa for help with this!).\n\n Note that `nId` is only used internally, it is not part of the serialization, so `peers.dat` should not be affected by this.\n\n I assume that the only reason this was not done in the past is to not draw attention to this previously undisclosed issue.\n\nACKs for top commit:\n naumenkogs:\n ACK 51f7668d31e2624e41c7ce77fe33162802808f3f\n stratospher:\n ACK 51f7668d31e2624e41c7ce77fe33162802808f3f. I think it's a good change to make the nId space large(64 bits) so that the nId values are distinct.\n achow101:\n ACK 51f7668d31e2624e41c7ce77fe33162802808f3f\n\nTree-SHA512: 68d4b8b0269a01a9544bedfa7c1348ffde00a288537e4c8bf2b88372ac7d96c4566a44dd6b06285f2fcf31b4f9336761e3bca7253fbc20db5e0d04e887156224","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30568: addrman: change internal id counting to …"}},{"before":"79f20fa1b1ec1a0c7fc0017f3d0e15aad75a7658","after":"c985a34b9c3246888a4fc05519f1f025a5c62422","ref":"refs/heads/master","pushedAt":"2024-09-20T16:00:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#26990: cli: Improve error message on multiwallet cli-side commands\n\n54227e681a4efa8961f1ad05d43366d88a9b686a rpc, cli: improve error message on multiwallet mode (pablomartin4btc)\n\nPull request description:\n\n Running a CLI command when multiple wallets are loaded and `-rpcwallet` is not specified, should return a clearer error.\n\n Currently in `master`:\n\n ```\n $ bitcoin-cli -regtest -generate 1\n error code: -19\n error message:\n Wallet file not specified (must request wallet RPC through /wallet/ uri-path).\n Try adding \"-rpcwallet=\" option to bitcoin-cli command line.\n ```\n\n With this change:\n\n ```\n $ bitcoin-cli -regtest -generate 1\n error code: -19\n error message:\n Multiple wallets are loaded. Please select which wallet to use by requesting the RPC through the /wallet/ URI path. Or for the CLI, specify the \"-rpcwallet=\" option before the command (run \"bitcoin-cli -h\" for help or \"bitcoin-cli listwallets\" to see which wallets are currently loaded).\n ```\n\nACKs for top commit:\n maflcko:\n review ACK 54227e681a4efa8961f1ad05d43366d88a9b686a\n achow101:\n ACK 54227e681a4efa8961f1ad05d43366d88a9b686a\n furszy:\n utACK 54227e681a4\n mzumsande:\n Code Review ACK 54227e681a4efa8961f1ad05d43366d88a9b686a\n jonatack:\n ACK 54227e681a4efa8961f1ad05d43366d88a9b686a\n\nTree-SHA512: 51ff24f64858aa6be6adf6f20105c9f076ebea743780bf2a4399f7fe8b5239cbb1ea06d32b2ef5e850da2369abb0ef7a52c50c2b8f31f4ca90d3a486abc9b77e","shortMessageHtmlLink":"Merge bitcoin/bitcoin#26990: cli: Improve error message on multiwalle…"}},{"before":"197aa249551ea7b2280b6e187d2ad5378687beff","after":"79f20fa1b1ec1a0c7fc0017f3d0e15aad75a7658","ref":"refs/heads/master","pushedAt":"2024-09-20T15:05:44.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30561: refactor: move `SignSignature` helpers to test utils\n\n58499b00d0ad1c83e433caa8fcc0e5d3fd3f2070 refactor: move `SignSignature` helpers to test utils (Sebastian Falbesoner)\n\nPull request description:\n\n These helpers haven't been used in production code since segwit was merged more than eight years ago (see commit 605e8473, PR #8149), so it seems appropriate to move them to the test utils module. As suggested by instagibbs, see https://github.com/bitcoin/bitcoin/pull/30352#discussion_r1697515508.\n\nACKs for top commit:\n instagibbs:\n ACK 58499b00d0ad1c83e433caa8fcc0e5d3fd3f2070\n pablomartin4btc:\n ACK 58499b00d0ad1c83e433caa8fcc0e5d3fd3f2070\n\nTree-SHA512: a52d3b92b477246f2ceb57c3690d0229a492b65a15dae331faeae9d96e5907f7fe1176edc1530243e0f088586984fd7ba435a0a2d2f2531c04d076fdf3f4095f","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30561: refactor: move SignSignature helpers t…"}},{"before":"84cd6478c422bc296589ab031f5c76e7bab2704d","after":"197aa249551ea7b2280b6e187d2ad5378687beff","ref":"refs/heads/master","pushedAt":"2024-09-20T09:59:25.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30856: build: drop obj/ subdirectory for generated build.h\n\n7025942687fd5e91d0a10ce5b2ac673b67a63491 build: drop superfluous `HAVE_BUILD_INFO` define (Sebastian Falbesoner)\n0dd662510c52b202f7136fbcb32ed3864b52b50b build: drop obj/ subdir for generated build.h, rename to bitcoin-build-info.h (Sebastian Falbesoner)\n\nPull request description:\n\n As indicated by the TODO, the obj subdirectory is not needed anymore now for the generated build.h header, since autotools are gone and we don't have in-source builds anymore (see #30454, #30664). In the second commit the superflous `HAVE_BUILD_INFO` macro is dropped, as suggested in https://github.com/bitcoin/bitcoin/pull/30856#pullrequestreview-2292424496.\n\nACKs for top commit:\n theuni:\n utACK 7025942687fd5e91d0a10ce5b2ac673b67a63491\n\nTree-SHA512: 0a3b2cbbcf638344ceb74e5ba5a0fe2b1718427b23a18c8890258db36ce7177006a146178ed88d9c5ae956a5426f3844e86c1f4cca7c40946359742bffda983b","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30856: build: drop obj/ subdirectory for genera…"}},{"before":"2db926f49c812a3f04a565834c841ce4bc4ae288","after":"84cd6478c422bc296589ab031f5c76e7bab2704d","ref":"refs/heads/master","pushedAt":"2024-09-19T15:44:05.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30927: Follow-up after AutoFile position caching: remove unused code\n\ncaac06f784c5d94c6a5f7d0b586f9ddbbe55c369 streams: reorder/document functions (Pieter Wuille)\n67a3d590768301fb46a93fdb0a5c66c0c2de1082 streams: remove unused code (Pieter Wuille)\n\nPull request description:\n\n This is a follow-up to #30884.\n\n Remove a number of dead code paths, and improve the code organization and documentation, in `AutoFile`.\n\nACKs for top commit:\n maflcko:\n re-ACK caac06f784c5d94c6a5f7d0b586f9ddbbe55c369\n theStack:\n Code-review ACK caac06f784c5d94c6a5f7d0b586f9ddbbe55c369\n l0rinc:\n ACK caac06f784c5d94c6a5f7d0b586f9ddbbe55c369\n tdb3:\n CR ACK caac06f784c5d94c6a5f7d0b586f9ddbbe55c369\n\nTree-SHA512: 297791f093e0142730f815c11dd3466b98f7e7edea86094a815dae989ef40d8056db10e0fed6e575d530903c18e80c08d36d3f1e6b828f2d955528f365b22008","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30927: Follow-up after AutoFile position cachin…"}},{"before":"9ba56884f625a84dea96912bee51a16b8949c5ba","after":"2db926f49c812a3f04a565834c841ce4bc4ae288","ref":"refs/heads/master","pushedAt":"2024-09-19T11:17:23.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30889: log: Use ConstevalFormatString\n\nfacbcd4cef8890ae18976fb53b67ea56b3c04454 log: Use ConstevalFormatString (MarcoFalke)\nfae9b60c4ffef38d9725f42f992b1f38765312a3 test: Use LogPrintStr to test m_log_sourcelocations (MarcoFalke)\nfa39b1ca63874db8ef8bc16b87e2699e8e1b67be doc: move-only logging warning (MarcoFalke)\n\nPull request description:\n\n This changes all logging (including the wallet logging) to produce a\n `ConstevalFormatString` at compile time, so that the format string can be\n validated at compile-time.\n\n I tested with `clang` and found that the compiler will use less than 1% more of time and memory.\n\n When an error is found, the compile-time error depends on the compiler, but it may look similar to:\n\n ```\n src/util/string.h: In function ‘int main(int, char**)’:\n src/bitcoind.cpp:265:5: in ‘constexpr’ expansion of ‘util::ConstevalFormatString<1>(((const char*)\"Hi %s %s\"))’\n src/util/string.h:38:98: in ‘constexpr’ expansion of ‘util::ConstevalFormatString<1>::Detail_CheckNumFormatSpecifiers(std::basic_string_view(((const char*)((util::ConstevalFormatString<1>*)this)->util::ConstevalFormatString<1>::fmt)))’\n src/util/string.h:78:34: error: expression ‘’ is not a constant expression\n 78 | if (num_params != count) throw \"Format specifier count must match the argument count!\";\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n ```\n\n This refactor does not change behavior of the compiled executables.\n\nACKs for top commit:\n hodlinator:\n re-ACK facbcd4cef8890ae18976fb53b67ea56b3c04454\n l0rinc:\n ACK facbcd4cef8890ae18976fb53b67ea56b3c04454\n ryanofsky:\n Code review ACK facbcd4cef8890ae18976fb53b67ea56b3c04454\n pablomartin4btc:\n re-ACK facbcd4cef8890ae18976fb53b67ea56b3c04454\n stickies-v:\n Approach ACK and code LGTM facbcd4cef8890ae18976fb53b67ea56b3c04454 modulo a `tinyformat::format_error` concern.\n\nTree-SHA512: 852f74d360897020f0d0f6e5064edc5e7f7dacc2bec1d5feff22c634a2fcd2eb535aa75be0b7191d9053728be6108484c737154b02d68ad3186a2e5544ba0db8","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30889: log: Use ConstevalFormatString"}},{"before":"ab0b5706b254ed914f94b41940a946d84ac8dd6d","after":"9ba56884f625a84dea96912bee51a16b8949c5ba","ref":"refs/heads/master","pushedAt":"2024-09-19T09:42:14.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30869: ci: Print inner env, Make ccache config more flexible\n\nfa99e4521b6fc0e7f6636d40bc0d6a7325227374 ci: Allow CCACHE_DIR bind mount (MarcoFalke)\nfa252da0b9cc6c7e795366ce4a1ddc4c198dff15 ci: Remove hardcoded CCACHE_DIR in cirrus (MarcoFalke)\nfa146904e19e345714fd40fd2f0fbad8118957b9 ci: Bump default CCACHE_MAXSIZE to 500M (MarcoFalke)\naaaa7cf8bad0e125a67e996162271eb26bef4fb6 cirrus: Drop CCACHE_NOHASHDIR (MarcoFalke)\nfa7ca182a9b0c65f567116b67108da14182e5338 ci: Print inner env (MarcoFalke)\n\nPull request description:\n\n The outer env is printed when the `/tmp/env-$USER-$CONTAINER_NAME` is created. There is also a separate env printed when building the container image (usually with default values).\n\n To confirm that the inner container env is correctly derived from the outer env, and not from the default build env, print it a third time.\n\nACKs for top commit:\n l0rinc:\n utACK fa99e4521b6fc0e7f6636d40bc0d6a7325227374\n willcl-ark:\n ACK fa99e4521b6fc0e7f6636d40bc0d6a7325227374\n\nTree-SHA512: 59fd3262d551e09224866e31c14ca865461e81abbe00b83391fe3a9c7ada30fd2fd0272e4aa812df2712433ac7594d1a55cf674248b341359cec09c8d3f0c58b","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30869: ci: Print inner env, Make ccache config …"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yN1QxMDoxNzo0OC4wMDAwMDBazwAAAATCduD-","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOVQwOTo0MjoxNC4wMDAwMDBazwAAAAS6qiVI"}},"title":"Activity · bitcoin-core/gui"}