Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bio::Tools::Run::Phylo::Phyml, tree_string #33

Open
cjfields opened this issue Oct 8, 2015 · 0 comments
Open

Bio::Tools::Run::Phylo::Phyml, tree_string #33

cjfields opened this issue Oct 8, 2015 · 0 comments

Comments

@cjfields
Copy link
Member

cjfields commented Oct 8, 2015


Author Name: Tristan Lefebure (Tristan Lefebure)
Original Redmine Issue: 3273, https://redmine.open-bio.org/issues/3273
Original Date: 2011-07-27
Original Assignee: Bioperl Guts


Hi there,
I am not quite sure I understand why tree_string() from Bio::Tools::Run::Phylo::Phyml returns
a string that looks like that (I removed the end of the tree):

BIONJ(((((((('92':0.0114354726,'12':0.0472591023)0.0000000000:0.0000005859,...

Why do we have this ‘BIONJ’ thing?

A quick look at the code in the _run() function gives :

       {
       open(my $FH_TREE, "<", $tree_file)
           || $self->throw("Phyml call ($command) did not give an output: $?");
       local $/;
       $self->{_tree} .= <$FH_TREE>;
   }

Why appending something to $self->{_tree}? What about just assigning the tree?

$self-\>{\_tree} = \<$FH\_TREE\>; 

I was about to fill a bug report, but then I saw that in Phyml.t:

   is substr($factory->tree_string, 0, 9), 'BIONJ(SIN', 'tree_string()';

Well, I am lost. Any help much appreciated…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant