Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lint): add noUselessUndefined #4100

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(lint): add noUselessUndefined #4100

wants to merge 4 commits into from
+1,292 −0

Conversation

unvalley
Copy link
Member

@unvalley unvalley commented Sep 26, 2024 •
edited
Loading

Summary

Closes #3942

TODO

  • : quick fix

Test Plan

Add snapshot tests

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels Sep 26, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 26, 2024

CodSpeed Performance Report

Merging #4100 will improve performances by 8.55%

Comparing unvalley:no-useless-undefined (ec8c5b4) with main (d20ad1e)

Summary

⚡ 2 improvements
✅ 105 untouched benchmarks

Benchmarks breakdown

Benchmark main unvalley:no-useless-undefined Change
⚡ router_17129688031671448157.ts[uncached] 2.5 ms 2.4 ms +6.54%
⚡ db_17847247775464589309.json[cached] 13.8 ms 12.8 ms +8.55%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Diagnostic Area: diagnostocis A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Implement noUselessUndefined - unicorn/no-useless-undefined
1 participant
@unvalley