Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated query feature range interval format #4083

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

blaze-d83
Copy link

@blaze-d83 blaze-d83 commented Sep 25, 2024

Summary

Resolving issue #4076 highlighted by @nstepien

  • I was able to pinpoint where the format originated from.
  • Added the missing space() which should implement the desired format

@github-actions github-actions bot added A-Formatter Area: formatter L-CSS Language: CSS A-Changelog Area: changelog labels Sep 25, 2024
@blaze-d83 blaze-d83 changed the title Query feature range interval format fix: Query feature range interval format Sep 25, 2024
@blaze-d83 blaze-d83 changed the title fix: Query feature range interval format fix: updated query feature range interval format Sep 25, 2024
Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #4083 will degrade performances by 6.18%

Comparing blaze-d83:query-feature-range-interval-format (db870c7) with main (cc4c867)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main blaze-d83:query-feature-range-interval-format Change
react.production.min_3378072959512366797.js[uncached] 2.1 ms 2.2 ms -6.18%

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test? Plus some snapshots changed, so you need to run the test suite and accept the new snapshots

@blaze-d83
Copy link
Author

@ematipico

Hey hi!

Can you help me with this?

image

I tried to run test for the biome_css_formatter crate, but there this issue which wont let me do it.

Thanks!

@dyc3
Copy link
Contributor

dyc3 commented Sep 26, 2024

@blaze-d83 Try cargo clean first to clear the build cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants