Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying notes on signups - possible privacy concerns #340

Closed
chadmohr opened this issue Apr 25, 2024 · 6 comments · Fixed by #358
Closed

Displaying notes on signups - possible privacy concerns #340

chadmohr opened this issue Apr 25, 2024 · 6 comments · Fixed by #358
Assignees

Comments

@chadmohr
Copy link
Member

chadmohr commented Apr 25, 2024

There are cases where names, contact info and even other personal info is put in notes. Basically, there could be anything in the notes. And these notes are displayed on desktops in the rider signups.

Untitled

@mveytsman
Copy link
Member

This is a good catch!

Based on the convo in slack we'll hide these before signup. Cecily also suggested splitting up rider notes and signup notes in the future

@chadmohr I went ahead and edited the image to block the phone number, do you mind doing that in the future if you're uploading screenshots with private info?

@chadmohr
Copy link
Member Author

Yes, for sure. This occurred to me after I posted.

@chadmohr
Copy link
Member Author

Also, somewhere in here I am 99% sure I also suggested a signup notes box in addition to the delivery notes

@sereprz
Copy link
Member

sereprz commented May 8, 2024

We're going to hide the column for now and revisit how to handle notes later on e.g. notes on signup VS notes on delivery

see discussion in #349

@chadmohr
Copy link
Member Author

chadmohr commented May 8, 2024

349 is closed.

I don’t really understand the hesitation with the delivery and signup notes. Seems to me adding the latter solves a lot of problems.

@chadmohr
Copy link
Member Author

@teesloane the notes bstill show on mobile
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
4 participants