Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTS example do not follow current specs #459

Open
bpinsard opened this issue Jul 31, 2024 · 3 comments
Open

MTS example do not follow current specs #459

bpinsard opened this issue Jul 31, 2024 · 3 comments

Comments

@bpinsard
Copy link

In https://osf.io/k4bs5/ ds-mtsat uses outdated/pre-BEPS _acq-<MTOn|MTOff|T1w> rather thank _flip-<index>_mt-<on|off> which can confuse willing BIDSonauts. ;)

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Aug 2, 2024

So in general we do allow some divergence between examples and the data that were used to generate them. But indeed this can be confusing...

@agahkarakuzu
would you be OK if we moved those examples to openneuro?

This actually may be a good policy for examples in general because would help make sure that the datasets are at least kept valid (and easier to update)

@bpinsard
Copy link
Author

bpinsard commented Aug 2, 2024

Another thing I noticed in the examples are the very scarce metadata.
If the dicoms still exists, it would be great to have all the metadata that dcm2niix now produces by default in the sidecar.
I am mainly thinking about pulse sequences info and other MR related options.

@bpinsard
Copy link
Author

bpinsard commented Aug 2, 2024

Also regarding continuous BIDS-compliance testing, if the dataset is datalad with a fork hosted on github for the git part (full dataset can be on openneuro), we can set up github actions to run the bids-validator when changes are made and also scheduling it (~1/month) with latest bids-validator.
for example:
https://github.com/courtois-neuromod/anat/blob/main/.github/workflows/bids-validator.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants