Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Sort players by rating descending inside balancer_server #466

Open
jauggy opened this issue Sep 13, 2024 · 2 comments
Open

[Feature]: Sort players by rating descending inside balancer_server #466

jauggy opened this issue Sep 13, 2024 · 2 comments
Assignees
@jauggy
Labels
feature request Not broken but something we want added medium priority

Comments

@jauggy
Copy link
Member

jauggy commented Sep 13, 2024 •
edited
Loading

Describe the Feature

Sort players by rating descending inside balancer_server. Specifically a bug was introduced in this commit: 4a90ab1

where players were sorted by player name descending. While reverting the commit fixes this, there are a lot of inefficiencies. In the old code we need to calculate the rating type and then fetch the rating for each player again. If it was presorted, then spads_controller would not need to sort it.
@jauggy jauggy added feature request Not broken but something we want added low priority labels Sep 13, 2024
@jauggy jauggy self-assigned this Sep 13, 2024
@L-e-x-o-n L-e-x-o-n added bug Something isn't working high priority High priority features or critical bugs and removed feature request Not broken but something we want added low priority labels Sep 13, 2024
@L-e-x-o-n L-e-x-o-n changed the title [Feature]: Sort players by rating descending inside balancer_server [Bug]: Sort players by rating descending inside balancer_server Sep 13, 2024
@jauggy
Copy link
Member Author

jauggy commented Sep 13, 2024

Just to add comment this is a ticket to make it more efficient - not to fix the bug. You can fix the bug by reverting your commit or reverting part of it.

@L-e-x-o-n L-e-x-o-n added feature request Not broken but something we want added medium priority and removed bug Something isn't working high priority High priority features or critical bugs labels Sep 13, 2024
@L-e-x-o-n L-e-x-o-n changed the title [Bug]: Sort players by rating descending inside balancer_server [Feature]: Sort players by rating descending inside balancer_server Sep 13, 2024
@L-e-x-o-n
Copy link
Collaborator

Sorry for the mess, it is a feature yes, the bug will be fixed by reverting the latest code changes to spads_controller.ex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jauggy jauggy

Labels
feature request Not broken but something we want added medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jauggy @L-e-x-o-n