bug: env variables not injected in bento container

[rlleshi]

Describe the bug

As per the docs here, env variables should be injected in the resulting docker container. However, these variables are not actually being injected and are not available inside the container at runtime.

To reproduce

No response

Expected behavior

Env variables defined via the bentofile should be injected inside the container.

Although it appears that they are actually injected when defined inside the env attribute of the docker attribute inside the bentofile.

Is the documentation perhaps outdated?

Environment

bentoml: 1.2.16
python: 3.9.0
platform: ubuntu 22.04

[aarnphm]

I can't seem to reproduce this with bentoml 1.3

As you can see here, the env HF_TOKEN is injected correctly from bentofile.yaml:

service: 'service:VLLM'
labels:
  owner: bentoml-team
  stage: demo
include:
  - '*.py'
  - 'bentovllm_openai/*.py'
python:
  requirements_txt: './requirements.txt'
  lock_packages: false
envs:
  - name: HF_TOKEN
docker:
  python_version: 3.11

[rlleshi]

Hi @aarnphm this seems to be happening when you define the docker.env field.

So if you have a different set of variables on envs and you define another set of variables on docker.env, then the variables of envs are not taken into account.

service: "service:TestService"
include:
  - "*.py"
envs:
  - name: "TEST_ENV"
    value: "test"
docker:
  distro: debian
  python_version: "3.10"
  env:
    TEST_ENV_2: "test"

TEST_ENV won't be available during runtime.

[aarnphm]

@frostming iirc the docker.env will be deprecated soon in light of envs?

Should we print out a warning then for now just merge the docker env to the above env?

[rlleshi]

that would be helpful as I ended up wasting quite a bit of time on this