Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CfnParameters and passing parameters to NestedStacks #2

Open
bensoer opened this issue Jul 8, 2022 · 0 comments
Open

Add CfnParameters and passing parameters to NestedStacks #2

bensoer opened this issue Jul 8, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bensoer
Copy link
Owner

bensoer commented Jul 8, 2022

Background
Currently all settings and configuration is done in CDK code. This means its done at synthesis, producing no parameter values for the generated CloudFormation code.

Problem
In order to integrate with the AWS Marketplace or increase further integrations in more ways. Settings at synthesis is not enough

Resolution
Implement CfnParameters at the root cdk-photo-archive stack. To work with the existing parameters set at synthesis time, make the default values for all CfnParameters to that of the configured values.

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.CfnParameter.html
https://bobbyhadz.com/blog/aws-cdk-parameters-example

Implementing this may also require different handling of conditional logic which now needs to be pushed to at runtime rather then syntehsis time: https://loige.co/create-resources-conditionally-with-cdk/

Configure also NestedStack parameters to pass around the needed parameters from there too: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.NestedStack.html#parameters

@bensoer bensoer added the enhancement New feature or request label Jul 8, 2022
@bensoer bensoer self-assigned this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant