Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify stub handling to allow for console and GUI stubs #48

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Conversation

freakboy3742
Copy link
Member

Modifies the stub handling so that there are 2 binary stubs - one for GUI, and one for console.

The post-processing step moves the correct binary to the Stub name (rather than <Formal Name>), and deletes the unneeded binaries. The Stub name is used as part of a fix for beeware/briefcase#1729.

This PR cannot be completed until beeware/briefcase-windows-VisualStudio-template#29 is completed, as the new app binaries need to be generated using the new VisualStudio template.

Refs beeware/briefcase#1781

Briefcase-Repo: https://github.com/freakboy3742/briefcase.git
Briefcase-Ref: cmdline-app

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 marked this pull request as ready for review June 4, 2024 02:54
@freakboy3742
Copy link
Member Author

I've now pushed updated binaries for the console and GUI stubs; this should be ready for final testing.

@mhsmith mhsmith merged commit 49b0fd3 into main Jun 5, 2024
11 checks passed
@freakboy3742 freakboy3742 deleted the console-app branch June 5, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants