Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Bluedot disabled, you can still load bluedot rules #112

Open
beave opened this issue May 18, 2018 · 1 comment
Open

With Bluedot disabled, you can still load bluedot rules #112

beave opened this issue May 18, 2018 · 1 comment

Comments

@beave
Copy link
Owner

beave commented May 18, 2018

No description provided.

@red8383light
Copy link
Contributor

Just an idea:

rules.c - line 2760

Possible fix:

change
if (!strcmp(rulesplit, "bluedot"))
to
if (!strcmp(rulesplit, "bluedot") && config->bluedot_flag == 1)

Looks like rules.c checks to see if the "WITH_BLUEDOT" is set and then checks for "bluedot" in the rule name and then loads the rule.
Changing the if statement to check if the "bluedot_flag" is set first should allow it to skip loading the rule if bluedot is compiled and bluedot is not enabled but rules are enabled.

To be honest... there was no testing of code involved, just reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants