Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we change the name from support_table_cache to something involving find_by? #1

Open
joslinm opened this issue Jun 14, 2022 · 0 comments

Comments

@joslinm
Copy link

joslinm commented Jun 14, 2022

Since the kind of table it is is never taken into consideration, should the name be more straightforward? find_by_cache instead of support_table_cache? Or cache[d]_find_by?

I think this could also make the config sound more natural:

class Bicycle < Model
  # more declarative sounding this way
  cache_find_by expires: 5.minutes, ignore: [:handles, :tires]
  # vs
  support_table_cache expires: 5m , etc... 
@joslinm joslinm changed the title Should we change the name from support_table_cache to something involving find_by? Should we change the name from support_table_cache to something involving find_by? Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant