Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary #3

Open
mp1pro opened this issue Nov 11, 2017 · 1 comment
Open

Summary #3

mp1pro opened this issue Nov 11, 2017 · 1 comment

Comments

@mp1pro
Copy link

mp1pro commented Nov 11, 2017

The project came out very well. The code was nicely indented and easy to follow. My only suggestion would be to do some more reading on props and state. Here ia great reference: https://facebook.github.io/react-vr/docs/components-props-and-state.html
@bcmcadam
Copy link
Owner

Thanks for you feedback, I've implemented your suggestions and will definitely read up a little more on state. Do i need to re-submit or anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcmcadam @mp1pro