From f26e6b765f1b7596ab694eef716f98246525c61c Mon Sep 17 00:00:00 2001
From: f-w <fred.wen@gov.bc.ca>
Date: Wed, 13 Dec 2023 15:29:52 -0800
Subject: [PATCH] pullAll doesn't modify source array

---
 .github/values.ocp4.dev.yaml.gpg              | Bin 1460 -> 1472 bytes
 .../buildTestPublishContainerDeploy.yml       |   1 +
 .../notifications/notifications.controller.ts |   4 ++--
 src/config.ts                                 |  17 -----------------
 4 files changed, 3 insertions(+), 19 deletions(-)

diff --git a/.github/values.ocp4.dev.yaml.gpg b/.github/values.ocp4.dev.yaml.gpg
index a429c2cc2467fddc25103f250047433d5c68b15d..0bbdf8a98fafdad2904fb977e8acdfb2388bb8ba 100644
GIT binary patch
literal 1472
zcmV;x1wZ<X4Fm@R0;Mrna+)|z&*IYR0g?(?BhHs1B+k<L@1DXK4}a2c?QmO=Vy85K
zci-eN(Ohjv2II7;oT3Hy(TN%vHr8H?1-y^;fiI?4<3d2&SoZQ9I8O}2m%1ZeT#Xq0
zNE)DI%m`9putSN_<keo*QUM~cM(R6XI#s<Ht_$-l67uO0s00FdICus)_cisb-6}XP
zp)bR{WS;4wuRzci75xyk5tiAm-e_1^95h_lLzLAt6Y}+|S7fbo;>6cTq1pZjzKR&Z
zyxGdlc8$~T@-g`P3#R25PF852;p0CZEz-7(uFC|B&L)OXmZ+m&X<GaWBo7^89neSn
zu+@^wM~_+{ZyS#oTamDYPmVr*>c?lX+eK9;E^_Z`-OM2-=J~@g4#vy!MYWSB0*I2h
z*nu<xRm7S{N2UpGbRE1EZ0H(@OWO;T>r|Blywni!bxIorP@amyDEjZdrzXZo7%~_X
z2xez0BKv_9kz|YUhn=W5#YMCvUuQ6I>eTtRzS&Mx#_wn<(J>)b$9t6Qx=sqg5)24y
z9%W8Mmlw7o-BfL?O_V}5y^r6|P>p1v4YnSydv=~k%|7s4C180XZ~sY1l`)L_UthK^
z;`rJ-!M@5~N~wM;N+VXcaZ_V%HvBc`!Z5+&-lEp-T!duopVrwhgSZaN`cgiV--MXR
z#^>e&KuMQ*^k|^_X)?@KS6kHT@#gqG%)o#X4%iM!#vz(rtqLvP|F8T;(@dRUW~O;=
z(z0p@-~r_(7YW5r0i%ZTWFsR}p-;CIPY&-{^j;yD&bHIiP~%h?2q8V?7m*vc7&T(=
zycwt*qe)Ty0O5vjF!T!ia1=>T<!aSG5<5>o>tN$2HE~Z@x8NRB=u2usB!8_Wxsn~0
zNjg}K7Q}}NvS>@jn1qu~2>tg1@ju22{y*n9eWpRc$*(dA=s08Zc{{cm{Hxx9)1wFi
zn^$qRt_srP@ARYpORYdR<Y|E1Pb*stp2FU@XN|u`6XUJ0z#e~;69yMpB1y*-?YM3D
z%}AM@h(X6OmGO6Gmccw(JYhimjup1L2;77NF8=VWkX(R*FAsSzGOhR?{BIT=Y6HPe
zxO~5gj9YOiqNJ?8^(}XhCg2oq<D0U`4-XZJ@&_|LdBB<nfIjf;1YsSkROkIM>PeYV
zN^J&{jdfyLNXS8Jo&am|vO?$}7?Pi>bt5~B3#lGhz)#2?N$phXn`a<5&JApUHV@(r
zfWOt&@p{^e_g8WHlgqC*hmGY%=|jV2NpOTL8q*6#DqEeIolvu-VmwynsQjGuZ|=Fh
z8^kw3dCwuXS~rwy>4q8TR*4xf1p;v?YnJuN2ah`Pu4WBFz*tZ9XV^m5Sb@AXW%yI4
zP077<r^4-r!0n$wTO+#l5e==d>GDkY1<<w^8FhlH(GvBQ;Cywwa=6$!g@J%6|8TX_
z``y%^0TwrGw7tKT-I$a$8E4^cd-Ke@#p=MVzZ~=8Dr4>QvPj5axn!5`meTXFqP%|B
zJH2MmnBX{?8b<n#WE{yxRj|yMrs2KMKP>?Grlh9O?5^_&wAE;n1~taWk$$cx5Tjra
zZC9`j3dEFA4}gMZYNT~oYe~GndOONa+qO3wC&U2UX8J8OQb>`ePO_hUwQ0p2ElIuD
zsA=FMYukw@)h`rRJA5+k^2N8ice2C+!X8u-7u@n6AS}qSCr5KQ&&huRtjsQKFo~Z@
z&Tc#uTMBco3Qn$?#?<5|1MT5D_Kd%$6-b+Q!)yI6S7#@zcY_;Z7QvbkyV!f6ZXS@g
z|H>o^TkShNPGrCMRi_J8S)A|VoWNrfQ-D6iX>tXwk}6~V+fG|-f6YfW0R-A7&bqdR
zqU%d()QY>X06m4RZ@I8Y3R=u}?|N{dn|(f0Qgp~<bB*%N+`(7oE(LGhwnPT_>FbGw
awo^(q^F%ntcL+!!Lk8oS{_1`nxHS25-rSb}

literal 1460
zcmV;l1xxyj4Fm@R0;MW4C4K(kZsOAF0eq(6$>sg5ogBrDM2rrZ9$xr*L?cj7jbqR{
zoYi&(NM4oK!x?Owd<`Y^zb??_n8P8ohT23eUpl@%4B#a>Fb@rfXVwY-@hlhY%1>hW
zH=A338ZgcXR^AZyM;_;&ibuk9^kS{XawW2y@mh09QIEP_&bEZI>e7*a@BfeuH!oG7
z8<4!OiV|i7usW^dgpcF4Mqsqgc-c2B)$lgfN^^W3PHRw|PHR~NJLU@g)xQ{*a!a8P
zRI~+|j0iYf#hNFF2Zhew<xtrO`Nt$Hk(k10cSOi+Q0r9DFJGIwpKGbEaN6Lt7SCfe
z8_i_63|c*&p@?yko_1%s0Vu!ulb7Bo1<Q<&C{Z{<*7u3mVZQrYRx~qk=V@>a*@Q7!
zfK>Ipip{Kvyb@cF)p>VOwDAF2pAW+bG(?w&Ox;Ss(?>IoktD-nr;EW@2i2@cAObQ1
zfELc7N>d7nrFesvAEx&R`UL>}J2e$=-_oc0)dhyWL_9-!?TLWR=zxzyxmE+?p*ri2
z!c`vG<^}qk3R33!i0#Ej=q`48gbZoR2ooG#Aqfzj(~AnVj{x4okdIwsz--z|36Pre
zFil%dJ|JxCh^T%{+wQ<rx3@#o#l|d4y!&JG7mbztFHK)n7-zTH-JY+W=|1?K$g2f5
zK$@DvRy-_P;Lg7-DIADn8x*{Dl&k+sSN>_Uvnuk*gZw47%=;vB&Nzmc+T|I*So#3d
z+z3S=;+FLJrSiX&pPlzg5%BF1{Fhs=)M(MU*$0Vi3_sg!T0w!VEYKSz6KJKD9oUrH
zsnzx1dc`h3wXgog3@i{-VbPG>MAcE_`mGbPMs@b(vK2NL8lzQD|4+l-OG>d6<D9&=
z@kBUDKun_9xkEC*QO-0LlmMePq*IaUoh0Zq;N7%~i7X4mr5Kp*6}2o;o*Zs0>=cEI
zQTr>8MvT1y*9@0H2oz2zK)nZ~dMvCcFfa^iP=M7;&#1}S=LVWEa7auah0ETQ8p;y4
zubmEl;S%}t_~Yt&>0SOi_3Fy3WSMwgl`2-F{3YFpCJ0TEm42i7v2uS_XSr=t9latr
z$)5*4mzrS4GV4snW@|35+9qDasS7zi@Xbp(VSbSp2gWaKvymo_`w)U~r{iW>Dc5^<
zqhEsbjgq6an=x2r2op1$YqS1!etiq0{o?Q&-<ia=t>zk3{Dk`~msKm3;79?kZ{u_P
zq=8k6>kw0$>9hty&h0ko_V&kB&zME*SqtuG)ZAB;zQnp06>zyy`-sqg+NvSXir^C&
zCRYKpFl6W8?MHVqao>Z}1I_%!Ne%*iIZm*|y1v?DfTwyQ&0KB6AjeE|N*=8`tTY_Y
zcny|`oj-oIz~O*}Di9mA5U(L)Lg<O7z7hg&`hy9FU|6)gSEyg8{eU1yy~C_?&sLgA
z)nB<4Xl0cYT?M*q)m?n@crt7$Bq|a6Q^r9p2b9LjC=NtL8IJeqOedKH;M`O4VpOr1
zU-iBWgbaRF+*YG_Pc>3hhe>)&GDIr#VZdK+JhRAYLT{hLC*f@zZbHH+Jo}^1Do_lx
zk;3`d{443~G&OdEeroze8;~ndV{v-nqb3PHq^8ZqOK5TPe&jp7rbfJ<%<zOkZe!Xs
zLl;d4%;V$&0;_gk=eS(c$H<u&r4a1Wq8ixGC<G;mWi5F#yRQ14qTJ<U<HjVwZ9>wL
z({ZAZ@_=-sojwhZA#eF|EIlnvmtH)C;tfEX#k+ks$JO{g!g2?{;z9b4V4NY{RpfWL
zNkfwx4w3gyA6!va)Zpr~!IO-WrGR&~!V+=ZgZ@)~`KS}hV-LCgD6f|{#f{Vi=^!mH
zM9?#9lao5{I$Ip%Jc0imQLKs-f5f(mj0UhBMtz1e5K8{x7_Lgx#Fr-EwMwN}^8ZQ=
Ox)D$~OfdwoUPU>}1lQ^S

diff --git a/.github/workflows/buildTestPublishContainerDeploy.yml b/.github/workflows/buildTestPublishContainerDeploy.yml
index 9ec36dd8a..af63c9dff 100644
--- a/.github/workflows/buildTestPublishContainerDeploy.yml
+++ b/.github/workflows/buildTestPublishContainerDeploy.yml
@@ -3,6 +3,7 @@ on:
   push:
     branches:
       - main
+      - pullAll
   release:
     types:
       - published
diff --git a/src/api/notifications/notifications.controller.ts b/src/api/notifications/notifications.controller.ts
index 706bf87b5..f58526a93 100644
--- a/src/api/notifications/notifications.controller.ts
+++ b/src/api/notifications/notifications.controller.ts
@@ -460,11 +460,11 @@ export class NotificationsController extends BaseController {
     this.appConfig.email?.listUnsubscribeByEmail?.enabled;
 
   async broadcastToSubscriberChunk(data, startIdx) {
-    const subChunk = (data.dispatch.candidates as string[]).slice(
+    let subChunk = (data.dispatch.candidates as string[]).slice(
       startIdx,
       startIdx + this.broadcastSubscriberChunkSize,
     );
-    pullAll(
+    subChunk = pullAll(
       pullAll(
         pullAll(
           subChunk,
diff --git a/src/config.ts b/src/config.ts
index b57cfc4b4..bf2f85e59 100644
--- a/src/config.ts
+++ b/src/config.ts
@@ -35,23 +35,6 @@ const config: Record<string, any> = {
   host: '0.0.0.0',
   // port listen on
   port: 3000,
-  remoting: {
-    rest: {
-      normalizeHttpPath: false,
-      xml: false,
-      handleErrors: false,
-    },
-    json: {
-      strict: false,
-      limit: '100kb',
-    },
-    urlencoded: {
-      extended: true,
-      limit: '100kb',
-    },
-    cors: false,
-  },
-  legacyExplorer: false,
   adminIps: ['127.0.0.1'],
   siteMinderReverseProxyIps: ['127.0.0.1'],
   email: {