Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bzlmod #123

Open
2 of 4 tasks
alexeagle opened this issue Jan 18, 2023 · 4 comments
Open
2 of 4 tasks

Support bzlmod #123

alexeagle opened this issue Jan 18, 2023 · 4 comments

Comments

@alexeagle
Copy link
Collaborator

alexeagle commented Jan 18, 2023

  • Create MODULE.bazel file and e2e test in this repo
  • Setup the Publish-to-BCR app and publish a release to the Bazel Central Registry
  • Provide instructions for bzlmod users
  • Gazelle extension should work with bzlmod
@chrismgrayftsinc
Copy link
Contributor

This seems at least partially done with #170

@alexeagle
Copy link
Collaborator Author

Seems that there's not a dedicated "e2e" test module, the whole repo is used in the bcr testing. https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/contrib_rules_jvm/0.13.0/presubmit.yml#L13

The Publish-to-BCR app isn't configured, but a release was done manually.

I don't think instructions were updated nor is the gazelle module accessible so I'll leave this open.

@vorburger
Copy link

https://registry.bazel.build/modules/contrib_rules_jvm ? (I have NOT tried it.)

@shs96c
Copy link
Collaborator

shs96c commented Jul 16, 2024

We ship everything in one unit rather than breaking out the gazelle plugin separately. Adding a bzlmod dep on contrib_rules_jvm should make everything available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants