New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include_vars in add_clients clobbers group_vars #42

Open

senorsmile opened this issue Dec 18, 2017 · 0 comments

Contributor

senorsmile commented Dec 18, 2017

The line defined here: https://github.com/bau-sec/ansible-openvpn-hardened/blob/master/playbooks/roles/add_clients/tasks/main.yml#L3

- name: OpenVPN | Add Clients | Set variables
  include_vars: ../../openvpn/defaults/main.yml

clobbers any vars defined in inventory, group_vars, host_vars and even at the site.yml to pass in vars.

I understand what is trying to be done there, but I would argue that include_vars isn't the right solution. What would be a good solution?

The only thing I can think of is to bring in the defaults folder from the other role as a symlink into this role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment