Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Doesn't allow localStorage #5

Open
bossinfo opened this issue Aug 26, 2020 · 1 comment
Open

User Doesn't allow localStorage #5

bossinfo opened this issue Aug 26, 2020 · 1 comment

Comments

@bossinfo
Copy link

Just a question...
Where does the theme can't write to localStorage for whatever reason? Will it then be saved on a backend database so it can be retrieved when they come back to the website?
You can't really make it a requirement if their company policy says otherwise.

Thanks in advance

@bareynol
Copy link
Owner

Hey thanks for the input, I hadn't considered company policies disallowing local storage on the browser.

As of right now, a backend database holding user data is outside of the scope of this project, so I have no current plans for something like that. Unfortunately this means that anyone with no access to local storage won't be able to save themes, and they'll be wiped on refresh.

That being said, I've now (thanks to your input) tested the app with local storage disabled on Chrome, and found that it doesn't crash the app, only preventing it from saving and rehydrating the theme data.

I'll add a component that detects if local storage is disabled, and if so, adds a note to the Saved Themes tab notifying the user that their themes will not be saved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants