Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default colorName when configure captains-log #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leosuncin
Copy link

@leosuncin leosuncin commented Jun 4, 2018

There's an error when use captains-log with Mocha 5, maybe due how mocha mocks/intercepts console logging (I don't know for sure).
This change doesn't add or modify any current features.

fixes balderdashy/sails/#4395

There's an error when use `captains-log` with Mocha 5, maybe due how mocha mocks/intercepts console
logging (I don't know for sure).

fixes balderdashy/sails/#4395
@leosuncin leosuncin changed the title Use default colorName on configure captains-log Use default colorName when configure captains-log Jun 4, 2018
mikermcneil added a commit that referenced this pull request Jun 25, 2018
@mikermcneil
Copy link
Member

@leosuncin thanks! Just to be explicit about this and prevent confusion, I set it up to default to white.
No idea why this is happening with Mocha 5, but a failsafe here doesn't hurt anyway: See 5f6ecfd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Mocha 5: Sails is failing to lift inside Mocha tests due captains-log issue
2 participants