Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOR - Service - Refactor to improve readability and maintainability #850

Open
brunoguerios opened this issue Aug 26, 2024 · 0 comments
Open
Assignees
Labels
chore maintenance related

Comments

@brunoguerios
Copy link
Member

Code could be better organized to make it easier to onboard other team members, so more people are able to provide proper support.

Suggestions:

  1. rename functions so they are easier to differentiate (e.g. getSorSwapPaths, getSwapPathsFromSor, sorGetPathsWithPools, etc.)
  2. separate helper from main functions is a more clear way (e.g. break into separate files)
  3. better separate sorv1 from sorv2 implementation
  4. restructure files/folders (considering there will be not only pools for v2 and v3, but also hooks for v3 soon)
  5. ...
@brunoguerios brunoguerios added the chore maintenance related label Aug 26, 2024
@brunoguerios brunoguerios self-assigned this Aug 26, 2024
@brunoguerios brunoguerios changed the title SOR - Refactor to improve readability and maintainability SOR - Service - Refactor to improve readability and maintainability Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore maintenance related
Projects
None yet
Development

No branches or pull requests

1 participant