From d3e7248eb2affa8df0582823351707f3c539ee18 Mon Sep 17 00:00:00 2001 From: Walid Baruni Date: Sun, 13 Oct 2024 15:38:10 +0200 Subject: [PATCH] remove makefile target --- .github/workflows/swagger-validation.yml | 8 ++------ Makefile | 4 ---- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/swagger-validation.yml b/.github/workflows/swagger-validation.yml index 7431367154..1c4f9cef9d 100644 --- a/.github/workflows/swagger-validation.yml +++ b/.github/workflows/swagger-validation.yml @@ -19,7 +19,6 @@ jobs: - name: Install Swag run: | go install github.com/swaggo/swag/cmd/swag@latest - shell: bash # Step 3: Verify swag installation - name: Verify Swag Installation @@ -28,23 +27,20 @@ jobs: echo "Swag is not installed. Please ensure Go is properly configured and Swag is installed." exit 1 fi - shell: bash # Step 4: Generate the swagger.json - name: Generate Swagger file run: | - make generate-swagger - shell: bash + ./scripts/generate-swagger.sh # Step 5: Compare the newly generated swagger.json with the committed swagger.json - name: Check for Swagger differences run: | git diff --exit-code pkg/swagger/swagger.json - shell: bash # Step 6: Fail the build if Swagger doesn't match - name: Fail if Swagger has differences if: failure() run: | - echo "Swagger is outdated. Please regenerate it with 'make generate-swagger' and commit the changes." + echo "Swagger is outdated. Please regenerate it with 'bash ./scripts/generate-swagger.sh' and commit the changes." exit 1 diff --git a/Makefile b/Makefile index d1c41e134a..f8f09c4162 100644 --- a/Makefile +++ b/Makefile @@ -474,7 +474,3 @@ release: build-bacalhau .PHONY: spellcheck-code spellcheck-code: cspell lint -c cspell.yaml --quiet "**/*.{go,js,ts,jsx,tsx,md,yml,yaml,json}" - -.PHONY: generate-swagger -generate-swagger: - ./scripts/generate_swagger.sh \ No newline at end of file