diff --git a/thread/common/omrthreadattr.c b/thread/common/omrthreadattr.c index b792a5c9fc8..8723cc7c458 100644 --- a/thread/common/omrthreadattr.c +++ b/thread/common/omrthreadattr.c @@ -33,7 +33,7 @@ #include "omrthreadattr.h" #define J9THREAD_ATTR_IS_VALID(attr) ((attr) && (*(attr)) && ((*(attr))->size == sizeof(omrthread_attr))) -#define J9THREAD_VALUE_OUT_OF_RANGE(val, lo, hi) (((val) < (lo)) || ((val) > (hi))) +#define J9THREAD_VALUE_WITHIN_RANGE(val, lo, hi) (((val) >= (lo)) && ((val) <= (hi))) static intptr_t failedToSetAttr(intptr_t rc); @@ -220,7 +220,7 @@ omrthread_attr_set_priority(omrthread_attr_t *attr, omrthread_prio_t priority) return J9THREAD_ERR_INVALID_ATTR; } - if (J9THREAD_VALUE_OUT_OF_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) { + if (!J9THREAD_VALUE_WITHIN_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) { return J9THREAD_ERR_INVALID_VALUE; } diff --git a/thread/unix/omrthreadattr.c b/thread/unix/omrthreadattr.c index 8fd2b786ca5..d79e6b7973d 100644 --- a/thread/unix/omrthreadattr.c +++ b/thread/unix/omrthreadattr.c @@ -39,7 +39,7 @@ #include "unix/unixthreadattr.h" #define J9THREAD_ATTR_IS_VALID(attr) ((attr) && (*(attr)) && ((*(attr))->size == sizeof(unixthread_attr))) -#define J9THREAD_VALUE_OUT_OF_RANGE(val, lo, hi) (((val) < (lo)) || ((val) > (hi))) +#define J9THREAD_VALUE_WITHIN_RANGE(val, lo, hi) (((val) >= (lo)) && ((val) <= (hi))) static intptr_t setStacksize(pthread_attr_t *pattr, uintptr_t stacksize); static intptr_t setPriority(pthread_attr_t *pattr, omrthread_prio_t priority); @@ -288,7 +288,7 @@ omrthread_attr_set_priority(omrthread_attr_t *attr, omrthread_prio_t priority) return J9THREAD_SUCCESS; } - if (J9THREAD_VALUE_OUT_OF_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) { + if (!J9THREAD_VALUE_WITHIN_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) { return J9THREAD_ERR_INVALID_VALUE; } diff --git a/thread/zos390/omrthreadattr.c b/thread/zos390/omrthreadattr.c index b60727387e4..3ad1c744258 100644 --- a/thread/zos390/omrthreadattr.c +++ b/thread/zos390/omrthreadattr.c @@ -32,7 +32,7 @@ #include "unix/unixthreadattr.h" #define J9THREAD_ATTR_IS_VALID(attr) ((attr) && (*(attr)) && ((*(attr))->size == sizeof(unixthread_attr))) -#define J9THREAD_VALUE_OUT_OF_RANGE(val, lo, hi) (((val) < (lo)) || ((val) > (hi))) +#define J9THREAD_VALUE_WITHIN_RANGE(val, lo, hi) (((val) >= (lo)) && ((val) <= (hi))) static intptr_t failedToSetAttr(intptr_t rc); @@ -229,7 +229,7 @@ omrthread_attr_set_priority(omrthread_attr_t *attr, omrthread_prio_t priority) return J9THREAD_ERR_INVALID_ATTR; } - if (J9THREAD_VALUE_OUT_OF_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) { + if (!J9THREAD_VALUE_WITHIN_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) { return J9THREAD_ERR_INVALID_VALUE; }