Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preset traffic source attributes #10

Merged
merged 3 commits into from
Apr 11, 2024
Merged

feat: add preset traffic source attributes #10

merged 3 commits into from
Apr 11, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. add preset traffic source attributes

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Apr 11, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane April 11, 2024 06:09
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2996028) to head (e17cbab).

Additional details and impacted files
@@             Coverage Diff              @@
##             main       #10       +/-   ##
============================================
+ Coverage   79.79%   100.00%   +20.20%     
============================================
  Files           4         4               
  Lines          99        99               
============================================
+ Hits           79        99       +20     
+ Misses         20         0       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 8e0891d into main Apr 11, 2024
5 checks passed
@zxkane zxkane deleted the traffic-source branch April 11, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants