SQS Error handling

[fabian-grajko]

Confirm by changing [ ] to [x] below to ensure that it's a bug:

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow for answers
• I've searched for previous similar issues and didn't find any solution

Describe the bug
SQSClient throws TypeError when Command input is incorrect

Is the issue in the browser/Node.js?
Node.js

If on Node.js, are you running this on AWS Lambda?
No

Details of the browser/Node.js version
v14.16.1

SDK version number
"@aws-sdk/client-sqs": "3.18.0"

To Reproduce (observed behavior)

• Initialize a new instance of SQSClient
• Create Command with an incorrect input
• .send() invalid command

(node:9571) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'Code' of undefined
    at loadQueryErrorCode (./node_modules/@aws-sdk/client-sqs/dist/cjs/protocols/Aws_query.js:2583:20)
    at deserializeAws_querySendMessageCommandError (./node_modules/@aws-sdk/client-sqs/dist/cjs/protocols/Aws_query.js:1024:17)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Expected behavior
A valid error is thrown.

Additional context
I tested it with SendMessageBatchCommand and SendMessageCommand

[ajredniwja]

@fabian-grajko thanks for opening this, transferred it to the correct repo. Can you please share the specific code that you are using?

[fabian-grajko]

Sure. I reproduced the error using localstack.

const { SQSClient, SendMessageCommand } = require('@aws-sdk/client-sqs');

const client = new SQSClient({
  endpoint: 'http://localhost:4566',
  region: 'us-east-2',
});

const command = new SendMessageCommand({
  QueueUrl: 'http://localhost:4566/000000000000/test.fifo',
  MessageBody: undefined, // This line is causing problem
  MessageGroupId: '1',
});

client.send(command).then(console.log).catch(console.error);

Output:

TypeError: Cannot read property 'Code' of undefined
    at loadQueryErrorCode (./node_modules/@aws-sdk/client-sqs/dist/cjs/protocols/Aws_query.js:2583:20)
    at deserializeAws_querySendMessageCommandError (./node_modules/@aws-sdk/client-sqs/dist/cjs/protocols/Aws_query.js:1024:17)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

[ajredniwja]

@fabian-grajko I get it now, just in general not a good idea to pass undefined there, with that being said, what error do you think should be thrown?

[fabian-grajko]

If MessageGroupId is invalid, the client throws MissingParameter: The request must contain the parameter MessageGroupId.
It would be nice to get a similar error for MessageBody

[dormeiri]

I also have this issue when sending DeleteMessageBatchCommand with a non-existing receipt handle:

    const request: DeleteMessageBatchRequest = {
        QueueUrl: queueUrl,
        Entries: [{Id: 'msg1', ReceiptHandle: 'not-found'}]
    };
    const command = new DeleteMessageBatchCommand(request);
    await this.client.send(command); // Throws "Cannot read property 'Code' of undefined"

It also occurs in DeleteMessageCommand