Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring envoy LISTENER_DRAIN_WAIT_TIME_S environment variable #660

Open
seanr-cardless opened this issue Dec 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@seanr-cardless
Copy link

Is your feature request related to a problem?

The AppMesh Agent provides a LISTENER_DRAIN_WAIT_TIME_S environment variable that can be used to configure how long envoy waits to drain connections.

This currently isn't a property that's configurable through the app-mesh controller. It would be nice if we could configure this drain time so we could properly add enough cleanup time for the other containers to gracefully shutdown in our pod.

Describe the solution you'd like

Allow configuration of LISTENER_DRAIN_WAIT_TIME_S through helm values. A global setting would work.

Describe alternatives you've considered
A description of any alternative solutions or features you've considered.

We're currently constraining our services to gracefully shutdown within the default 20-second envoy drain wait time.

@seanr-cardless seanr-cardless added the enhancement New feature or request label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant