Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling or format messaging for S3 bucket naming convention #39

Open
lenopip opened this issue Mar 3, 2022 · 0 comments
Open

Comments

@lenopip
Copy link
Contributor

lenopip commented Mar 3, 2022

The "WebsiteS3BucketName" bucket name parameter doesn't inform the user of the S3 bucket naming rules nor does the template have format checking/error handling to catch an improperly named bucket. When a user submits an incorrectly formatted bucket name (e.g. sample_bucket), the deployment fails.

Recommend adding an AllowedPattern term:

e.g.
QSS3BucketName": {
"AllowedPattern": "^[0-9a-zA-Z]+([0-9a-zA-Z-][0-9a-zA-Z])$",
"ConstraintDescription": "Quick Start bucket name can include numbers, lowercase letters, uppercase letters, and hyphens (-). It cannot start or end with a hyphen (-)."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant