Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on email adresses with illegal characters #143

Open
philpagel opened this issue May 13, 2022 · 2 comments
Open

Crashes on email adresses with illegal characters #143

philpagel opened this issue May 13, 2022 · 2 comments
Labels

Comments

@philpagel
Copy link

When an email address contains invalid characters (i.e. on-ASCII) mailmerge crashes with a stack trace.
Expected behavior: some kind of error message instead of crash. Ideally, continuing to send the remaining emails.

Example: email: [email protected] which contains an umlaut that shouldn't be there.
Result: UnicodeEncodeError: 'ascii' codec can't encode character '\xfc' in position 10: ordinal not in range(128)

@awdeorio awdeorio added the bug label May 16, 2022
@awdeorio
Copy link
Owner

Thanks for your diligent reporting @philpagel ! This absolutely needs a unit test and a fix.

@philpagel
Copy link
Author

philpagel commented May 20, 2022

After some more reading, it seems that non-ASCII characters are in fact allowed in email addresses if the smtp server announces support for the UTF8SMTP extension.
Sources:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants