Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding cuda feature flag #95

Open
eureka-cpu opened this issue Oct 1, 2024 · 0 comments · May be fixed by #96
Open

Consider adding cuda feature flag #95

eureka-cpu opened this issue Oct 1, 2024 · 0 comments · May be fixed by #96
Labels
cuda

Comments

@eureka-cpu
Copy link
Collaborator

Not all tests require cuda (for instance the json_schema_tests module) and this limits what unit tests can be ran in CI. A feature flag would be nice, so that the default doesn't require cuda to compile.
@eureka-cpu eureka-cpu added the cuda label Oct 1, 2024
@eureka-cpu eureka-cpu changed the title Consider adding cude feature flag Consider adding cuda feature flag Oct 1, 2024
@fishonamos fishonamos linked a pull request Oct 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cuda
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add cuda feature flag fishonamos/atoma-paged-attention
1 participant
@eureka-cpu