Close tag is not working properly on nested elements

[ahshum]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Using bracket-matcher:close-tag to close tag on nested elements is not working properly

Steps to Reproduce

1. Example code

<div>
  <span>
    <div>
  </span>
</div>

2. call bracket-matcher:close-tag on the 2nd div

Expected behavior: insert a </div> tag

Actual behavior: nothing happened

Reproduces how often: 100%

Versions

Atom : 1.21.0
Electron: 1.6.9
Chrome : 56.0.2924.87
Node : 7.4.0

---

Added by @rsese:

Additional Information

From @fauxparse #79 (comment)

The following code will reproduce it:

<div>
  <span>
    <div> |
  </span>
</div>

If the outer tags are all closed, attempting to close the inner div tag will do nothing. Interestingly, if the name of the outer tag has the same prefix as the one you're trying to close (e.g. divine), it also won't work.

This was erroneously reported as a bug in a package I wrote, close-tags (fauxparse/close-tags#2), because at some point bracket-matcher started stealing the alt-cmd-. keystroke for its own nefarious (and, it seems, broken) purposes, so I'm going to take a shot at fixing bracket-matcher. In the meantime, I have an override in my keymap to use close-tags, which does work, although I understand I may sound a little biased when I say so 😉

[karakunai]

I can confirm this, and it's been around for a long time.

Also happening with nested <section>.

In my case <div> will only trigger the problem when I got more than 3 <div> parent, somewhere between 4 to 7 and more. But <section> can trigger this in less than 4.

[karakunai]

And it also happens in my computer with Windows 7 x86 SP1, but now I'm using a laptop with Solus (Linux). The atom version is always the fresh (latest stable).

[karakunai]

What I can see is that the bracket matcher treat the closing bracket of the parent one as the closing bracket, where it shouldn't happen as it is one level higher than the one your'e just typing.

[rsese]

It does look like this has been around for a while, referenced here:

#79

I'm going to go ahead and close that one in favor of this issue since the template is filled out with steps to reproduce.