-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a loading animation when the playground while generating output #915
Comments
@Min2who thanks for reporting this issue ? an example of what you are trying to do with reproduced steps. |
Done @Amzani |
I think there are basically 2 issues:
I'm not familiar with the studio architecture, but as I see, when changes are made in the editor, the FE sends requests to the BE only the first time (to get .js chunks). From there on, no further requests are made when the document gets changed in the editor. This makes me believe that the document generation happens on the FE side only. In my opinion, if possible, it would be worth to focus on the first point as a quick output would make the second point pretty much obsolete. @Amzani what do you think? If further info or creating separate issue would be desired, let me know. |
@tbaroti I agree, will you also be interested in investigating the issue? |
@Amzani I mostly have sw testing experience, besides that a little js/ts and no react, so I believe I couldn't handle the implementation, but if I can be of any help, let me know. Some further observations that may help:
As far as I understand, Studio uses @asyncapi/parser, which uses Spectral (@stoplight/spectral-core), so I believe there's room for improvement some way. |
Hey @Amzani is this issue still open for PR's? |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
When you change the input, open the studio or change the settings, the studio need to ask the backend to re-generate the output, and there can be a significant delay here depending on input and latency to the backend server. Therefore I suggest we add a loading screen to the output view that showcases that it is currently in the process of being generated.
AsyncAPI.Studio.-.Google.Chrome.2024-01-21.18-33-00.mp4
as you can see in the video when we change the document it takes some time to validate it and it shows
Empty or invalid document. Please fix errors/define AsyncAPI document.
instead of this if we can add a loading animation.The text was updated successfully, but these errors were encountered: