fix: google font import and allignment of button #391
Conversation
catosaurusrex2003
requested review from
AceTheCreator,
thulieblack and
Mayaleeeee
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Also the list of venues in the subnav is misaligned |
|
ok. |
|
I have also noted this minute thing |
|
/ptal |
|
@AceTheCreator @thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋 |
It does look better that way @catosaurusrex2003 go ahead with that change! |
There was a problem hiding this comment.
Hey @catosaurusrex2003 , you seem to have removed the hover effect from the navbar.
Expected:
Current:
|
Nice observation @ashmit-coder |
|
Hey @AceTheCreator are we moving ahead with this pr? if yes then @catosaurusrex2003 could you please update the branch |
…nce-website into fix/google-font-import-and-button-allignment
catosaurusrex2003
force-pushed
the
fix/google-font-import-and-button-allignment
branch
from
caf18b7
to
3e3aa79
Compare
|
waiting for your approval @ashmit-coder :) |
@catosaurusrex2003 could you make the |
|
Please resolve the merge conflicts. |
|
fix this alignment issue in the Paris page |
|
This as well. |
|
The ticket card also has some issues, do look into it. |
|
I went through the whole website and now i dont think there are any discrepancies. If any, pls let me know i will resolve them. |
|
Hey @catosaurusrex2003 could you check so for mobile view as well? |
|
done @ashmit-coder |
| @@ -6,7 +6,7 @@ function Button({className, children, overlay, onClick, type, disabled}) { | |||
| disabled={disabled} | |||
| type={type} | |||
| onClick={onClick} | |||
| className={`${overlay ? '' : 'gradient-bg'} text-white h-[54px] rounded-md p-[8px] ${className}`} | |||
| className={`${overlay ? '' : 'gradient-bg'} flex items-center justify-center text-white h-[54px] rounded-md p-[8px] ${className}`} | |||
There was a problem hiding this comment.
I think this is causing an alignment issue in the button(check the ticket button section)
There was a problem hiding this comment.
i am not able to locate any alignment issue.
whats the browser u using? and if possible can you attach the screenshot.
|
LGTM! |
Before google fonts were not working as expected because they were not imported at the top most line of our css. And this was causing CSS Parsing Order issue.
also fixed allignment of text inside button
Changes in FIREFOX:
👆 Before
👆 After
Changes in CHROME:
👆 Before
👆 After
I might not have been able to explain it correctly in the following issue #389
But i hope the code in the PR makes sense.
Fixes issue : #389