Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Address suffix from protobuf and domain types #1629

Open
SuperFluffy opened this issue Oct 3, 2024 · 0 comments · May be fixed by #1630
Open

Remove Address suffix from protobuf and domain types #1629

SuperFluffy opened this issue Oct 3, 2024 · 0 comments · May be fixed by #1630
Labels
core pertaining to the astria-core crate proto pertaining to the Astria Protobuf spec refactor code refactoring or maintainence

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Oct 3, 2024

All our actions (both on-wire protobuf and domain types) carry a Action suffix (except for ValidatorUpdate, which is externally defined, and Ics20Withdrawal, to be close to the penumbra code we share).

The Action suffix is redundant because there is no way to confuse the types for items that are not actions, we don't have a consistency among all actions, and we mostly follow Rust naming conventions, which rejects item names that repeats module names (which is the case for us, as we define the domain types in a module called actions).

We should remove the suffix.

┆Issue Number: ENG-907

@SuperFluffy SuperFluffy added proto pertaining to the Astria Protobuf spec refactor code refactoring or maintainence core pertaining to the astria-core crate labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core pertaining to the astria-core crate proto pertaining to the Astria Protobuf spec refactor code refactoring or maintainence
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant