server.OnDispose from common keys recommendation is missing

[binki]

I can’t find in the source code where the server.OnDispose property is supported. I assume that means there is no typed API provided around it.

When I look at http://owin.org/html/CommonKeys.html , it’s there. When I look in this typesafe wrapper API, it appears that the closest thing is

AspNetKatana/src/Microsoft.Owin/OwinConstants.cs

Line 72 in 9f6e09a

public const string OnAppDisposing = "host.OnAppDisposing";

and

AspNetKatana/src/Microsoft.Owin/BuilderProperties/AppProperties.cs

Lines 79 to 87 in 24aa436

	/// <summary>
	/// Gets or sets the cancellation token for “host.OnAppDisposing”.
	/// </summary>
	/// <returns>The cancellation token for “host.OnAppDisposing”.</returns>
	public CancellationToken OnAppDisposing
	{
	get { return Get<CancellationToken>(OwinConstants.CommonKeys.OnAppDisposing); }
	set { Set(OwinConstants.CommonKeys.OnAppDisposing, value); }
	}

.

I can’t tell from the documentation if the behavior of server.OnDispose and host.OnAppDisposing is supposed to be identical. If it is, it would make sense for a new typed wrapper of server.OnDispose fall back to host.OnAppDisposing to support outdated IIS/SystemWeb. If they have different behaviors, it would be helpful for a new typesafe API for server.OnDispose to be added and the documentation describe the difference in behavior between the two options and maybe to deprecate host.OnAppDisposing.

[Tratcher]

Hmm, I don't know where server.OnDispose came from. It wasn't in the earlier CommonKeys I wrote. Know any servers that implement it?

[Tratcher]

And yes, the described functionality is the same.

[binki]

@Tratcher

Know any servers that implement it?

I don’t. I just stumbled across it at Bobris/Nowin#36 (comment) which states that it is the standard/recommended way to get the token. Maybe that means Nowin implements it, but I haven’t checked it out. I haven’t looked, but I suspect that means it would be good for SystemWeb to be updated to provide it too?

[Tratcher]

Last I checked only SystemWeb provided any such functionality, it'd be more straightforward to update the spec.

[muratg]

We don't plan to add more features to Katana as it stands now.