Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReactiveImagePicker] Building custom deleteDialogBuilder is difficult in case of multiple files. #159

Open
UsamaKarim opened this issue Sep 7, 2024 · 1 comment · May be fixed by #160
Open

[ReactiveImagePicker] Building custom deleteDialogBuilder is difficult in case of multiple files. #159

UsamaKarim opened this issue Sep 7, 2024 · 1 comment · May be fixed by #160

Comments

@UsamaKarim
Copy link

UsamaKarim commented Sep 7, 2024 •
edited
Loading

deleteDialogBuilder handles deleting files internally but exposes a different signature. In the following signature

typedef DeleteDialogBuilder = Future<void> Function(
  BuildContext context,
  void Function(SelectedFile file) onConfirm,
);

onConfirm method is redundant, as internally it already known the selected file.
@UsamaKarim UsamaKarim linked a pull request Sep 7, 2024 that will close this issue
Open
@alejandrogiubel
Copy link

waiting for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: deleting files with deleteDialogBuilder UsamaKarim/reactive_forms_widgets
2 participants
@alejandrogiubel @UsamaKarim