Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify SqrtField and Field traits #42

Closed
Pratyush opened this issue Nov 15, 2020 · 3 comments · Fixed by #422
Closed

Unify SqrtField and Field traits #42

Pratyush opened this issue Nov 15, 2020 · 3 comments · Fixed by #422
Assignees
@solomonjoseph @mmagician
Labels
T-feature Type: new features

Comments

@Pratyush
Copy link
Member

There's no reason for these traits to be separate; every finite field has square roots.
@Pratyush Pratyush added the T-feature Type: new features label Nov 18, 2020
@ValarDragon
Copy link
Member

ValarDragon commented Nov 19, 2020 •
edited
Loading

The missing thing at the moment is an implementation of an efficient sqrt algorithm for cubic extensions AFAIK

@mmagician mmagician self-assigned this Nov 22, 2021
@solomonjoseph solomonjoseph self-assigned this Feb 3, 2022
@Pratyush
Copy link
Member Author

Pratyush commented Feb 3, 2022 •
edited
Loading

Resources on implementing square roots for cubic extensions:

@Pratyush
Copy link
Member Author

Pratyush commented Sep 2, 2022

Done with #422

@Pratyush Pratyush closed this as completed Sep 2, 2022
@Pratyush Pratyush linked a pull request Sep 2, 2022 that will close this issue
Remove SquareRootField, and move functionality to Field #422
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@solomonjoseph solomonjoseph

@mmagician mmagician

Labels
T-feature Type: new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove SquareRootField, and move functionality to Field mmagician/algebra
4 participants
@Pratyush @solomonjoseph @ValarDragon @mmagician