Azure Support #67
Closed
Azure Support #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- duplicate code replaced with an include of the access file
- all result logs combined in one log file - afterScript renamed to notifyScript
- deletes the result log file if it is bigger than 500 KB (default) - max_result_log_size can be set for each backup
- acces script now named by repo so no duplicated script exists - directory structure for backup scripts added
Multiple Optimizations
- backup script: output log inluds now StdOut and StdErr
|
Thanks for the PR! The changes you make look good, but there are a lot of features / changes in this PR which are not part of the issue-/PR-goal. The best course of action would be to split this PR into multiple ones, with one for each feature/change according to the guidelines (see contributing guidelines). The main reasoning is that the commit messages from merging PRs are used to generate the changelog (and of course the simpler review process 😉). As Far as I can see, there are at least 3 different things here to unpack:
|
|
Thanks for the answer. Sorry for the mess, I just kept working after the first change and didn't even think about the pull request. I will create a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options for Azure account name and key added, so Microsoft Azure Blob Storage can be used as remote location. README updated as well.
Closes #66