Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 204 (PWM with float parameters) confuses the compiler #273

Open
facchinm opened this issue Feb 23, 2024 · 0 comments
Open

PR 204 (PWM with float parameters) confuses the compiler #273

facchinm opened this issue Feb 23, 2024 · 0 comments
Assignees
@aentinger
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@facchinm
Copy link
Member

#204 introduced an error in https://github.com/pschatzmann/arduino-audio-tools/blob/c88d3b9f132555ab7cd932a53744fa6c42aa8e0f/src/AudioPWM/PWMAudioRenesas.h#L90 (due to type confusion between int and float).

Proposed fix: change the signature of begin(uint32_t, uint32_t, ...) to begin(int, int, ...)
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aentinger aentinger

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aentinger @per1234 @facchinm