New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows compatible paths #88

Open

laggingreflex opened this issue Feb 23, 2017 · 0 comments

Contributor

laggingreflex commented Feb 23, 2017

In lots of places paths are created by using '/' slashes.

// src/local/fs-helper.js:21
this._baseDir = path.parse(this._sourceLocation).base + '/';

path.sep and path.join should be used instead.

It doesn't cause any major issues right now, but something to consider in a future refactoring

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment